fix: reset NFT image on url change

[takenagain]

Summary

• reset NFT image bloc when media URL changes
• reload videos on URL updates

Testing

• dart format lib/views/nfts/common/widgets/nft_image.dart
• flutter pub get --enforce-lockfile --offline
• flutter analyze

---

https://chatgpt.com/codex/tasks/task_e_689083341eb4833195b2eb0763e772a6

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability when updating NFT images and videos, ensuring that media reloads correctly if the URL changes. This enhances consistency and prevents display issues when content is updated.

[coderabbitai]

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

The update introduces explicit keys for image and video fallback widgets in the NFT image component to ensure correct widget identity. It also adds didUpdateWidget overrides to handle URL changes, resetting and reloading the media through bloc events and, for videos, disposing the controller before reloading.

Changes

Cohort / File(s)	Change Summary
NFT Image Widget State Management lib/views/nfts/common/widgets/nft_image.dart	Added explicit ValueKey for image/video fallback widgets; implemented didUpdateWidget in state classes to reset and reload media on URL changes, including controller disposal for videos.

Sequence Diagram(s)

sequenceDiagram
    participant UI as NftImage Widget
    participant Bloc as NftImageBloc
    participant State as _NftImageWithFallbackState/_NftVideoWithFallbackState

    Note over UI: User triggers image/video URL change
    UI->>State: didUpdateWidget called
    State->>Bloc: NftImageResetRequested
    State->>Bloc: NftImageLoadRequested(newUrl)
    alt Video Widget
        State->>State: Dispose and clear video controller
    end
    Bloc-->>State: Updated media state
    State-->>UI: Render updated image/video

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

bug, QA

Suggested reviewers

• smk762
• CharlVS

Poem

A widget hops with nimble feet,
Now keyed to keep its state so neat.
When URLs change, it knows the score—
Resets, reloads, and shows once more.
With blocs in sync and videos new,
The NFT display feels fresh as dew!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d9bb03c and 8575e6c.

📒 Files selected for processing (1)

• lib/views/nfts/common/widgets/nft_image.dart (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: unit_tests
• GitHub Check: Test web-app-linux-profile
• GitHub Check: Test web-app-macos

🔇 Additional comments (4)

lib/views/nfts/common/widgets/nft_image.dart (4)

30-30: Good implementation of ValueKey for widget identity.

The addition of ValueKey(imageUrl!) correctly ensures that Flutter recognizes the widget as different when the imageUrl changes, enabling proper state management and rebuilding.

---

40-40: Good implementation of ValueKey for video widget identity.

The addition of ValueKey(imageUrl!) ensures proper widget identity management for video components, allowing Flutter to correctly handle URL changes.

---

89-97: Excellent implementation of URL change handling.

The didUpdateWidget override correctly detects URL changes and properly resets the bloc state before requesting a new load. This ensures clean state management when the image URL changes.

---

216-227: Comprehensive video URL change handling with proper resource cleanup.

The implementation correctly handles video URL changes by disposing the controller, clearing state, and resetting the bloc. This prevents memory leaks and ensures proper video reloading, fully addressing the PR objectives.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch codex/implement-didupdatewidget-in-nftimagestates

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Copilot]

Pull Request Overview

This PR fixes an issue where NFT images and videos were not properly resetting when their media URLs changed. The solution involves adding proper widget lifecycle handling to ensure content reloads when the URL updates.

• Adds Key widgets to force recreation of image and video components when URLs change
• Implements didUpdateWidget lifecycle methods to detect URL changes and reset/reload content
• Ensures proper disposal and resetting of video controllers when video URLs change

[takenagain]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[takenagain]