Tag parent coins as native by smk762 · Pull Request #2988 · GLEECBTC/gleec-wallet

smk762 · 2025-07-25T10:22:06Z

To Test:

login
go to coin menu
search for ARB, ETH, ATOM, AVAX etc (any tendermint or evm parent)
it should be tagged as native.
Check other views to confirm tag is consistently applied.

This PR also includes a slight performance boost via cached typeName and isParent props for the Coin model, and some unrelated error handling improvements which arose to be slain during this campaign.

coderabbitai · 2025-07-25T10:22:13Z

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch tag-parents-native

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-07-25T10:25:27Z

Visit the preview URL for this PR (updated for commit 41394db):

https://walletrc--pull-2988-merge-lexwjacj.web.app

_{(expires Mon, 08 Sep 2025 14:33:03 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc}

CharlVS · 2025-07-25T11:01:31Z

@smk762 please include screenshots

smk762 · 2025-07-26T09:26:30Z

@smk762 please include screenshots

Roll SDK for critical KMD API pricing fix

Co-authored-by: charl <charl@vanstaden.info>

…fine (#3037) * refactor: simplify Docker env vars and build command logic - Remove unnecessary environment variables from Docker container - Keep only GITHUB_API_PUBLIC_READONLY_TOKEN as env var - Replace hardcoded build logic with conditional credential handling - Add proper validation for Trello and Cloudflare feedback services - Use dart-define flags instead of environment variables for build configs - Add warning messages for incomplete credential sets * fix executable rights on build.sh * remove the redundant FEEDBACK_TEST_URL, as it will no longer be used in the GUI * swap BUILD_COMMAND and BUILD_CMD (important) BUILD_CMD, which is built dynamically with --dart-define= arguments, should be called last (not during the assets-fetch stage) to ensure the app is actually built with the required defines and that all String.fromEnvironment(...) statements in the Dart code work as expected.

… NFT image loading (#3020) * feat(nft): tolerate activation failures * fix(nft): skip missing parents in firstWhere Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * refactor(nft-main-repo): fix parent coin filter and use logging package * fix(nft): don't return an error if there are no NFTs returned * fix(nft): revert map-based error responses in favor of manual activation * fix(skeleton-list-tile): add height constraint to fix renderflex assert * fix(coin): temporarily skip calling deactivation RPC circumvent "NoSuchCoin" error when re-enabling the coin in the same session. * fix(activation): use more complete coin conversion function * feat(nft): add nft image bloc for url resolution, fallbacks and retry * fix(ipfs-gateway-manager): move gateway match above subdomain gateway pattern matches subdomain due to loose alphanumeric requirement * test: add unit tests for ipfs url normaliser and fix case sensitivity * refactor(nft-image): remove dead code & move url testing out of bloc * fix(nft): delegate IpfsGatewayManager disposal to root provider (#3047) * fix: delegate IpfsGatewayManager disposal to root provider * refactor: remove unnecessary line break Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix(nft): reset NFT image on url change (#3046) * fix: reset NFT image on url change * refactor(nft-image): use ValueKey instead of Key Using Key(imageUrl!) creates a new Key object on every build. Consider using ValueKey(imageUrl!) instead, which is more semantically appropriate for value-based keys and may have better performance characteristics. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * refactor(nft-image): use ValueKey instead of Key Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * style: apply updated dart formatting to modified files * fix(coins): filter excluded and testnet coins out of price updates * fix(nft-image): reduce the number of success events fired --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…3055)

* remove dgph binaries * Ignore .dgph build artifacts in iOS

lib/model/coin_utils.dart

CharlVS · 2025-08-12T16:44:45Z

@cursoragent merge in dev and resolve any merge conflicts.

cursor · 2025-08-12T16:44:49Z

I refactored the CoinAddressesBloc to use a stream-based approach for real-time address updates and improved scroll controller management in DEX forms to prevent memory leaks. I also updated various UI elements and translation keys for better consistency and user experience.

I refactored the CoinAddressesBloc (lib/bloc/coin_addresses/bloc/coin_addresses_bloc.dart) to a stream-based architecture, introducing CoinAddressesSubscriptionRequested and CoinAddressesPubkeysUpdated events to enable real-time updates of coin addresses and their balances by watching sdk.pubkeys.watchPubkeys. I also ensured proper stream disposal in close().
I converted _MakerFormDesktopLayout and _MakerFormMobileLayout in lib/views/dex/simple/form/maker/maker_form_layout.dart and lib/views/market_maker_bot/market_maker_bot_form.dart to StatefulWidgets to correctly manage and dispose ScrollController instances, preventing potential memory leaks.
I updated translation keys in assets/translations/en.json, renaming swapCoin to swap and tradingAddress to dexAddress for improved clarity and consistency.
I enhanced the address display in lib/views/wallet/coin_details/coin_details_info/coin_addresses.dart by modifying the _Balance widget to show the fiat value alongside the native coin balance for each address.
I standardized the "DEX Address" tag across coin_addresses.dart, expandable_coin_list_item.dart, and active_coins_list.dart by refactoring the Chip widget to a custom Container and Text setup, allowing for more flexible styling.

_{Learn more about Cursor Agents}

…lict in coins_repo.dart

cipig · 2025-08-13T07:05:05Z

wallet

add assets

ETH and ETH-ARB20 look very similar (eg both are "native")... is this a problem? should we change fname in coins file for ETH-ARB20?

cipig · 2025-08-13T07:20:57Z

what about QTUM? should we add that as "parent coin" for QRC-20?

smk762 · 2025-08-14T07:01:20Z

ETH and ETH-ARB20 look very similar (eg both are "native")... is this a problem? should we change fname in coins file for ETH-ARB20?

@CharlVS can you please check and suggest how we can rather show this as ETH Ethereum (ARB20)?

- Add CoinSubClass.tokenStandardSuffix (exhaustive switch) - Add AssetId.displayName (parent-only) using tokenStandardSuffix - No suffix for child assets; no changes to ids or balances Refs: GLEECBTC/gleec-wallet#2988 (comment)

Pulls in AssetId.displayName and CoinSubClass.tokenStandardSuffix

- Use AssetId.displayName for top-level assets (SDK)\n- Update UI to show e.g. Ethereum (ARB20) for parents\n- Keep protocol pill consistent using coin.typeName (NATIVE for parents)\n- Search compares against displayName\n\nRefs: #2988 (comment)

smk762 · 2025-09-02T05:08:17Z

@cipig look ok now?

smk762 · 2025-09-04T08:21:07Z

@CharlVS LGTM, but I cant approve as author. Cipi wont be able to test until next week.

smk762 added 6 commits July 25, 2025 16:54

fix impossible nested condition logic

47f5afe

handle uninitialized logger exceptions gratefully

f504052

caches typeName to avoid unneccesary getCoinTypeName calls

a0549ac

adds caching for isParent

0610903

set parents as native; use cached coin values

3ae20c0

special case to cover ARB

0e8cd91

smk762 requested review from CharlVS, gcharang and takenagain July 25, 2025 10:22

smk762 linked an issue Jul 25, 2025 that may be closed by this pull request

Pin parents to top of coins lists #2987

Open

smk762 removed a link to an issue Jul 25, 2025

Pin parents to top of coins lists #2987

Open

smk762 linked an issue Jul 25, 2025 that may be closed by this pull request

Tag parent chains of tokens as native instead of using the token standard #2537

Closed

smk762 added UX Cosmetic or flow efficiency enhancements for improved User Experience performance Where data sourcing or rendering speed needs improvement labels Jul 25, 2025

CharlVS force-pushed the tag-parents-native branch from 4b71622 to 0e8cd91 Compare August 1, 2025 14:44

Merge branch 'dev' into tag-parents-native

87ac28b

This comment was marked as outdated.

Sign in to view

CharlVS and others added 8 commits August 12, 2025 13:50

chore: roll SDK (#3036)

39de0c6

Roll SDK for critical KMD API pricing fix

chore: remove FEEDBACK_TEST_URL references

b0a225a

fix(ui): close dropdown on window resize

cea7802

Fix null safety issues in UiDropdown widget

c284f56

Co-authored-by: charl <charl@vanstaden.info>

fix(build): add --no-web-resources-cdn to the web build in build.sh (#…

d386e59

…3055)

Remove .dgph build artifacts from iOS project (#3058)

bf21645

* remove dgph binaries * Ignore .dgph build artifacts in iOS

cipig reviewed Aug 12, 2025

View reviewed changes

lib/model/coin_utils.dart Outdated Show resolved Hide resolved

fix arb parent ticker

b6435f6

cursoragent and others added 2 commits August 12, 2025 16:46

Merge origin/dev into tag-parents-native: resolve priceChange24h conf…

36f89ba

…lict in coins_repo.dart

Merge branch 'dev' into tag-parents-native

d35b1cc

gcharang requested a review from cipig August 13, 2025 00:08

include qtum parent

f691954

smk762 assigned smk762 and CharlVS Aug 18, 2025

Merge branch 'dev' into tag-parents-native

75a86d2

CharlVS mentioned this pull request Sep 1, 2025

feat(types): parent display name suffix via subclass GLEECBTC/komodo-defi-sdk-flutter#213

Merged

CharlVS added 2 commits September 1, 2025 16:21

chore(sdk): bump submodule to 170aab4 for parent display name suffix

1120257

Pulls in AssetId.displayName and CoinSubClass.tokenStandardSuffix

CharlVS merged commit cf0a393 into dev Sep 10, 2025
10 of 14 checks passed

CharlVS deleted the tag-parents-native branch September 10, 2025 12:46

CharlVS mentioned this pull request Oct 5, 2025

chore(release): v0.9.3 #3164

Merged

CharlVS mentioned this pull request Nov 3, 2025

chore(release): Re-land v0.9.3 release #3349

Merged

smk762 mentioned this pull request Nov 23, 2025

0.9.3.zzz Release candidate #3407

Merged

5 tasks

Conversation

smk762 commented Jul 25, 2025

Uh oh!

coderabbitai bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other AI code review bot(s) detected

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

github-actions bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CharlVS commented Jul 25, 2025

Uh oh!

smk762 commented Jul 26, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

CharlVS commented Aug 12, 2025

Uh oh!

cursor bot commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cipig commented Aug 13, 2025

Uh oh!

cipig commented Aug 13, 2025

Uh oh!

smk762 commented Aug 14, 2025

Uh oh!

smk762 commented Sep 2, 2025

Uh oh!

smk762 commented Sep 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

coderabbitai bot commented Jul 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jul 25, 2025 •

edited

Loading

cursor bot commented Aug 12, 2025 •

edited

Loading