Skip to content

fix: reset NFT image on url change #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
takenagain merged 3 commits into from
Aug 4, 2025
Merged

fix: reset NFT image on url change #3046

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe2abd9
fix: reset NFT image on url change
takenagain Aug 4, 2025
68b352d
refactor(nft-image): use ValueKey instead of Key
takenagain Aug 4, 2025
8575e6c
refactor(nft-image): use ValueKey instead of Key
takenagain Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions lib/views/nfts/common/widgets/nft_image.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ class NftImage extends StatelessWidget {
switch (type) {
case NftImageType.image:
return _NftImageWithFallback(
key: ValueKey(imageUrl!),
imageUrl: imageUrl!,
);
case NftImageType.video:
Expand All @@ -36,6 +37,7 @@ class NftImage extends StatelessWidget {
return PlatformTuner.isNativeDesktop
? const _NftPlaceholder()
: _NftVideoWithFallback(
key: ValueKey(imageUrl!),
videoUrl: imageUrl!,
);
case NftImageType.placeholder:
Expand Down Expand Up @@ -84,6 +86,16 @@ class _NftImageWithFallbackState extends State<_NftImageWithFallback> {
});
}

@override
void didUpdateWidget(covariant _NftImageWithFallback oldWidget) {
super.didUpdateWidget(oldWidget);
if (oldWidget.imageUrl != widget.imageUrl) {
final bloc = context.read<NftImageBloc>();
bloc.add(const NftImageResetRequested());
bloc.add(NftImageLoadRequested(imageUrl: widget.imageUrl));
}
}

@override
Widget build(BuildContext context) {
return BlocBuilder<NftImageBloc, NftImageState>(
Expand Down Expand Up @@ -201,6 +213,19 @@ class _NftVideoWithFallbackState extends State<_NftVideoWithFallback> {
});
}

@override
void didUpdateWidget(covariant _NftVideoWithFallback oldWidget) {
super.didUpdateWidget(oldWidget);
if (oldWidget.videoUrl != widget.videoUrl) {
_controller?.dispose();
_controller = null;
currentVideoUrl = null;
final bloc = context.read<NftImageBloc>();
bloc.add(const NftImageResetRequested());
bloc.add(NftImageLoadRequested(imageUrl: widget.videoUrl));
}
}

@override
Widget build(BuildContext context) {
return BlocConsumer<NftImageBloc, NftImageState>(
Expand Down
Loading