Firefox 54 drag area flickers .qq-upload-drop-area-active

[SpazzMarticus]

Type of issue

• Bug report
• Feature request
• Support request

Uploader type

• Traditional
• S3
• Azure

Bug Report

Fine Uploader version

5.11.7 on https://fineuploader.com/demos.html
5.14.4 on custom page.

Browsers where the bug is reproducible

Firefox 54

Operating systems where the bug is reproducible

Windows 8.1

Exact steps required to reproduce the issue

Drag file over drop area.

All relevant Fine Uploader-related code that you have written

none

Your Fine Uploader template markup (if using Fine Uploader UI and the issue is UI-related)

default

Detailed explanation of the problem

Dragging file over drop area adds and removes .qq-upload-drop-area-active continously.

[cntrytwist]

I can confirm the same behavior when using Mac OS and Firefox 54.

[SpazzMarticus]

The problem is caused by leavingDocumentOut. Once you remove this part

if (qq.firefox()) {
    return !e.relatedTarget;
}

it works in Firefox 54 as expected, but I guess in older Firefox versions there will be problems.

[cubiclesoft]

Ditto. The flickering issue shows up in the demos in Firefox:

https://fineuploader.com/demos.html

[maximilianschmid]

+1 flickering Firefox 55.0.3 (64-Bit) on MacOS 10.11.6

[AyrtonRicardo]

+1 flickering Firefox 54.0 (64-bit) Linux

[simshaun]

Happens in Win/Firefox 56 as well.

[slava-uxd]

Very disturbing for all Firefox users. Still occurs in FF 56, FineUploader 5.15.0.

Removing 3 lines as suggested by SpassMarticus works for full js. It's more complicated removing this safely from a minified version.

Please fix.

[rnicholus]

Based on the referenced PR, that fix does not reliably work. I'm personally not seeing the issue myself, but if someone contributes a PR that fixes the issue and does not cause new issues, I'll make it a priority to merge it in.

[slava-uxd]

@rnicholus "... but if someone contributes a PR that fixes the issue ..."?

How long are you going to wait? It's a major issue that blocks FF users from using Drag&Drop completely.

Multiple people are reporting this and I've just tested from a fresh VM Windows7x64 with Firefox Nightly v58. The whole drop area flickers in a loop even without mouse movement and it does nothing on drop.

[rnicholus]

If it's a major issue that blocks you, then please contribute a PR and we'll go from there. And I disagree that it's a major issue that blocks FF users from using DnD completely as I said I personally am not having this issue w/ my integrations.

[cubiclesoft]

I ended up rolling my own solution using a different library: https://github.com/cubiclesoft/jquery-fancyfileuploader

The flickering issue, which I can confirm is still happening in the demo (I'm running Windows 10 Pro 64-bit + Portable Firefox 56 32-bit + a couple of popular add-ons), along with the author's intentions to no longer support Fine Uploader caused me to move away from Fine Uploader for my integrations. jQuery isn't a terrible dependency (usually) and I happen to like my solution better since there's very little that can go wrong and it works quite well on mobile devices.

[rnicholus]

It’s really quite shocking to see how many users of my hard work feel they are owed something even further in particular, as if they were somehow sending me a paycheck every two weeks. It’s quite simple: if this is important to you and you have a fix that does not break something else: issue a pull request. Or you could volunteer to help maintain the library. Or you could even volunteer to help pay AWS bills. OR, you can fork the project, fix the issue to your satisfaction, and simply use that in your project. So many options! And make no mistake about it, the library is not abandoned. In fact I have a public branch/PR in progress with many substantial additions to the library in progress that is now feature complete with docs, tests, and even updated Typescript defs. See #1917 for details.

And again, if there are other important issues to you, the proper way to deal with them in the context of Free Open Source Software is to issue a well explained/documented/tested PR and remind the overloaded maintainer periodically, or offer to help the maintainer push the case through.

[rnicholus]

So far, I see lots of people complaining about this issue, and one user even going as far as using this issue to advertise his/her own library (which is in amazingly poor taste BTW) but not a single valid PR that fixes the issue. This is not my focus at the moment (see above) but will gladly coordinate with a developer that proposes a well tested PR for the issue.

[rnicholus]

And why, might you ask, do I require someone actually open a PR to fix this? Because I want someone other than myself to own the issue, since it is not an important issue for me. Having the proper perspective on FOSS makes these types of requests unnecessary though.

[rnicholus]

fixed in #1946