This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Add serverside encryption headers as request params #1933
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the changes
This allows us to specify custom encryption keys via
aws:kms
. It solves the problem that #1803 is trying to solve. With this, you can just do the following to get KMS keys workingWhat browsers and operating systems have you tested these changes on?
Chrome. But this is unlikely to break any behaviour that is already not broken by custom params.
Have you written unit tests? If not, explain why.
The current custom params implementation does not contain unit tests.