Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Add serverside encryption headers as request params #1933

Merged
merged 3 commits into from
Nov 6, 2017
Merged

Add serverside encryption headers as request params #1933

merged 3 commits into from
Nov 6, 2017

Conversation

nadeesha
Copy link
Contributor

Brief description of the changes

This allows us to specify custom encryption keys via aws:kms. It solves the problem that #1803 is trying to solve. With this, you can just do the following to get KMS keys working

      request: {
        endpoint: "...",
        accessKey: "...",
        params: {
          "x-amz-server-side-encryption": "aws:kms",
          "x-amz-server-side-encryption-aws-kms-key-id": "JE9Yya8Rd6jcbZbb8ymFoU6prbpyyZDc"
        }
      },

What browsers and operating systems have you tested these changes on?

Chrome. But this is unlikely to break any behaviour that is already not broken by custom params.

Have you written unit tests? If not, explain why.

The current custom params implementation does not contain unit tests.

@rnicholus
Copy link
Member

This seems simple enough. I’ll try to merge it in soon.

@rnicholus rnicholus merged commit 86791ae into FineUploader:develop Nov 6, 2017
@rnicholus rnicholus added this to the 5.15.1 milestone Nov 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants