-
Notifications
You must be signed in to change notification settings - Fork 1.9k
docs(features): Add S3 Transfer Acceleration to S3 feature #1627
Conversation
headers to the request that is sent on to S3. An example of a CDN that should work fine is [fastly][fastly]. | ||
Ironically, an example of a CDN that does not appear to work is Amazon Cloudfront (see [issue #1016 in the | ||
Fine Uploader GitHub issue tracker][issue1016]). If you'd like to use Amazon Cloudfront as a CDN for your | ||
uploads, please use the [S3 Transfer Acceleration option][s3transferacceleration] instead. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Thanks for the PR. I'll take a closer look when I get a chance and will provide feedback and suggestions to allow this to be merged. |
I think the best approach here is to completely remove the existing CloudFront-related documentation, and include a new sub-section under the main/existing "Uploading to S3 Through a CDN" section that talks about S3 Transfer Acceleration. Once #1016 has been verified, then we can add CF docs as part of closing that case. |
I was using the latest version of FineUploader. About #1016, I really think that this AWS accelerate feature remove the needs to do fancy thing with CloudFront "PUT". (On a side note, #1016 is actually working when configured without OAI). But really, except if you upload more than 350 TB per month, I don't see a reason to not use accelerate instead of CloudFront. |
Thanks for your input @ludofleury. Perhaps the best course of action here is to:
|
Yes, I totally agree on this, #1016 becomes obsolete (as the feature implemented). |
I've updated with the suggestions above, will squash after everything checks out. |
Looks pretty good to me. No need to worry about squashing. I can squash at merge time. |
Brief description of the changes
Adds documentation changes to indicate support for S3 Transfer Acceleration (see #1556).
What browsers and operating systems have you tested these changes on?
N/A; docs change.
Are all automated tests passing?
N/A; docs change.
Is this pull request against develop or some other non-master branch?
No; docs change.
Fixes #1556. May also handle #1016 (just use the Transfer Accelerate option for now), although maybe in the last year Cloudfront has fixed their issues.
See additional comments based on changes.
We've been having success with this option on version 5.3, so I'd assume, based on the changes, that it should work for any version from at least 5.1 onwards. Maybe @DaveDeCaprio, @e-tip, or @ludofleury could chime in with which versions they've been using?