This is a test, sorry if annoyance #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e still waiting for signature This should prevent a chunk upload that has not yet called xhr.send() from starting if it has been cancelled by error handling code. #1519
Removed temporary logs. fixes #1519
[skip ci]
Introduces a new API method - addInitialFiles. closes #1191
closes #1191 [skip ci]
This also account for extraButtons. closes #1526
[skip ci] #1526
…tion docs(delete file): clearer docs for proper callback use
Also adjusted an unreliable test. This was tested in Edge 13.10586. #1422
Xhr object now passed through error handlers #1559
When adding new rows to a table, the existing mechanism of storing the HTML of a row in variable breaks at least on firefox: When parsing this HTML fragment and creating DOM elements, the browser will ignore tags it does not expect without proper parent tags. Appending this modified DOM branch to the table results in broken DOM structure. Cloning the DOM branch of a row and appending this clone to the table works just fine. fixes #1246
Since we only deal with files, it makes sense to ignore all events non-file related (eg. dragging plaintext). This commit fixes a few things that have changed in the browsers which subtly break the current checks. * The `contains` function on `dt.files` has been removed from the spec and will always return undefined. Except for IE, which hasn't implemented the change. * Chrome and Firefox have replaced it with `includes`, which we now use * We've left a `contains` check in there for IE as a last resort * Remove the comment about it being Firefox only, since it also works in Chrome now * More info re: removal at: https://github.com/tc39/Array.prototype.includes#status * The dt.files property always seems to be an empty array for non-drop events. Empty arrays are truthy, and so this will always satisfy the `isValidFileDrag` check before it can validate that the types array includes files * It will now only be truthy if the files array actually contains entries * There is a drop handler which binds to the document and always prevents all default drop behaviour from occurring, including things like dropping text into textfields * It will now only prevent default behaviour for file drops, which has the handy side-effect of preventing the page from navigating to the dropped file if the user misses the dropzone. Fixes #1588
Removes Firefox check in leavingDocumentOut. fixes #1862
Minor edit to get the docs to match the code on the SAS request params.
[skip ci]
* Local dev/testing ports 3000/3001 clash with my local env, and possibly others - moving to 4000/4001.
* returned onUploadChunk promise can override method, params, headers, & url
* promissory onUpload callback
* always ensure test server are killed either on test start or stop
* don't try to kill test server on CI before tests start
* option to allow upload responses without { "success": true }
* allow default params to be omitted from upload requests
* don't fail upload w/ non-JSON response when requireSuccessJson = false
* more flexible chunking.success request support
* add .editorconfig (can't believe this didn't exist until now)
* Allow custom resume keys and data to be specified.
* include customResumeData in return value of getResumableFilesData API method
* add isResumable public API method
* introduce chunking.success.resetOnStatus to allow FU to reset a file based on chunking.success response code
* new API method: isResumable(id)
* Allow onUpload resolved Promise to pause the file.
Use case: When onUpload is called, you make a request to your server to see if the file already exists. If it does, you want to let your user decide if they want to overwrite the file, or cancel the upload entirely. While waiting for user input you don't want to hold a spot in the upload queue. If the user decided to overwrite the file, call the `continueUpload` API method.
* Allow per-file chunk sizes to be specified.
chunking.partSize now accepts a function, which passes the file ID and size
* feat(beforeUnload): new option to turn off beforeUnload alert during uploads
* feat(features.js): auto-detect folder support
* Allow access to Blob when file status is still SUBMITTING
* docs: options, API, and events doc updates
* added qq.status.UPLOAD_FINALIZING - don't cancel or pause in this state
closes #848
closes #1697
closes #1755
closes #1325
closes #1647
closes #1703
* docs: fix Amazon S3 v4 signature guide * docs: s3 v4 signature
This removes the "Uncaught TypeError: target.onload is not a function" console error while img preview
* feat(dnd.js): add dragEnter and dragLeave callbacks * add dragEnter/dragLeave doc
Fixed in docfu 1.0.4, which locks us to python-markdown 2.6.11 (the last version to include smart_strong). https://github.com/FineUploader/docfu/releases/tag/1.0.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My comment