Conversation
Closed
f47e3b6 to
dea5f59
Compare
8b3e0a1 to
7ce1b8b
Compare
c876a67 to
e94e179
Compare
9e48720 to
e6e525c
Compare
test_customreports.py creates issues.json in the working directory. This commit makes it so any files are created in temporary directories and deleted after the tests are done.
de15402 to
37b4a8f
Compare
Contributor
Coverage Report •
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
italvi
requested changes
Aug 8, 2024
italvi
approved these changes
Aug 8, 2024
This was referenced Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR primarily adds integration testing to test the tool's functionality from a "outside" perspective.
These tests invoke the main function directly so they are about as abstract as can be.
The goal is to ensure that the kind of internal redesign as is planned for #7 will not create any regressions. Existing unit tests are not fit for this because they are so tightly coupled to the design that they, too, will have to be reworked, creating the risk of regressions inside the tests.
Tests for the following commands are implemented:
Not to be implemented:
merge-vex? #156)A few minor additional changes
test_customreports.pybecause I couldn't be bothered to create a separate PR for this. See commit message on 05906d1 for details. If you insist, we can still separate this out.--version-rangeCLI option to the set command not work.