Skip to content

feat: add support for cdx 1.6#219

Merged
italvi merged 11 commits intomainfrom
162-feat-add-support-for-cdx-16
Aug 26, 2024
Merged

feat: add support for cdx 1.6#219
italvi merged 11 commits intomainfrom
162-feat-add-support-for-cdx-16

Conversation

@CBeck-96
Copy link
Copy Markdown
Collaborator

@CBeck-96 CBeck-96 commented Jul 4, 2024

Adds the offical 1.6 schema as well as a custom version to the tool.

I removed the entire "licensechoice" section in the custom schema, like in 1.5, since the new implementation leads to misleading error messages.

@CBeck-96 CBeck-96 linked an issue Jul 4, 2024 that may be closed by this pull request
@github-actions github-actions bot added enhancement New feature or request unittests labels Jul 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 4, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL16887195% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
351 2 💤 0 ❌ 0 🔥 10.891s ⏱️

@italvi
Copy link
Copy Markdown
Collaborator

italvi commented Aug 6, 2024

Please also add the updated SPDX list

@italvi italvi changed the title 162 feat add support for cdx 16 feat: add support for cdx 1.6 Aug 8, 2024
Copy link
Copy Markdown
Collaborator

@italvi italvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CBeck-96 please take a look at #157. We decided to remove the not required files, e.g. the xml-schemata. And also add integration-tests for 1.6 as done there for 1.2 to 1.5

@mmarseu
Copy link
Copy Markdown
Collaborator

mmarseu commented Aug 9, 2024

@CBeck-96 please take a look at #157. We decided to remove the not required files, e.g. the xml-schemata. And also add integration-tests for 1.6 as done there for 1.2 to 1.5

Since these required changes were on my head, I went ahead and implemented them. Integration tests are done and the non-JSON-schema files are gone.

Copy link
Copy Markdown
Collaborator

@italvi italvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CBeck-96 Please answer my question regarding the specific class for tests of 1.5 and rebase.

Comment thread tests/test_validate.py Outdated
Copy link
Copy Markdown
Collaborator

@italvi italvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it with some SBOM examples from cdx and seems to work, so lgtm.

@italvi italvi merged commit 59bff0a into main Aug 26, 2024
@italvi italvi deleted the 162-feat-add-support-for-cdx-16 branch August 26, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add support for cdx 1.6

3 participants