Merged
Conversation
Contributor
This was referenced Jul 4, 2024
Collaborator
|
Please also add the updated SPDX list |
Collaborator
Since these required changes were on my head, I went ahead and implemented them. Integration tests are done and the non-JSON-schema files are gone. |
italvi
approved these changes
Aug 26, 2024
Collaborator
italvi
left a comment
There was a problem hiding this comment.
tested it with some SBOM examples from cdx and seems to work, so lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the offical 1.6 schema as well as a custom version to the tool.
I removed the entire "licensechoice" section in the custom schema, like in 1.5, since the new implementation leads to misleading error messages.