Skip to content

fix: set --version cannot be combined with --version-range#218

Merged
italvi merged 2 commits intomainfrom
exclusive-set-version-options
Aug 26, 2024
Merged

fix: set --version cannot be combined with --version-range#218
italvi merged 2 commits intomainfrom
exclusive-set-version-options

Conversation

@mmarseu
Copy link
Copy Markdown
Collaborator

@mmarseu mmarseu commented Jul 4, 2024

This PR makes the --version and --version-range options to the set command mutually exclusive.

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request settings_changes unittests labels Jul 4, 2024
@mmarseu mmarseu force-pushed the exclusive-set-version-options branch 2 times, most recently from e5f8bfc to 9d37bab Compare July 10, 2024 09:27
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jul 10, 2024
@mmarseu mmarseu force-pushed the exclusive-set-version-options branch from 9d37bab to 17488cc Compare August 8, 2024 13:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 8, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
__main__.py3241695%217–218, 235, 245, 672, 715, 760, 765, 769, 791, 805, 809, 813, 815, 824, 834
TOTAL16897195% 

Tests Skipped Failures Errors Time
352 2 💤 0 ❌ 0 🔥 11.361s ⏱️

@mmarseu mmarseu force-pushed the exclusive-set-version-options branch from a6089e2 to a2bf5f6 Compare August 9, 2024 08:10
@mmarseu mmarseu marked this pull request as ready for review August 9, 2024 08:12
@mmarseu mmarseu requested a review from italvi August 9, 2024 08:13
@italvi
Copy link
Copy Markdown
Collaborator

italvi commented Aug 26, 2024

@CBeck-96 as you were the one introducing the version-ranges feature, can you please check if everything still works as you would expect? The functionality itself should be hopefully completely covered by the (integration) test.

Copy link
Copy Markdown
Collaborator

@CBeck-96 CBeck-96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked at the code, but the changes reflect the intended purpose and should not lead to unexpected behaviour.

@italvi italvi merged commit c34625b into main Aug 26, 2024
@italvi italvi deleted the exclusive-set-version-options branch August 26, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants