chore: add minimum threshold of 95% for coverage#222
Merged
Conversation
Contributor
Coverage Report •
|
italvi
changed the title
CBeck-96
approved these changes
Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we observed a decline in test coverage, I added the flag
--fail-under, so that we keep at least a coverage of 95%. Please note that even though the coverage comment shows 94%, we still have a coverage of 95%, seems like a rounding issue. You can see that the step is successful in https://github.com/Festo-se/cyclonedx-editor-validator/actions/runs/10297281414/job/28500202625Edit: After the merge of #216 the coverage really dropped to 94%, hence the failure now 😞Merge of #157 raised the coverage over 95%