Deploy Checklist: New Expensify 2024-11-26

[github-actions]

Release Version: 9.0.67-9
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Hide approve/pay buttons if the report contains violations #51133
• Fix hidden shows briefly when mentioning unknown user #51459
• Update transaction violations when the money request is paid #51770
• Fix go back/forward gesture doesn't work #52355
• feat: edge-to-edge mode on Android #52392
• Fix tooltip for QAB doesn't show for new user #52446
• fix navigation to room description #52485
• Feat: require magic code validation for add missing detail #52521
• migrate sidebarLinkData to useOnyx #52550
• Update childStateNum and childStatusNum for parent report action #52687
• fix: Tags - State field is not auto selected #52691
• [No QA] Fix/52558 fix card name and images #52735
• Fix no close animation of 2fa validate screen #52741
• [NoQA] Add tests for switch to Expensify classic flow #52754
• Fix - Getting RBR for a workspace connection sync on a workspace I’m not an admin of #52778
• Fix going back from report detail doesn't bring to confirm page #52809
• fix: Taxes - BNP input is not auto focused in add rate page. #52810
• Update new workspace button type and add go to workspace menu item #52847
• fix: navigate to switcher when clicking back button after creating a workspace from switcher #52863
• [NoQA] Add unit testing guide and example tests #52867
• [NO QA] Stop releasing standalone builds to prod #52916
• Update copy on the wallet settings page #52942
• Bump react-native-live-markdown to 0.1.187 #52960
• remove isHidden property from report #52963
• Update Create-an-expense.md to add How to delete expense and update Change-or-add-email-address.md #52968
• Display 'Make default payment method' option for the first bank account without requiring a refresh after adding the second account #52971
• Fix: Selected Xero bank account is not highlighted with a green checkmark  #52974
• Revert "fix: Submit button hang in middle page" #52976
• Fix - Android - Profile - Zip code field is auto populated with invalid format when adding address #52987
• Fix - Search - Expenses change position briefly when switching from Settings to Search #52989
• Fix empty selected row in search "In" filter #52993
• Fix RBR is not shown correctly #52994
• Rename Money Request/Split/Pay step header names #53004
• Skip adding DomUtils.getAutofilledInputStyle for static ThemeProvider #53057
• fix: tag is not auto filled #53059
• [CP Staging] Fix - A Follow up on [CRITICAL] Multiple workspaces get created when someone either refreshes the page, or drops off and returns later. #53093
• [NoQA] Remove getSystemChat() function #53103
• Make the whole search LHN menu scrollable #53106
• [NoQA] Add reasons why to skip tests #53127
• [CP Staging] Make sure to check the navBarManager is defined #53165
• [CP Staging]: Avoid hiding pay/approve buttons in case of held violations #53176
• [CP Staging] fix: remove additional keyboard padding in tax screen #53209
• [CP Staging] Fix suggestion list display with wrong position in Android #53211
• [CP Staging] Fix Hybrid Android crash and bring the custom edge-to-edge module to hybridApp #53216
• [CP Staging] Fix: Android edge-to-edge related inset/padding issues #53223
• [CP Staging] fix: do not call submit function twice if user clicks fast #53227
• [CP Staging] Revert not showing approve and pay buttons if report has violations #53230

Internal QA:

• [Workspace Feeds]: Update isLoading both for expensify and company cards #52949 - @mountiny
• Cleanup errors for Google Tag Manager #52934 - @carlosmiceli
• [Internal QA]: Fix default card with export type #52575 - @mountiny

Deploy Blockers:

• [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Android - App crashes when launching app  #53150
• [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] iOS - Expense - Tapping Save button (from Merchant page) for the second time returns to BNP #53152
• [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] [$500] Web - Expense - Submit button on confirmation page has extra bottom margin #53161
• [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Submit expense - Next Steps shows "Waiting for You to pay" when payment is blocked by violations #53163
• [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Held expense - Pay button disappears after holding one of the expenses #53166
• [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] [$250] Android - Chat - Suggestion list appears above the composer with spacing #53180
• [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Android - Taxes - Save button appears above the keyboard with huge spacing in Name page #53181
• [HOLD for payment 2025-01-07] [$250] Android - Expense - Submit button jumps when proceeding to confirmation page #53182
• [$250] [HOLD for payment 2024-12-11] Android - Expense - Save button moves up and down when keyboard is open #53183
• Hybrid Android - App shows splash screen every time launching after backgrounding app #53184
• [PAID] Hybrid - Android - Group - Compose box is displayed floating when creating group chat #53185
• Android - Acct/ WS settings - Device buttons navigation bar missing borders #53186
• Hybrid - Android - Room - Keyboard is not opened when creating a new room #53188
• [HOLD for payment 2024-12-11] Android - Start chat - Huge spacing between bottom button and offline indicator #53189
• [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Android - Group - Start group button on confirmation page has extra bottom margin #53190
• [HOLD for payment 2024-12-11] Android - Search - Saved search items overlap with navigation bar #53192
• [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Hybrid - Launch - App crashes when closing and reopening app #53204
• [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Android - LHN - Extra space at the bottom of LHN #53205
• [HOLD for payment 2024-12-11] [HOLD App#53192] Search - Overlapping content in Dates and spacing below Save button in Keywords #53207
• [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Android - Video - Video controls are too close to the device navigation buttons #53215
• [HOLD for payment 2024-12-11] [HOLD App#53192] Expensify Card - Navigation bar overlaps the Next button in Choose a limit type step #53217
• [HOLD for payment 2024-12-11] [HOLD App#53229] Accounting - Next button doesn't have bottom margin on intacct setup first page #53221

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[carlosmiceli]

Passed internal QA: #52934

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.67-0 🚀

[joekaufmanexpensify]

Checked off #52949

[joekaufmanexpensify]

checked off #52575

[mountiny]

demoted #53163 its repro in prod

[mvtglobally]

Regression is at 60 % completed

Blockers:
#53152
#53161
#53166

[mvtglobally]

Regression is at 80 % completed

Blockers:
#53152
#53161
#53166

[lakchote]

Demoted #53186 for this reason.

[izarutskaya]

Regression is 9% left:

PRs:
#52521 - Pending validation on Android
#52960 - KI found #53197
#52971 - Pending validation on Android
#52974 - Pending validation on Android
#52994 - Pending validation on Android
#53004 - Pending validation on Android, iOS

Blockers:
#53152
#53161
#53166
#53180
#53181
#53182
#53183
#53185
#53188
#53189
#53190
#53192

[mountiny]

Demoted #53188

[mountiny]

demoted #53192

[mountiny]

demoted #53207

[mountiny]

demoted #53183 as its minor and proper fix will require larger changes

[mvtglobally]

Regression is almost completed. We are checking Cps

PR #53004 - Ki reproduced #52897. Checking off

[mvtglobally]

Regression is completed. Checking newest CPs

[mountiny]

Tested all the blockers in the browser stack and they are resolved 🎉

[mountiny]

tested this one here with Tomislav @trjExpensify https://expensify.slack.com/archives/C07J32337/p1732797150312429

[mountiny]