-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android - Search - Saved search items overlap with navigation bar #53192
Comments
Triggered auto assignment to @trjExpensify ( |
Triggered auto assignment to @techievivek ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
It happened because of this PR: #52392 |
@kirillzyusko Are you working on the fix for this? Should we demote it? |
I can take over, I think we should look into fixing this now as its bad UI/UX, but I would only demote if deploy is getting longer |
Sounds good, thanks. |
The iOS also has the same behavior: What I agree that it doesn't look good, but iOS has been working in such way for a long time 🤔 I think at least we should ask UX/UI team opinion (whether we need to apply a bottom padding) and I think we should remove deploy blocker label (because it's not an issue - Android just started to be more similar to iOS). @mountiny what do you think? |
I agree its not a blocker as you can click the android buttons, but I would say its not same to compare ios with just a bar on which you always just swipe up to buttons like you can see in the android recording that you have to tap and you can mistap and click on the item behind it So I am demoting, but lets add a safe area to the android devices that have the buttons in the bottom. I dont feel like this is a problem on ios as you just have the bar on swich you swipe up. But I think we should check what are the ios guidelines on the safe area and follow those |
@kirillzyusko I put other two issues on hold for this that have same root cause so lets handle it here |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.67-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Expected Result:
Saved search items will not overlap with device navigation bar.
Actual Result:
Saved search items overlaps with device navigation bar.
This issue is not reproducible if device navigation uses swipe gestures.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6677728_1732692121109.Screen_Recording_20241127_151421.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: