Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Search - Saved search items overlap with navigation bar #53192

Open
2 of 8 tasks
IuliiaHerets opened this issue Nov 27, 2024 · 11 comments
Open
2 of 8 tasks

Android - Search - Saved search items overlap with navigation bar #53192

IuliiaHerets opened this issue Nov 27, 2024 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.67-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Device navigation is buttons instead of swipe gestures.
  • Account has many saved searches.
  1. Launch ND or hybrid app.
  2. Go to Search.
  3. Tap on the dropdown.
  4. Scroll down.

Expected Result:

Saved search items will not overlap with device navigation bar.

Actual Result:

Saved search items overlaps with device navigation bar.

This issue is not reproducible if device navigation uses swipe gestures.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6677728_1732692121109.Screen_Recording_20241127_151421.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 27, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 27, 2024

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 27, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kirillzyusko
Copy link
Contributor

It happened because of this PR: #52392

@techievivek
Copy link
Contributor

@kirillzyusko Are you working on the fix for this? Should we demote it?

@mountiny
Copy link
Contributor

I can take over, I think we should look into fixing this now as its bad UI/UX, but I would only demote if deploy is getting longer

@mountiny mountiny assigned kirillzyusko and mountiny and unassigned techievivek Nov 27, 2024
@techievivek
Copy link
Contributor

Sounds good, thanks.

@kirillzyusko
Copy link
Contributor

The iOS also has the same behavior:

What edge-to-edge PR did -> it unified both platforms (now iOS and Android should work in the same way).

I agree that it doesn't look good, but iOS has been working in such way for a long time 🤔 I think at least we should ask UX/UI team opinion (whether we need to apply a bottom padding) and I think we should remove deploy blocker label (because it's not an issue - Android just started to be more similar to iOS).

@mountiny what do you think?

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 27, 2024
@mountiny
Copy link
Contributor

I agree its not a blocker as you can click the android buttons, but I would say its not same to compare ios with just a bar on which you always just swipe up to buttons like you can see in the android recording that you have to tap and you can mistap and click on the item behind it

So I am demoting, but lets add a safe area to the android devices that have the buttons in the bottom. I dont feel like this is a problem on ios as you just have the bar on swich you swipe up. But I think we should check what are the ios guidelines on the safe area and follow those

@mountiny
Copy link
Contributor

mountiny commented Nov 27, 2024

@kirillzyusko I put other two issues on hold for this that have same root cause so lets handle it here

@mountiny mountiny moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

5 participants