Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD App#53192] Android - Acct/ WS settings - Device buttons navigation bar missing borders #53186

Open
2 of 8 tasks
IuliiaHerets opened this issue Nov 27, 2024 · 13 comments
Open
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.67.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue reported by: Applause Internal Team

Action Performed:

  1. Open the app and log in
  2. Create a workspace if there is no any
  3. Navigate to the workspace settings
  4. Enable More features and enable Workflows, Rules and Invoices options
  5. Navigate to Profile, Invoices, Workflows. Rules and More features

Expected Result:

Device buttons navigation bar has borders and visible

Actual Result:

Device buttons navigation bar is missing borders and barely visible.
The same happens in account settings: Profile, Wallet, Security

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6677580_1732668150153.video_2024-11-26_19-41-09.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021861690553730814393
  • Upwork Job ID: 1861690553730814393
  • Last Price Increase: 2024-11-27
  • Automatic offers:
    • paultsimura | Reviewer | 105095159
Issue OwnerCurrent Issue Owner: @kirillzyusko
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 27, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 27, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 27, 2024

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 27, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lakchote
Copy link
Contributor

Not a blocker. It's a minor issue related to UI.

@lakchote lakchote added External Added to denote the issue can be worked on by a contributor Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 27, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021861690553730814393

@melvin-bot melvin-bot bot changed the title Android - Acct/ WS settings - Device buttons navigation bar missing borders [$250] Android - Acct/ WS settings - Device buttons navigation bar missing borders Nov 27, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

@mountiny
Copy link
Contributor

@kirillzyusko @chrispader this is same as the #53192 - maybe it can be fixed together

@mountiny mountiny self-assigned this Nov 27, 2024
@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 27, 2024
@mountiny mountiny changed the title [$250] Android - Acct/ WS settings - Device buttons navigation bar missing borders Android - Acct/ WS settings - Device buttons navigation bar missing borders Nov 27, 2024
@mountiny
Copy link
Contributor

@kirillzyusko can you please comment on this one too? it is a same root cause as these other too so lets just keep one main issue and then handle the safe area in one pr for all these issues
#53192
#53207

@mountiny mountiny changed the title Android - Acct/ WS settings - Device buttons navigation bar missing borders [HOLD App#53192] Android - Acct/ WS settings - Device buttons navigation bar missing borders Nov 27, 2024
@kirillzyusko
Copy link
Contributor

Commenting here for assignment 👋

@kirillzyusko
Copy link
Contributor

@mountiny but this is not deploy blocker anymore, right? So we should focus on high priority/deploy blocker first and then come back to this issue, right?

Copy link

melvin-bot bot commented Nov 27, 2024

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@lakchote
Copy link
Contributor

lakchote commented Nov 27, 2024

@mountiny but this is not deploy blocker anymore, right? So we should focus on high priority/deploy blocker first and then come back to this issue, right?

@kirillzyusko we should treat it as a blocker if the device buttons from the navigation bar are not clickable.

I'm currently having issues with my Android environment so I can't comment on that yet.

EDIT: well they are clickable so I'd confirm this is not a blocker

Screen.Recording.2024-11-27.at.16.05.09.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

6 participants