-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD App#53192] Android - Acct/ WS settings - Device buttons navigation bar missing borders #53186
Comments
Triggered auto assignment to @lakchote ( |
Triggered auto assignment to @johncschuster ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Not a blocker. It's a minor issue related to UI. |
Job added to Upwork: https://www.upwork.com/jobs/~021861690553730814393 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura ( |
@kirillzyusko @chrispader this is same as the #53192 - maybe it can be fixed together |
@kirillzyusko can you please comment on this one too? it is a same root cause as these other too so lets just keep one main issue and then handle the safe area in one pr for all these issues |
Commenting here for assignment 👋 |
@mountiny but this is not deploy blocker anymore, right? So we should focus on high priority/deploy blocker first and then come back to this issue, right? |
📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
@kirillzyusko we should treat it as a blocker if the device buttons from the navigation bar are not clickable. I'm currently having issues with my Android environment so I can't comment on that yet. EDIT: well they are clickable so I'd confirm this is not a blocker Screen.Recording.2024-11-27.at.16.05.09.mov |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.67.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
Device buttons navigation bar has borders and visible
Actual Result:
Device buttons navigation bar is missing borders and barely visible.
The same happens in account settings: Profile, Wallet, Security
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6677580_1732668150153.video_2024-11-26_19-41-09.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @kirillzyuskoThe text was updated successfully, but these errors were encountered: