Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Android - LHN - Extra space at the bottom of LHN #53205

Closed
2 of 8 tasks
IuliiaHerets opened this issue Nov 27, 2024 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.67-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Device navigation is buttons instead of swipe gestures.
  • Account has reports in LHN.
  1. Launch ND or hybrid app.
  2. Scroll to the bottom

Expected Result:

There will be no extra space at the bottom of LHN.

Actual Result:

There is extra space at the bottom of LHN.

This issue is not reproducible if device navigation uses swipe gestures.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6677798_1732697892277!Screenshot_20241127_165534_Samsung_Notes

Bug6677798_1732697892294.Screen_Recording_20241127_165443.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @adelekennedy
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 27, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 27, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 27, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Julesssss
Copy link
Contributor

Hey @kirillzyusko, here's another issue that only occurs when users have soft navigation buttons enabled.

Noting that this was introduced by the edge-to-edge changes. We expected to have some issues like this and we shouldn't revert the PR.

@kirillzyusko
Copy link
Contributor

Hey, I'm Kiryl from Margelo and I'd like to work on this issue 👀

@kirillzyusko
Copy link
Contributor

After discussion with @chrispader I think it's better to assign him, because he's working on similar issues such as #53161 or #53190

@mountiny
Copy link
Contributor

@chrispader please comment and I will assign you too

@chrispader
Copy link
Contributor

commenting for assignment!

@melvin-bot melvin-bot bot added the Weekly KSv2 label Nov 27, 2024
@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Nov 28, 2024
@mountiny
Copy link
Contributor

image good

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 28, 2024
@melvin-bot melvin-bot bot changed the title Android - LHN - Extra space at the bottom of LHN [HOLD for payment 2024-12-05] Android - LHN - Extra space at the bottom of LHN Nov 28, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 28, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-05. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Nov 28, 2024

@Julesssss / @mountiny @adelekennedy @chrispader / @kirillzyusko The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@Julesssss
Copy link
Contributor

^ No regression test required for this. It was a one-off for a tricky native theming change. Regression was noticed quickly.

@Julesssss Julesssss reopened this Nov 28, 2024
@mountiny
Copy link
Contributor

Payment for @allroundexperts is handled elsewhere, I think we can close this one now

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 30, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-12-05] Android - LHN - Extra space at the bottom of LHN [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Android - LHN - Extra space at the bottom of LHN Nov 30, 2024
Copy link

melvin-bot bot commented Nov 30, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-07. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Nov 30, 2024

@Julesssss / @mountiny @adelekennedy @chrispader / @kirillzyusko The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants