-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Android - LHN - Extra space at the bottom of LHN #53205
Comments
Triggered auto assignment to @Julesssss ( |
Triggered auto assignment to @adelekennedy ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Hey @kirillzyusko, here's another issue that only occurs when users have soft navigation buttons enabled. Noting that this was introduced by the edge-to-edge changes. We expected to have some issues like this and we shouldn't revert the PR. |
Hey, I'm Kiryl from Margelo and I'd like to work on this issue 👀 |
After discussion with @chrispader I think it's better to assign him, because he's working on similar issues such as #53161 or #53190 |
@chrispader please comment and I will assign you too |
commenting for assignment! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-05. 🎊 For reference, here are some details about the assignees on this issue:
|
@Julesssss / @mountiny @adelekennedy @chrispader / @kirillzyusko The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
^ No regression test required for this. It was a one-off for a tricky native theming change. Regression was noticed quickly. |
Payment for @allroundexperts is handled elsewhere, I think we can close this one now |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-07. 🎊 For reference, here are some details about the assignees on this issue:
|
@Julesssss / @mountiny @adelekennedy @chrispader / @kirillzyusko The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.67-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Expected Result:
There will be no extra space at the bottom of LHN.
Actual Result:
There is extra space at the bottom of LHN.
This issue is not reproducible if device navigation uses swipe gestures.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6677798_1732697892294.Screen_Recording_20241127_165443.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @adelekennedyThe text was updated successfully, but these errors were encountered: