Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD App#53192] Expensify Card - Navigation bar overlaps the Next button in Choose a limit type step #53217

Open
1 of 8 tasks
lanitochka17 opened this issue Nov 27, 2024 · 7 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.67-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5268041
Issue reported by: Applause - Internal Team

Action Performed:

Preconditions
User logged in with an expensifail account.
User is an admin of a workspace and has enabled Expensify Cards in more features.
Workflows MUST be disabled in the workspace.
User has set a fully verified VBA before.
Steps

  1. Add another member to the WS so there's at least 2 members
  2. Navigate to the "Expensify Card" page in WS settings
  3. Tap on "Issue new card"
  4. Select the user you are using
  5. Select Virtual Card

Expected Result:

The Next button in the "Select a Limit Type" step should be displayed above the navigation bar

Actual Result:

The navigation bar overlaps the Next button in the "Choose a limit type" step

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6677640_1732677257872.Next_button.mp4

Bug6677640_1732677257890!Next_button (1)

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Nov 27, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 27, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny
Copy link
Contributor

Similar to other android issues with the margin now after enabling the edge-to-edge feature cc @chrispader @kirillzyusko

@kirillzyusko
Copy link
Contributor

Yes, looks like safe area padding is missing on Android

@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 27, 2024
@mountiny mountiny moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Nov 27, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mountiny
Copy link
Contributor

@kirillzyusko i will put this on hold for the other issue

@mountiny mountiny changed the title Expensify Card - Navigation bar overlaps the Next button in Choose a limit type step [HOLD] Expensify Card - Navigation bar overlaps the Next button in Choose a limit type step Nov 27, 2024
@mountiny mountiny changed the title [HOLD] Expensify Card - Navigation bar overlaps the Next button in Choose a limit type step [HOLD App#53192] Expensify Card - Navigation bar overlaps the Next button in Choose a limit type step Nov 27, 2024
@mountiny mountiny added the Reviewing Has a PR in review label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

6 participants