fix: apply offsetParent polyfill for Chrome 109+ #6520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
added
the
pr ready for visual snapshots
* bumps @floating-ui/dom
jcfranco
added
pr ready for visual snapshots
This was referenced Feb 27, 2023
Tooltips no longer move along x/y axis when transitioning to the
open state for the first time
#5697
Closed
benelan
approved these changes
Feb 28, 2023
| @@ -27,29 +27,44 @@ async function patchFloatingUiForNonChromiumBrowsers(): Promise<void> { | |||
| platform: string; | |||
| } | |||
|
|
|||
| function getUAData(): NavigatorUAData | undefined { | |||
| return (navigator as any).userAgentData; | |||
There was a problem hiding this comment.
I assume you had to assert navigator as any because userAgentData is experimental and not included in its type yet?
https://developer.mozilla.org/en-US/docs/Web/API/Navigator/userAgentData#browser_compatibility
There was a problem hiding this comment.
Correct and this particular code is based on @floating-ui/dom https://github.com/floating-ui/floating-ui/blob/f63411e85ae12bfe0c983e7c8104c57eb7849d0a/packages/dom/src/utils/userAgent.ts.
jcfranco
deleted the
jcfranco/6300-apply-offsetParent-polyfill-for-chrome109+
branch
github-actions
bot
added this to the 2023 February Priorities Patch (1.0.8) - Bugs only milestone
benelan
added a commit
that referenced
this pull request
Mar 7, 2023
…tory * origin/master: (57 commits) ci(eslint): ignore private/internal code for jsdoc rules (#6416) fix(modal): ensure modal transitions are in sync (#6564) fix(action): ensure consistent width to accommodate indicator when displaying text (#6562) build(deps): Bump focus-trap from 7.2.0 to 7.3.1 (#6540) feat(block): add built-in localization (#6503) revert(stepper-item): emits calciteStepperItemSelect event when selected (#6560) refactor: move ref prop last to ensure ref node is in sync (#6530) feat(stepper-item): emits `calciteStepperItemSelect` event when selected. (#6521) build(deps): Bump @storybook/addon-a11y from 6.5.15 to 6.5.16 (#6539) build(deps): Bump eslint from 8.30.0 to 8.35.0 (#6543) chore(block): add t9n message bundles. (#6559) build: ensure required files are available for doc preview build (#6557) fix(slider): range slider thumb on all touch-enabled devices now follows touch gesture (#6553) feat(modal): provides `content-top` and `content-bottom` slots (#6490) chore(release): 1.0.8 chore(release): 1.0.8-next.4 fix(filter, list): filter properly on initialization (#6551) chore(release): 1.0.8-next.3 fix: apply offsetParent polyfill for Chrome 109+ (#6520) fix(tree): restore wrapping in tree-item text content (#6518) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6300
Summary
This addresses positioning issues in Chrome 109+. Version 109 updated offsetParent behavior to follow the latest spec changes from w3c/csswg-drafts#159.