feat(modal): provides content-top and content-bottom slots
#6490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
Elijbet
added
the
pr ready for visual snapshots
Elijbet
added
pr ready for visual snapshots
Elijbet
removed
the
pr ready for visual snapshots
Elijbet
added
the
pr ready for visual snapshots
…ng vairable as a fallback value and all around same padding
Elijbet
added
pr ready for visual snapshots
jcfranco
changed the title
content-header and content-footer slotscontent-top and content-bottom slots
jcfranco
approved these changes
Feb 24, 2023
|
@Elijbet Let's wait until the patch release is done before merging this. |
Elijbet
added
pr ready for visual snapshots
benelan
added a commit
that referenced
this pull request
Mar 7, 2023
…tory * origin/master: (57 commits) ci(eslint): ignore private/internal code for jsdoc rules (#6416) fix(modal): ensure modal transitions are in sync (#6564) fix(action): ensure consistent width to accommodate indicator when displaying text (#6562) build(deps): Bump focus-trap from 7.2.0 to 7.3.1 (#6540) feat(block): add built-in localization (#6503) revert(stepper-item): emits calciteStepperItemSelect event when selected (#6560) refactor: move ref prop last to ensure ref node is in sync (#6530) feat(stepper-item): emits `calciteStepperItemSelect` event when selected. (#6521) build(deps): Bump @storybook/addon-a11y from 6.5.15 to 6.5.16 (#6539) build(deps): Bump eslint from 8.30.0 to 8.35.0 (#6543) chore(block): add t9n message bundles. (#6559) build: ensure required files are available for doc preview build (#6557) fix(slider): range slider thumb on all touch-enabled devices now follows touch gesture (#6553) feat(modal): provides `content-top` and `content-bottom` slots (#6490) chore(release): 1.0.8 chore(release): 1.0.8-next.4 fix(filter, list): filter properly on initialization (#6551) chore(release): 1.0.8-next.3 fix: apply offsetParent polyfill for Chrome 109+ (#6520) fix(tree): restore wrapping in tree-item text content (#6518) ...
benelan
added a commit
that referenced
this pull request
Mar 13, 2023
…efox-esr * origin/master: (62 commits) build(deps): Bump rimraf and @types/rimraf (#6541) build(deps): Bump quicktype-core from 6.1.0 to 23.0.12 (#6573) test(tabs): delay story due to potential timing chromatic diff (#6437) build(deps): Bump chromatic from 6.14.0 to 6.17.1 (#6571) build(deps): Bump postcss from 8.4.20 to 8.4.21 (#6570) build(deps): Bump eslint-config-prettier from 8.6.0 to 8.7.0 (#6572) ci(eslint): ignore private/internal code for jsdoc rules (#6416) fix(modal): ensure modal transitions are in sync (#6564) fix(action): ensure consistent width to accommodate indicator when displaying text (#6562) build(deps): Bump focus-trap from 7.2.0 to 7.3.1 (#6540) feat(block): add built-in localization (#6503) revert(stepper-item): emits calciteStepperItemSelect event when selected (#6560) refactor: move ref prop last to ensure ref node is in sync (#6530) feat(stepper-item): emits `calciteStepperItemSelect` event when selected. (#6521) build(deps): Bump @storybook/addon-a11y from 6.5.15 to 6.5.16 (#6539) build(deps): Bump eslint from 8.30.0 to 8.35.0 (#6543) chore(block): add t9n message bundles. (#6559) build: ensure required files are available for doc preview build (#6557) fix(slider): range slider thumb on all touch-enabled devices now follows touch gesture (#6553) feat(modal): provides `content-top` and `content-bottom` slots (#6490) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #4800
Summary
Provides
content-topandcontent-bottomslots.For simplicity, we matched the
paddingon thecontent-topandcontent-bottomto thecontent, with one public prop for the latter. This can further be developed if requested.We decided to move forward with
content-topandcontent-bottomnaming, as this should provide enough context and also aligns with existing<x>-start/<x>-endnaming.