Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltips no longer move along x/y axis when transitioning to the open state for the first time #5697

Closed
nwhittaker opened this issue Nov 7, 2022 · 12 comments
Closed

Tooltips no longer move along x/y axis when transitioning to the open state for the first time #5697

nwhittaker opened this issue Nov 7, 2022 · 12 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - low Issue is non core or affecting less that 10% of people using the library regression Issues that are caused by changes in a release, but were working before that. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.
Milestone
2024-08-27 - Aug ...

Comments

@nwhittaker
Copy link
Contributor

Actual Behavior

The first time a tooltip's reference element is hovered, the tooltip appears abruptly in place. Subsequent hoverings of the reference element show a smoother transition of the tooltip from hidden to visible along the x or y axis (depending on how the tooltip is positioned relative to the reference element).

Expected Behavior

The tooltip transitions in smoothly along the x or y axis the first time its reference element is hovered.

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/ExRNKoZ

Reproduction Steps

  1. Visit the code sample
  2. Hover the text and note the tooltip appears in place (it may help to slow down animations in devtools)
  3. Hover the text again and note the tooltip now transitions along the x or y axis when showing/hiding.

Reproduction Version

beta.97

Relevant Info

No response

Regression?

next.606

Impact

For performance reasons, Field Maps generates some tooltips "just in time" when the reference element is hovered. As a result, the way these tooltips visually appear is inconsistent with how other tooltips in the app appear.

Esri team

ArcGIS Field Apps
@nwhittaker nwhittaker added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. regression Issues that are caused by changes in a release, but were working before that. labels Nov 7, 2022
@geospatialem geospatialem added the blocked This issue is blocked by another issue. label Feb 27, 2023
@geospatialem geospatialem added this to the Stalled milestone Feb 27, 2023
@geospatialem
Copy link
Member

Will determine if other floating UI fixes, such as #6520 improve this bug.

@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Feb 27, 2023
@jcfranco jcfranco added the p - low Issue is non core or affecting less that 10% of people using the library label Apr 28, 2023
@driskull
Copy link
Member

driskull commented Sep 6, 2023

@nwhittaker is this issue still present in the latest release?

@nwhittaker
Copy link
Contributor Author

@driskull, I updated the pen in the description to 1.7.0 and still see the originally observed behavior.

@driskull
Copy link
Member

driskull commented Sep 6, 2023

Thanks for confirming!

@jcfranco
Copy link
Member

jcfranco commented Dec 7, 2023

This should be fixed now via #8001 (see updated repro case).

@nwhittaker Can you confirm?

@nwhittaker
Copy link
Contributor Author

I updated a fork of the repro to 2.0.0 and the issue looks resolved to me. Thanks!

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 0 - new New issues that need assignment. blocked This issue is blocked by another issue. labels Dec 7, 2023
@geospatialem
Copy link
Member

Verified per Nate's comment above.

@jcfranco jcfranco mentioned this issue Dec 13, 2023
Merged
@driskull driskull reopened this Dec 13, 2023
@driskull driskull added 0 - new New issues that need assignment. and removed 4 - verified Issues that have been released and confirmed resolved. labels Dec 13, 2023
@driskull driskull added the needs triage Planning workflow - pending design/dev review. label Dec 13, 2023
@driskull
Copy link
Member

Reopened issue and added triage label. see #8409 for reasoning.

driskull added a commit that referenced this issue Dec 13, 2023
@driskull
fix(floating-ui): improve floating element performance (#8409)
4d8cfb8 
**Related Issue:** #7979 #8214 #8386 #8419 #5697

## Summary

- reverts #8001
  - Keeps doc updates 
- reverts partially #8230
- Keeps drag classes that are setting `overflow:hidden` when a drag is
occurring.
- Keeps roundByDPR floating-ui fix.
https://floating-ui.com/docs/misc#subpixel-and-accelerated-positioning
- Hides overflow for `calcite-sortable--chosen` class
- Only sets `top` and `left` on floating element once positioned. **This
fixes native drag and drop issue**
@geospatialem geospatialem added the spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. label Jan 11, 2024
@geospatialem
Copy link
Member

Spike to explore the transitions of the tooltip upon opening as it relates to overall performance of the component.

With the intent to focus on a future milestone in mid/late 2024 at the earliest if a solution is reached.

@geospatialem geospatialem added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jan 11, 2024
@driskull
Copy link
Member

@geospatialem I tried a few things and couldn't figure out a way to get this animation to work correctly the first time. Maybe someone else wants to take a shot at it?

@geospatialem geospatialem added this to the 2024-04-24 - Apr Release milestone Jan 23, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 23, 2024
@brittneytewks brittneytewks added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Mar 25, 2024
@brittneytewks brittneytewks removed this from the 2024-04-30 - Apr Release milestone Mar 25, 2024
@geospatialem geospatialem added this to the 2024-08-27 - Aug Release milestone Apr 3, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@driskull driskull self-assigned this Aug 1, 2024
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Aug 1, 2024
driskull added a commit that referenced this issue Aug 1, 2024
@driskull
fix(tooltip): fix animation on first open state. #5697
3b3c743
@driskull driskull mentioned this issue Aug 1, 2024
Merged
driskull added a commit that referenced this issue Aug 1, 2024
@driskull @jcfranco
fix: improve all initial floating-ui positioning (#9937)
7d21438 
**Related Issue:** #5697

## Summary

- switch from using transform to inset. transform was conflicting with
the floating-ui positioning
- `visibility` transition removed because theres no transition for
visibility and it was messing with positioning
- animation now works on first run
- cleanup

---------

Co-authored-by: JC Franco <[email protected]>
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Aug 1, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Aug 5, 2024

🍡 Verified on 2.12.0-next.4

Before (First hover):

Screen.Recording.2024-08-05.at.12.39.09.PM.mov

After (First hover):

Screen.Recording.2024-08-05.at.12.41.02.PM.mov

@DitwanP DitwanP closed this as completed Aug 5, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - low Issue is non core or affecting less that 10% of people using the library regression Issues that are caused by changes in a release, but were working before that. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

No branches or pull requests
8 participants
@jcfranco @nwhittaker @driskull @alisonailea @geospatialem @benelan @DitwanP @brittneytewks