Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/master' into benelan/delay-tab-s…
Browse files Browse the repository at this point in the history
…tory

* origin/master: (57 commits)
  ci(eslint): ignore private/internal code for jsdoc rules (#6416)
  fix(modal): ensure modal transitions are in sync (#6564)
  fix(action): ensure consistent width to accommodate indicator when displaying text (#6562)
  build(deps): Bump focus-trap from 7.2.0 to 7.3.1 (#6540)
  feat(block): add built-in localization (#6503)
  revert(stepper-item): emits calciteStepperItemSelect event when selected (#6560)
  refactor: move ref prop last to ensure ref node is in sync (#6530)
  feat(stepper-item): emits `calciteStepperItemSelect` event when selected. (#6521)
  build(deps): Bump @storybook/addon-a11y from 6.5.15 to 6.5.16 (#6539)
  build(deps): Bump eslint from 8.30.0 to 8.35.0 (#6543)
  chore(block): add t9n message bundles. (#6559)
  build: ensure required files are available for doc preview build (#6557)
  fix(slider): range slider thumb on all touch-enabled devices now follows touch gesture (#6553)
  feat(modal): provides `content-top` and `content-bottom` slots (#6490)
  chore(release): 1.0.8
  chore(release): 1.0.8-next.4
  fix(filter, list): filter properly on initialization (#6551)
  chore(release): 1.0.8-next.3
  fix: apply offsetParent polyfill for Chrome 109+ (#6520)
  fix(tree): restore wrapping in tree-item text content (#6518)
  ...
  • Loading branch information
benelan committed Mar 7, 2023
2 parents 472441f + 942cf56 commit c6ada75
Show file tree
Hide file tree
Showing 129 changed files with 1,920 additions and 1,032 deletions.
16 changes: 13 additions & 3 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,17 +65,23 @@
}
],
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-unused-vars": "error",
"curly": "error",
"jest/expect-expect": "off",
"jest/no-export": "warn",
"jsdoc/require-jsdoc": "off",
"jsdoc/check-tag-names": "off",
"jsdoc/require-jsdoc": "off",
"lines-between-class-members": ["error", "always"],
"no-multiple-empty-lines": ["error", { "max": 1 }],
"no-unneeded-ternary": "error",
"no-eval": "error",
"no-implied-eval": "error",
"no-multiple-empty-lines": [
"error",
{
"max": 1
}
],
"no-new-func": "error",
"no-unneeded-ternary": "error",
"react/forbid-component-props": [
"warn",
{
Expand Down Expand Up @@ -129,6 +135,10 @@
"settings": {
"react": {
"pragma": "h"
},
"jsdoc": {
"ignoreInternal": true,
"ignorePrivate": true
}
}
}
2 changes: 0 additions & 2 deletions .github/ISSUE_TEMPLATE/accessibility.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ body:
attributes:
label: Reproduction Version
description: The latest version that reproduces the issue.
placeholder: 1.0.0-beta.99
validations:
required: true
- type: input
Expand All @@ -77,7 +76,6 @@ body:
attributes:
label: Regression?
description: Please provide the last working version if the issue is a regression.
placeholder: 1.0.4
validations:
required: false
- type: dropdown
Expand Down
15 changes: 13 additions & 2 deletions .github/ISSUE_TEMPLATE/bug.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ body:
attributes:
label: Reproduction Version
description: The latest version that reproduces the issue.
placeholder: 1.0.4
validations:
required: true
- type: textarea
Expand All @@ -64,9 +63,21 @@ body:
attributes:
label: Regression?
description: Please provide the last working version if the issue is a regression.
placeholder: 1.0.0-beta.99
validations:
required: false
- type: dropdown
id: priority-impact
validations:
required: true
attributes:
label: Priority impact
multiple: false
description: What is the impact to you, your team, or organization? Use discretion and only select "need" or "emergency" priorities for high user impact and quality issues. For instance, would someone notice, in a bad way, if this issue were present in the release?
options:
- p3 - not time sensitive
- p2 - want for current milestone
- p1 - need for current milestone
- p0 - emergency
- type: textarea
id: impact
attributes:
Expand Down
66 changes: 66 additions & 0 deletions .github/workflows/add-bug-priority-label.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
name: Add Bug Priority Label
on:
issues:
types: [opened, edited]
jobs:
label:
runs-on: ubuntu-latest
steps:
- uses: actions/github-script@v6
with:
script: |
const {
repo: { owner, repo },
payload: {
action,
issue: { body, labels: currentLabels, number: issue_number },
},
} = context;
if (!body) {
console.log("could not determine the issue body");
return;
}
const bugPriorityRegex = new RegExp(
action === "edited"
? // the way GitHub parses the issue body into plaintext
// requires this exact format for edits
"(?<=### Priority impact\r\n\r\n).+"
: // otherwise it depends on the submitter's OS
"(?<=### Priority impact[\r\n|\r|\n]{2}).+$",
"m"
);
const bugPriorityRegexMatch = body.match(bugPriorityRegex);
const bugPriority = (
bugPriorityRegexMatch && bugPriorityRegexMatch[0] ? bugPriorityRegexMatch[0] : ""
).trim();
if (bugPriority && bugPriority !== "N/A") {
/** Creates a label if it does not exist */
try {
await github.rest.issues.getLabel({
owner,
repo,
name: bugPriority,
});
} catch (error) {
await github.rest.issues.createLabel({
owner,
repo,
name: bugPriority,
color: "bb7fe0",
description: `User set priority status of ${bugPriority}`,
});
}
/** add new bug priority label */
await github.rest.issues.addLabels({
issue_number,
owner,
repo,
labels: [bugPriority],
});
}
187 changes: 187 additions & 0 deletions .github/workflows/sync_to_airtable.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,187 @@
name: Sync to Airtable

on:
issues:
types: [assigned, closed, demilestoned, edited, labeled, milestoned, opened, reopened, unassigned, unlabeled]

jobs:
issue_assigned:
runs-on: ubuntu-latest
if: github.event.action == 'assigned' || github.event.action == 'unassigned'
steps:
- name: Set Data
id: set-assigned-data
uses: actions/github-script@v6
env:
SECRET: ${{ secrets.AIRTABLE_KEY }}
WEBHOOK: ${{ secrets.AIRTABLE_WEBHOOK }}
with:
script: |
const { action, issue, repository } = context.payload;
const body = JSON.stringify({
action,
data: JSON.stringify({ assignees: issue.assignees }),
owner: repository.owner.login,
repo: repository.name,
number: issue.number.toString(),
secret: process.env.SECRET,
title: issue.title,
});
return fetch(process.env.WEBHOOK, {
body,
headers: {
"Content-Type": "application/json"
},
method: "POST"
});
issue_closed:
runs-on: ubuntu-latest
if: github.event.action == 'closed'
steps:
- name: Set Data
id: set-closed-data
uses: actions/github-script@v6
env:
SECRET: ${{ secrets.AIRTABLE_KEY }}
WEBHOOK: ${{ secrets.AIRTABLE_WEBHOOK }}
with:
script: |
const { action, issue, repository } = context.payload;
const body = JSON.stringify({
action,
data: issue.closed_at,
owner: repository.owner.login,
repo: repository.name,
number: issue.number.toString(),
secret: process.env.SECRET,
title: issue.title,
});
return fetch(process.env.WEBHOOK, {
body,
headers: {
"Content-Type": "application/json"
},
method: "POST"
});
issue_milestoned:
runs-on: ubuntu-latest
if: github.event.action == 'demilestoned' || github.event.action == 'milestoned'
steps:
- name: Set Data
id: set-demilestoned-data
uses: actions/github-script@v6
env:
SECRET: ${{ secrets.AIRTABLE_KEY }}
WEBHOOK: ${{ secrets.AIRTABLE_WEBHOOK }}
with:
script: |
const { action, issue, repository } = context.payload;
const body = JSON.stringify({
action,
data: JSON.stringify(issue.milestone || null),
owner: repository.owner.login,
repo: repository.name,
number: issue.number.toString(),
secret: process.env.SECRET,
title: issue.title,
});
return fetch(process.env.WEBHOOK, {
body,
headers: {
"Content-Type": "application/json"
},
method: "POST"
});
issue_edited:
runs-on: ubuntu-latest
if: github.event.action == 'edited'
steps:
- name: Set Data
id: set-edited-data
uses: actions/github-script@v6
env:
SECRET: ${{ secrets.AIRTABLE_KEY }}
WEBHOOK: ${{ secrets.AIRTABLE_WEBHOOK }}
with:
script: |
const { action, issue, changes, repository } = context.payload;
const body = JSON.stringify({
action,
changes: JSON.stringify(changes || null),
data: JSON.stringify(Object.keys(changes).reduce((acc, key) => {
acc[key] = issue[key]
return acc;
}, {})),
owner: repository.owner.login,
repo: repository.name,
number: issue.number.toString(),
secret: process.env.SECRET,
title: changes['title']
? changes['title'].from
: issue.title,
});
return fetch(process.env.WEBHOOK, {
body,
headers: {
"Content-Type": "application/json"
},
method: "POST"
});
issue_labeled:
runs-on: ubuntu-latest
if: github.event.action == 'labeled' || github.event.action == 'unlabeled'
steps:
- name: Set Data
id: set-labeled-data
uses: actions/github-script@v6
env:
SECRET: ${{ secrets.AIRTABLE_KEY }}
WEBHOOK: ${{ secrets.AIRTABLE_WEBHOOK }}
with:
script: |
const { action, issue, repository } = context.payload;
const body = JSON.stringify({
action,
data: JSON.stringify({labels: issue.labels}),
owner: repository.owner.login,
repo: repository.name,
number: issue.number.toString(),
secret: process.env.SECRET,
title: issue.title,
});
return fetch(process.env.WEBHOOK, {
body,
headers: {
"Content-Type": "application/json"
},
method: "POST"
});
issue_opened:
runs-on: ubuntu-latest
if: github.event.action == 'opened' || github.event.action == 'reopened'
steps:
- name: Set Data
id: set-opened-data
uses: actions/github-script@v6
env:
SECRET: ${{ secrets.AIRTABLE_KEY }}
WEBHOOK: ${{ secrets.AIRTABLE_WEBHOOK }}
with:
script: |
const { action, issue, repository } = context.payload;
const body = JSON.stringify({
action,
data: JSON.stringify(issue),
owner: repository.owner.login,
repo: repository.name,
number: issue.number.toString(),
secret: process.env.SECRET,
title: issue.title,
});
return fetch(process.env.WEBHOOK, {
body,
headers: {
"Content-Type": "application/json"
},
method: "POST"
});
3 changes: 1 addition & 2 deletions .lintstagedrc.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"*.{json,html,yml}": ["prettier --write"],
"*.js": ["eslint --ext .js --fix", "prettier --write"],
"*.scss": ["stylelint --fix", "prettier --write"],
"*/!(assets)/*.{ts,tsx}": ["eslint --ext .ts,.tsx --fix", "prettier --write"],
"*.{ts,tsx}": ["eslint --ext .ts,.tsx --fix", "prettier --write"],
"*.md": ["markdownlint --fix --disable MD024 MD013 MD041 MD033", "prettier --write"]
}
38 changes: 38 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,44 @@
This document maintains a list of released versions and changes introduced by them.
This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html)

## [v1.0.8](https://github.com/Esri/calcite-components/compare/v1.0.7...v1.0.8) (2023-03-02)

### Bug Fixes

- **filter, list:** filter properly on initialization ([#6551](https://github.com/Esri/calcite-components/issues/6551)) ([b7782aa](https://github.com/Esri/calcite-components/commit/b7782aa79fc05fa9f217b08185f2fe35e36ef9f1)), closes [#6523](https://github.com/Esri/calcite-components/issues/6523)

* apply offsetParent polyfill for Chrome 109+ ([#6520](https://github.com/Esri/calcite-components/issues/6520)) ([ba8c068](https://github.com/Esri/calcite-components/commit/ba8c0688dd92a99e147f0e6434a969fef10ab3e3)), closes [#6300](https://github.com/Esri/calcite-components/issues/6300)
* **tree:** restore wrapping in tree-item text content ([#6518](https://github.com/Esri/calcite-components/issues/6518)) ([7b95194](https://github.com/Esri/calcite-components/commit/7b951944ee028c2d5f372de8b04d10e69a2ef0c3)), closes [#6512](https://github.com/Esri/calcite-components/issues/6512)

- **tree:** prevent tree-item content from being clipped ([#6519](https://github.com/Esri/calcite-components/issues/6519)) ([8501b23](https://github.com/Esri/calcite-components/commit/8501b2333196240fa3549117447ebac3f7f62e0d)), closes [#6514](https://github.com/Esri/calcite-components/issues/6514)

* **select, slider, combobox:** display label in screen reader instructions. ([#6500](https://github.com/Esri/calcite-components/issues/6500)) ([3a7f112](https://github.com/Esri/calcite-components/commit/3a7f11238d52e7b5cec1cd2dd597d0184d7e0ce3)), closes [#5627](https://github.com/Esri/calcite-components/issues/5627)
* **value-list:** add back instructions for screen reader when drag handle is activated ([#6402](https://github.com/Esri/calcite-components/issues/6402)) ([b822f25](https://github.com/Esri/calcite-components/commit/b822f25a88519c8a4ddb1311006a88ac1e7b5a1b)), closes [#6401](https://github.com/Esri/calcite-components/issues/6401) [#5739](https://github.com/Esri/calcite-components/issues/5739)

- **slider:** slider handle aligns with track when font size changes ([#5372](https://github.com/Esri/calcite-components/issues/5372)) ([780df6c](https://github.com/Esri/calcite-components/commit/780df6c78b9dd111bec177189421372c3fe21285)), closes [#4721](https://github.com/Esri/calcite-components/issues/4721)

## [v1.0.7](https://github.com/Esri/calcite-components/compare/v1.0.6...v1.0.7) (2023-02-15)

### Reverts

- **focus-trap:** prevent host from receiving initial focus ([#6483](https://github.com/Esri/calcite-components/pull/6483)) ([68f2c0e](https://github.com/Esri/calcite-components/commit/68f2c0e54339fb4be37172a69b17bbcde60b9613))

## [v1.0.6](https://github.com/Esri/calcite-components/compare/v1.0.5...v1.0.6) (2023-02-14)

### Bug Fixes

- **focus-trap:** prevent host from receiving initial focus ([#6479](https://github.com/Esri/calcite-components/issues/6479)) ([764609d](https://github.com/Esri/calcite-components/commit/764609de7b8c96aa331e364ca790eefdb44dd1ab)), closes [#6454](https://github.com/Esri/calcite-components/issues/6454) [/github.com/Esri/calcite-components/blob/059d6eee6a8dc0a0d74db6e113d30cafebac25bb/src/utils/focusTrapComponent.ts#L33-L35](https://github.com/Esri//github.com/Esri/calcite-components/blob/059d6eee6a8dc0a0d74db6e113d30cafebac25bb/src/utils/focusTrapComponent.ts/issues/L33-L35)
- **tree-item:** preserves consistent height with or w/t actions-end ([#6403](https://github.com/Esri/calcite-components/issues/6403)) ([728f42b](https://github.com/Esri/calcite-components/commit/728f42b4ad219f5c947cfd5226db7959c3cfd9c1)), closes [#6361](https://github.com/Esri/calcite-components/issues/6361) [#3127](https://github.com/Esri/calcite-components/issues/3127)
- **vite:** getting the dist build to work correctly with vite again ([#6452](https://github.com/Esri/calcite-components/issues/6452)) ([cc44984](https://github.com/Esri/calcite-components/commit/cc44984966d21a8537e03daa0fe66d90bff38385)), closes [#6419](https://github.com/Esri/calcite-components/issues/6419)

## [1.0.5](https://github.com/Esri/calcite-components/compare/v1.0.4...v1.0.5) (2023-02-09)

### Bug Fixes

- **input, input-number, input-text:** emit change value when clearing programmatically-set value ([#6431](https://github.com/Esri/calcite-components/issues/6431)) ([1802dc3](https://github.com/Esri/calcite-components/commit/1802dc3898358159da7304a940c1c530d8e98509)), closes [#4232](https://github.com/Esri/calcite-components/issues/4232)
- **modal:** no longer loses focus trap after clicking inside the component. ([#6434](https://github.com/Esri/calcite-components/issues/6434)) ([df144dc](https://github.com/Esri/calcite-components/commit/df144dc30e66d7e11fda326f289c6b8c931c34f8)), closes [#6281](https://github.com/Esri/calcite-components/issues/6281)
- **tooltip:** prevent closing of Esc-key-closing parent components when dismissing a tooltip with Esc ([#6343](https://github.com/Esri/calcite-components/issues/6343)) ([b4cbf54](https://github.com/Esri/calcite-components/commit/b4cbf544f876a5212d234368bbd296ed43433515)), closes [#6292](https://github.com/Esri/calcite-components/issues/6292)

## [v1.0.4](https://github.com/Esri/calcite-components/compare/v1.0.3...v1.0.4) (2023-02-07)

### Bug Fixes
Expand Down
Loading

0 comments on commit c6ada75

Please sign in to comment.