Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

2019 Weekly Meeting

Jump to bottom
JC Franco edited this page Jan 10, 2020 · 281 revisions

2020 Weekly Meeting Notes

2019-12-27

Cancelled.

2019-12-20

  • (Alan) detached PR: when should we do it?
  • (Alan) Is ActionPad a version of ActionBar?
    • related issue 656
  • Harry - action a11y. It's currently possible to omit text and label, and it's especially easy to overlook if using an icon. This would cause the aria-label to be null. Discuss options.
    • Remove label attribute and make text required. Main downside is title attribute can't be more descriptive than action label.
    • Keep label for override, but make text required. Dev experience takes a hit since a label prop on an action icon would yield a valid experience, but TS would complain about missing text.
    • Remove label and provide a generic fallback for text. Downside: the spirit of the rule could easily be broken if generic text is insufficient.
    • Keep or remove label. Add a console.warn if a string is not provided, allowing the dev to choose which to use. But downside here is it could technically still be ignored.
    • Could combine the above 2 for a potentially "poor fallback" with a warning.
  • Katy - We have failing tests on master. Should we set up Travis to check for this?
  • [Matt] Clean up Fern issues and PRs.

Action items:

  • Alan do PR!!!!!!!!!!!!!!!!!!!!
  • Keep action pad and bar separate
  • Alan talk to Mitch about accessibility/aria label stuff
  • Harry make text required.

2019-12-13

  • Harry - Beta components. Thoughts are we could try out a version of a generic sortable list but mark it as beta so we only need to get it working for 1 or 2 known use-cases, which may change in the future.

    👍 as long as wording is clear on limitatins (e.g., only works w/ block and value-list)

  • IE11 - the research so far.

    blocker for IE11 support; need to sync w/ stakeholders about cost of supporting IE11

  • [Matt] Focusing a component. Sample

    • Stencil won't add delegatesFocus support until more browsers work with it.

    use the linked workaround 👆 for handling focus

  • [Matt] Should calcite-flow-item slots accept calcite-action, calcite-button, both?

    Matt will follow up on why action is not being used

  • [Franco] PSA: all things TSified™!

  • [Franco] Future breaking change: disabled block behavior (https://xkcd.com/1172/)

  • [Franco] Storytime!

  • [Matt] Where should back() live on flow/flow-item? https://github.com/Esri/calcite-app-components/pull/608#discussion_r357859040

    back on parent; beforeBack stays on item

2019-12-6

2019-11-29 🦃 - no meeting

2019-11-22

  • [Alan] Started adding to aria roles doc
    • [Matt] Are you sure about these roles?
      • Shouldn't TipManager be group role?
      • Should ActionBar be toolbar role?
      • Should Panel be tabpanel role?
      • My point is that these roles need to be verified 😄
  • [Matt] CalcitePanel heading slots PR
  • [Franco] Style linting is on like Donkey Kong. Need feedback (Slack channel) on which additional ones to enable (there are several autofixable ones).
    • [Harry] unit-case: lower; property-case: lower; declaration-block-semicolon-newline-after: "always-multi-line"; declaration-colon-space-after: "always"
  • [Matt] Card updates?
  • [Matt] Scrim: should it become a component? Or can we share these classes in another npm project?
  • [Matt] CalciteIcon: ^ ditto

Action Items

  • Franco will enable suggested rules and will wait for more feedback.
  • Katy will componetize Scrim on calcite-components
  • Franco will work on making a calcite icon component (calcite-components)

2019-11-15

  • [Harry] https://github.com/Esri/calcite-app-components/issues/87
  • [Matt] Should Flow have the back button remove the current panel automatically or user required to handle it by default?
    • CalciteComponents has a property on modal for something like this
    • @Prop() beforeClose: (el: HTMLElement) => Promise<void> = () =>
    • do breaking change with bundle
  • [Alan/Matt] Should we get rid of the header-content slot in Panel? Only need leading/trailing content.BREAKING CHANGE
    • No change.
  • [JC/Matt] Stencil support
  • {katy} bug Russ found. Have to show on my computer on Safari.
    • in arc gis components tag steven albers.
  • [Matt] Block - Disabled still allows collapsing and shows icon demo
  • [Matt] calcite-loader not centered in panel vertically. demo
    • alern looking in2 dis
  • {katy} Alain and I met with Arjav this morning about reqs
    • katy add snippets! this is unrelated to above point!

2019-11-08

  • [Alern] Expose panel CSS vars? 392

    • other vars we wanna expose?

    Locked down! 🔒 No exposing for now. Whenever the time comes, it will be for high-level CSS vars, no individual component customization options.

  • [Alain] a11y : raise the priority of any accessibility issues, e.g. #356

    Noted; a11y is everybody's job! 💪

Action Items

  • Matt will add a11y issue template

2019-11-01 🌻💀🌻

  • Weekly Humor

  • [Matt] Should we enforce using JSX attributes tabIndex={0} vs native attributes tabindex="0"? We ran into lint warning by using onKeydown vs onKeyDown on a VNode but Host didn't care about either.

    • [Franco] This is more of a preference we'll have to define. Typing-wise, it allows both.

  • [Matt] Should we have a wiki for "areas of responsibility" like the online team has?

    • I think it's a good idea, but I'd propose a different wording, such as "subject matter expert (SME)" so not to imply this person is the only person that works on a component.
    • [Franco] 👍 for SME; although will this get stale? It's possible to get a sense of the SME from git commit history.
    • ACTION:
      • Katy to own this.
      • we're gonna use the term "Captain of Rainbows"

  • [Harry] Have we already decided on using storybook? If not I'd like to propose we look into using Bit for the next phase of documenting components.

    • other doc notes
    • [Franco] If there definite gains, I think it'd be worth exploring. Otherwise, let's stay consistent w/ calcite-components.
    • ACTION:
      • Stick with StoryBoook

  • [Harry] Did the items from 10/18 accidentally get deleted? I don't recall addressing these.

  • Avoid Stencil regressions (from 10-18)

    • ACTION:
      • Stencil update freeze a week before our release

  • Advanced demos (from 10-18)

    • ACTION:
      • Harry to do it
      • at least include long strings in simple demos

  • [Franco] Do we want/need a BREAKING_CHANGES.md (similar to Stencil's)

    • Pro: provide more background on breaking changes and possible workarounds
    • Con: can't be 100% auto-generated
    • ACTION: wait until we need it

  • [Franco] Review lint warning rules. What should be upgraded to error? Do we want to disable the rest or leave as warnings? I believe these are the non-fixable warnings we have enabled:

    • ACTION:
      • update build to no longer do the linting (franco)
      • vote on Slack (fraco)
    • [Matt] As long as these warnings aren't making it into the code for others to clean up I'm fine with linting client side or on the CI.

  • [Franco] Standardize file naming? We have kebab-cased-file names, camelCased and PascalCase.

    • kebab-case is prevalent and consistent w/ Ionic file naming.
    • PascalCase for functional components could be made an exception.
    • ACTION: K, Bob! Except FunctionalComponents

  • [Harry] Any update on the Stencil paid support? Our issues have been pretty stagnant from a triage perspective. Some have been addressed - although for all we know they were already priorities. There a way we can escalate this?

    • UPDATE: ✋ Out of our hands.

  • Required props vs options

    • ACTION:
      • [katy] doc and make a meeting

  • Style updates coming in hot! Need a release on Monday. [alan]

2019-10-25

  • [Harry] Retro item - pickList was broken but all tests were passing. How to prevent in the future.

    • [Matt] 🤷‍♂. Can we test the event for the item being set as a HTMLElement?

    Not sure what else we can do aside from providing test cases from known use cases. Outside of that, we should be fine as long as we keep getting feedback and thus updating/adding tests. The advanced demo pages could help catch issues earlier. MapMaker + other apps will help us test and catch other items

  • [Harry] Collecting feedback - should we setup preferred channels?

    Will use repo as main place for feedback. As fallback, we still have internal Slack/Teams/Skype/email

  • [Harry] On a similar vein as to what was discussed in our Retrospective, I think we should do some Triage at the start of each Milestone, and create a backlog where things get pulled into the Milestone at the start. I'm starting to get to the point where it's doubtful I'll finish every assigned issue that's in the current Milestone, so some prioritization seems like it would be beneficial.

    • [Matt] I think we should let the PE coordinate what can/should be done by prioritizing issues and moving them if necessary. It would be good if the PE was the gatekeeper and contact person for our users.

    Katy will sync up at the beginning of each milestone on action items and things to figure out ☝️ connecting requests for calcite-components in milestone Maybe using GH projects or ZenHub to better manage milestones

  • [Matt] Commit messages: only use feat,fix,etc on merge commit? A lot of redundant info in changelog if not only on merge.

- [Katy] Letz talk about Dragon Dropz. Should we make a reusable Dragon Dropz component? - If so, how will information get passed around? - Maybe we could have our up and coming Block slot be 'named' so the DD comp can look it up that way and render the DD icon appropriately. Thoughts?

  • [Alan] "toggle row" that uses calcite-switch

    • could be used for block section switch mode
    • a layout thing
    • using calcite-switch out of the box requires adding a class and app-level styles
    • open to solutions

    This component has come up frequently. The changes required for calcite-switch to accomplish this are out of scope for that component.

  • [Katy] Make sure to always update issue description, so source of truth is always in sync

Action Items

  • Franco will provide a script to help adhere to conventional commit format
  • Katy will set up a separate meeting to discuss a reusable DnD component
  • Alan will create issue and submit proposal for 'toggle row' component

2019-10-18 - cancelled

2019-10-11 - cancelled (TSConf)

2019-10-04

  • [Harry] Should we commit optional:true changes to package-lock? Any other known workarounds for this cross-OS behavior?

    No way to reliably be cross-os compatible. If you have issues, regenerate and commit ¯\_(ツ)_/¯

  • [Matt] Should we have attributes that only alter presentation of a component? Issue comment | Teams comment

    • discussion around why calcite-components have attributes like scale, color? Things that could be altered by the user adding a class to control sizing or appearance. I'm wondering where we draw the line on attributes vs user applying a class. Seems like attributes should be more for configuration or altering behavior and not appearance. Thoughts?

    Yes. Will follow convenience attributes where applicable; will not guarantee same values honored

  • [Franco] Summary of PR merge blocking:

    • Tests are required to pass (checked by Travis-CI)
    • Must have at least 1 approval
      • w/ option to dismiss (responsibly)

  • [Matt: Maybe]: Tooltips vs Popovers issue

  • [Katy] - Action button

    Will be updated to have presentation attrs

Action Items

  • Alan will inventory Sass vars to check if they all point to calcite-base or calcite-colors vars

2019-09-27

  • [Matt] Does pebble prevent PR from merging?

    • [Franco] extending ☝️ Decide on PR comment tier categories and meaning?

  • [Matt] Mutable prop best practices?

  • [Matt] Action "auto text expand" mode

  • [Matt] Sticky action codepen | demo?

    no new add component, users will use CSS sticky

Action Items

  • Harry will prepare writeup on comment tiers
  • Matt will submit a proposal for Action "auto text expand" mode

2019-09-20

  • [Franco] Design and Dev (DnD) process fine-tuning? 🎲

    • Feedback cycles

  • [Harry] Review Open Issues - Kick the tires on any stale

  • [Harry] Idea - Code review comment tiers. 👍

  • [Matt] Bump to v3? 👍

  • [Matt] calcite-components as a dependency?

    Yes. It will be introduced as a dependency by #205 (switch + block section).

  • [Alan] update npm tasks something something

  • [Katy] moved BMO to choose goose with high p for some issues

Action Items

  • Franco will tentatively strikethrough items on DnD wiki and share w/ group for feedback.
  • Team will adopt tiered PR comments.

2019-09-13

  • [Harry] Commit message standards

    Team will adopt commit message standards.

  • [Matt] Delete calcite-floating-panel?

  • [Matt] Don't have props for native attributes?

    No native attribute props (Stencil compiler warns against this)

  • [Matt] Outgrowing nav-bar? Do we need sub menus and pages for more examples.

    Need something else to support more complete examples (calcite-components may have something in the works)

  • [Matt] Are we on choose goose now?

    Seems that way, but need Katy to confirm.

Action Items

  • Franco will look into changelog/commit format standardization options as part of (#82)
  • calcite-floating-panel will be renamed to dismissable-panel
    • hold off ☝️ until we can confirm this doesn't belong in calcite-components

2019-09-6

  • [Harry] TSLint rule for nested ternaries. This is coming from extending Ionic TSLint Config.

  • [Franco] Design and development process

    • doc own or follow JSAPI's?
    • adhering to it

  • [Franco] Upcoming components/priorities?

    • Dovetailing off this, could we also do a "quick" review of all our open issues to see if anything needs to be assigned or is stagnating?

  • [Harry] Stand-ups. If we're going to do a virtual meeting, could we jump on a video call? Our conversations feel rather unorganized. Alternatively, we can take turns bringing up topics and "yield the floor", but if we do this in Slack - it's going to take longer than 1-2 mins each.

  • [Harry] Suggestion: Add a label for "in code review". I find that this would help me with managing my own tasks in seeing whether I still need to do dev work on it, or rather follow up on a review. Could either make it an official step in the SDLC (#3 pushing installed and verified up a notch) or just a yellow info-label.

    Let's avoid personal labels on repo, GitHub projects should be used instead.

  • [Franco] can haz mockup? https://github.com/Esri/calcite-app-components/issues/205 🙇

Action Items

  • Franco will switch to prefer-conditional-expression warning for readability purposes.
  • Franco will bring over dev process draft. Team will tweak as needed.
  • Katy will take a look at comps/prios/assignments
  • Team will start using video in sync-ups.
  • Alan will provide mockup for #205

2019-08-30 - pushed

2019-08-23

  • [Matt] Positioning of floating panels/action pad. issue

    • Positioning handled by component (i.e., avoid exposing positioning utilities)
    • 3rd party component emits event, app figures out positioning

  • [Matt] Center content under panels. Alan, can you take this? issue

    • Yes. Map shown on bottom.

  • [Alan] How mobile do we need to get?

  • [Alan] Does TipManager need the add/remove? issue

    • Invalid; there's no add/remove APIs

  • [Katy] How to determine due dates for milestones?

    • Abracadaniel is closed!

Action Items

  • Alan will check whether one or two action pads will be supported at the shell-level.
  • Alan will review designs to determine whether we need anchor position
  • Matt will add events to calcite-panel to notify users on width changes (to adjust view padding).
  • Katy will add note to README about supported/recommended screen size.
  • Katy will reach out to Jeremy to determine our milestone due dates

2019-08-12

  • [Franco] Out of beta now or until https://github.com/Esri/calcite-app-components/issues/139 is resolved?
    • Then semver!
    • Need to prioritize 1.x issues.
      • prioritize using labels
      • not tie milestones to versions
      • bump package per updates/installs
  • [Franco] Scheduling brown bag or sync up on how to use these comps?
  • [Franco] Documenting patterns (e.g., binding event handlers methods, const naming)? GUIDELINES.md? Wiki? Example file?
  • [Harry] Using standing meetings to stay on track
  • [Matt] Development process for components
  • [Matt] Testing before leaving beta status.

Action Items

  • Drop beta label once #139 is done.
  • Franco will drop v from existing milestones (independent from package version)
  • Franco will create issue to create wiki/doc for patterns/guidelines
  • Franco will create issue to add more content to README for consumers (handled by ☝️
  • Katy will schedule 2x during week sync-ups
  • Katy will setup app-jams for testing before dropping beta
  • Team will use dev process for new components, case-by-case for enhancements

2019-08-09

  • Create issue for researching the last point. include kelly and tao maybe meeting?

2019-08-02

  • [Franco] calcite-app-components going in alpha after last PRs are merged.

  • [Franco] calcite-components going in beta.1 soon.

  • [Alan] toggle / switch component

    • Will calcite-components deliver?
    • Will they deliver soon enough?
    • Will Lassie come home?

    Already available and will ship in beta.

    How to integrate? We'll learn more about this as we start integration work next week. Stuff to consider:

    • peer dependencies (calcite-app-components + calcite-components)
      • consumers pinning versions if needed
    • build vs source in testing

  • [Alan] Custom focus style?

    No objections, it'd be cool as long as users can override and styling is accessible. Alan will repurpose his work from the JS API and prototype at some point (see https://github.com/ArcGIS/calcite-app-components/issues/111)

2019-07-26

  • [Franco] calcite-components sync-up on 29th
  • [Alan] Shell component
    • proposal: in smaller views, map view goes under panels.
  • [Alan] Selector for empty slot?
  • [Alan] ::slotted() limitation
    • selector can only access the top most element, e.g. ::slotted(*)
    • In the case of <slot name="footer-actions" />
      • If you had two button elements in side of, slot[name="footer-actions"]::slotted(*) can't reach the buttons.
      • But you can use the slot name twice this: <button slot="footer-actions">Save</button><button slot="footer-actions">Cancel</button>
      • Then slot[name="footer-actions"]::slotted(*) or slot[name="footer-actions"]::slotted(button) would access the buttons.
  • [Franco] calcite-components versions using release script whenever a major change is installed (no strict rules)
  • [Franco] Requesting Sass linting feedback – (see https://esri-webgis.slack.com/archives/GLD1LL8MP/p1563580393001400)

Action Items

  • Code-freeze and version once calcite-shell is merged.

2019-07-19

  • Cover 2019-07-05 items.

  • [Franco] Should unstyled components be marked as installed?

    No, mark as installed once feature-complete and styled. PR styling into feature branches. Reassign accordingly, then submit PR to master branch.

  • Should we sync with stakeholders before our demo to get insight into what API design would benefit them the most?

    Yes, with initial stakeholders (NewMapViewer) and involve more teams to get feedback

  • ListBrowser > Picker. ListItem > PickerRow. FYI and open to better suggestions.

    Use Issue #9 to post suggestions.

  • [Franco] Moved code freeze to next week (7/24/20197/26/2019)

  • [Franco] Are Shell & ShellPanel still planned for v1? They're labeled so.

    Need to sync next week

  • [Franco] Sass linting? Example use case, prevent using undesired/unsupported selectors (e.g., host-context since it isn't fully supported)

  • [Franco] Block PR submitted this week.

  • [Franco] Stencil bugs wiki to keep track of known issues. 🐛🐞🔍

Action Items

2019-07-12

  • Keeping track of Stencil Bugs. Wiki or Issues? I'm inclined to keep issues open for actionable tasks and would rather use a Wiki page for tracking important info to keep our issue list clutter-free. Thoughts?

    Unless directly actionable, add a note to related Stencil issues wiki (will be created by Harry). Wiki should be reviewed before every sync-up meeting.

  • To Rename or not to Rename. That is the question. #39

    Unsure what name would be better and fully descriptive. Closing for now.

  • Is anyone else interested in reviewing PRs? I've been assigning Matt and Franco primarily. I'm happy to be more inclusive if there's interest.

    Harry will send email for further reviewers (Ganesh, Kumar, Maneet).

  • Package version. Do we want to start incrementing it as we add new components, even while we stay on major version 0?

    • 0.0.0-alpha.1

    Franco will send email out to calcite-components to figure out their versioning strategy, hold off until we get resolution. Tentatively, we can update the PR template to include a note on bumping the package version accordingly. Optionally, use the release script after merging to set up tag and download.

  • [Franco] Code freeze next week (7/17) pending:

    • #8 Block
    • #26 Define component theming pattern
    • #2 Positioning interface for FloatingPanel & ActionPad
    • What else do we need to move to v1 column? Nothing
    • Doc? Katy will help flesh out doc.
    • Testing passes Need PEs to help test Katy will reach out to get info during the weekly PE meeting

  • Release branching @ code freeze

  • [Franco] TS suggestions (tsconfig.json)

    • disallowing any
    • require return type?

    Franco will test locally with the suggested changes and will report back. Some things to look out for:

    • Any friction WRT Stencil build workflow.
    • Any unnecessary extra work/friction if flags enabled

  • [Franco] Should unstyled components be marked as installed?

    Moved to next week.

  • [Matt] Grouping of tips vs using a shared label: more info

    Harry will schedule meeting for next week to include Alan in conversation.

2019-07-05

  • Thoughts on making squash and merge the default? I keep forgetting.

    no change - for history sake!

  • CHANGELOG.md and/or BREAKING_CHANGES.md - should we start keeping a log of changes - similar to how Ionic team does in Stencil repo?

    Useful to have once released

  • Resolving Conversations in PRs. Who should resolve?

    Fine for PR assignee to resolve it as long as there's a comment notifying the other party

Action Items

2019-06-28

  • Theming

    Just to keep #39 on our radar. The issue is still active, but we could adopt the pattern once it's finalized.

    Pattern is similar to React context, where a context can be shared across components without having to pass objects down a hierarchy.

    Not needed for v1.

    We will discuss stencil-state-tunnel next week.

  • ListBrowser and ListItem

    • are they different from the calcite-components super-select?

    Answer ☝️, "yes they are different".

    ListBrowser and ListItem have more complex concerns.

    Franco will set up kickoff meeting (include Harry) PE is needed, Katy?

    Needed for v1 since MapMaker will use them.

  • Browser Testing Plans

    • I'm seeing some discrepancies in the polyfilled browsers (Edge, IE).
    • Our automated tests run in puppeteer which is Chromium so they don't cover these.
    • Do we have a plan to do some stress testing, and what we want to cover?

    Edge active development for Custom Elements and Shadow DOM - https://developer.microsoft.com/en-us/microsoft-edge/platform/status

    - No exact timeframe. 😭

    Until the polyfill isn't needed anymore, we'll need to test in Edge

    - demo pages will have to include all workflows to make testing easier

    - happy path workflows are fine unless we find special cases

    PEs can help test in Edge.

    How is calcite-components testing them? 🤔

    Will add bullet to PR template to remind devs to test in Edge

  • How should we prioritize and assign out Research stories?

    Prioritization based on need and assignment by volunteer or subject expert.

  • v1 release date: July 31st

    Code freeze 2 weeks prior.

  • [From last week's agenda] Component dependency management

    • Stencil compiler has certain Bundling Restrictions
    • In order to prevent writing brittle tests, we may need to export things like default values. This creates the need for a shared dependency between a component and its test file(s). Do we want to establish a pattern for how to organize these types of files? Example

    Let's use separate module for component exports.

    Harry will create research issue about Stencil bug where doc generation doesn't pick up values set from an imported module. Harry will submit PR to update example component with this pattern.

  • Having the test hooks and the styling depend on the same classname creates a tight-coupling and makes our tests brittle. Can we explore some alternate options? The data-attribute pattern isn't well liked, other ideas? (id attributes? custom classnames only for tests?)

    Exporting CSS object as a lookup for tests is a good middle-ground.

    Will need to be wary of potential UI changes affecting tests

2019-06-21

  • Component dependency management
    • Stencil compiler has certain Bundling Restrictions
    • In order to prevent writing brittle tests, we may need to export things like default values. This creates the need for a shared dependency between a component and its test file(s). Do we want to establish a pattern for how to organize these types of files? Example
  • pound (#) or other symbols in branch names
    • I'm suggesting we avoid them. They appear escaped in the url and make the issue number more difficult to read. (-%2345) Agreed to drop # usage in Slack convo
  • Linting is now auto-fixed on commit (run npm i on the latest master for setup)

2019-06-15

  • List component (alan)
    • specs from design
    • May not work for layerlist nesting
  • Theming strategy (alan)
    • Concerns a little different than calcite-components
    • Don't have to do same as them as long as we don't conflict
    • App-comps will need a global approach to theming compared to calcite-comps (e.g., set on parent, and forget it)
    • Alan will start working this coming week

Questions

  • How to 'steal' an issue?

    If unassigned, grab and happy coding! If assigned with 0 - New or 1 - Assigned label. Ping assignee to relinquish issue.

  • Setting up GH pages?

    Harry is on it!

  • Issue priority process

    Depends on projects/milestones and whether it affects an external project.

2019-06-07

Discussion topics

  • ui-comps-js is deprecated ☠️
  • Moved over to the StencilJS-based calcite-app-comps (thanks Matt! 🙇)
    • Making progress: setting up some infrastructure and porting on components
    • Use issues/labels to explore upcoming components, progress, etc.
    • Need to figure out pattern for theming
      • Will create issue to sync-up w/ calcite-components to define how to do theming
  • Online Charts project is not using app-components at the moment
    • would use block and list filter?

Status

  • Matt is done with ActionBar, ActionPad and working on FlowManager. ActionPad will require specific-positioning props.
  • Franco started working on Block
  • Harry is working on Tip & TipManager

Questions

  • How to avoid name conflicts between calcite-components and calcite-app-components?

    • Design team will coordinate components.
    • We could automate testing having both side-by-side and catch errors early.

  • When a component's theme is changed, does it only affect color?

    Yes

2019-05-31

  • Prioritize calcite-components we will use that we can contribute to
  • New repo on GitHub ArcGIS.
    • Need to port this wiki
    • Need to assign issues
    • Setup i18n
  • Stencil.js issues?

2019-05-24

  • "automated" style guide? (alan)
  • i18n research status (Ganesh + Harry)

From last week:

  • @supports
    • CAN HAS? ლ(=ↀωↀ=)ლ

  • esri-ui-component gets set by all components

    • We are aware of this, and others are also becoming aware.

2019-05-17

  • Web Components (next steps)
    • prototype In progress! Will contribute to calcite-components.
  • Package versioning
    • Using semver would be ideal, but hard to associate across different projects. Franco will look into this more.
  • Kumar installed the demo auto runner 🎉
  • Need to explore options for consume component CSS. Requires research.

👇 Ran out of time, pushing to next week

  • @supports
    • CAN HAS? ლ(=ↀωↀ=)ლ

  • esri-ui-component gets set by all components

    • We are aware of this, and others are also becoming aware.

2019-05-10

  • Block (Alan)

    • suggest a headless block : @driscoll says "Why yes, old bean!" ಠ _ರೃ
    • can dev pass in their own node for a Block header?
      • at the moment, no.
      • making the head optional lets you write something that sits on top and talks to Block.

    Header can be used separately if needed and Block will make content required.

  • README entry about consuming components (Franco)

    Franco will update README with instructions on bringing ui-components as NPM package instead of a submodule. Also need to add info on how to set up in parent project if ui-component changes are planned

  • Process

    • design requirements

    Alan will draft a document on the design requirements before handing off to devs

    • better ways to identify in designs
      • existing component
      • enhancements to existing components
      • proposed components
      • component options/variations

    Look at charting component repo to use as an example for a component demo page.

  • Katy added component documentation on a branch - Matt will review

    • In the future, TSDoc can be used to automate doc generation (needs issue).

  • Will ui-components stay React or move as WC?

    • Base Web brought up as example.
    • Need to identify main consumers of ui-components
    • Will bring up in next week's dedicated discussion for this topic.

2019-05-03

  • FeatureFilter
    • Matt, Alan : meeting to try to use Block?
  • Testing framework research 37
    • Discuss findings
    • Decide what needs to be added/removed
    • Assign tasks (divvy up if necessary)
    • enzyme is likely the best candidate
    • concern about what if we change to something like stencyl.js, what will migration look like?
      • in this case, likely that we'd need to rewrite all the tests
    • desire to have good agnostic components
    • For now: keep testing to a minimum
    • Next steps
      • research other testing plugins
      • higher volume testing (Harry do it!)
      • alts for enzyme to test with stencyl

2019-04-19

  • FloatingPanel vs. This other thing
    • ? use a positioning "interface" that can be use by both FloatingPanel and ActionPad
    • review current design needs for this
  • React move status (Franco)
    • components now on React 🎉
    • next steps:
      • build tweaks (shared React bundle?)
      • fix outstanding animation quirk #62
  • FilterList status
    • converted to React
    • PR coming soon
    • demo
  • UIIcon (SVGIcon) status
    • demo
    • PR coming soon
  • Review i18n replacement criteria (Franco) - ✅
  • Chart components - React plans?
    • Kumar w/ comment on de-reduxification concerns (#54)
    • Will work on React move once 10.7.1 work is done

2019-04-12

  • Block
    • maybe switch what can be null, i.e. make the Header null?
  • Localization #47
    • use patterns for Intl that will work with/similar to Dojo
    • react.i18next
  • React move status (Franco)
    • Branch w/ all ui-components on React almost done (PR by F or M) - will assign to Matt, Praveen & Ganesh
    • Working on codemods to automate conversion (as much as possible)
      • Pending:
        • Optimizing bundle size
        • i18n switch
    • Styleguide (e.g. AirBnB)?
  • FilterList status (Franco)
    • remaining
      • tweak API a bit more PR coming

2019-04-05

  • Add: Russ and Katy to meeting
  • Switch - create
  • List of things
    • default list item
    • Franco & Alan meeting
    • "complex" selects <- could be solution for this.
  • Actually use React?
    • we could maybe do this.
    • pros/cons?
    • bundle sizes may be bigger but need to look at optimization
    • upshot: promising!
  • liaison Franco and Paul or Albers
  • Blocks! Should be merged soon

Quick Links

Resources

Clone this wiki locally