Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Enhancement: ValueList - Add ability to drag and drop with keyboard #356

Closed
asangma opened this issue Oct 9, 2019 · 5 comments
Closed
Assignees
Labels
4 - verified a11y enhancement New feature request for an existing component p - high

Comments

@asangma
Copy link
Contributor

asangma commented Oct 9, 2019

Summary

User should be able to tab into the drag handle, hit space, then use the up/down arrows to move items.

Actual Behavior

Can't tab into drag handle.

Expected Behavior

Be able to tab into drag handle.

Reproduction Steps

  1. demo page

Relevant Info

See how Bookmarks widget works in edit mode.

cc @driskull @kat10140

@asangma asangma added bug Something isn't working 1 - assigned p - high labels Oct 9, 2019
@asangma asangma added this to the Donny milestone Oct 9, 2019
@pr3tori4n
Copy link
Contributor

@driskull did you use sortable for the Bookmarks widget? If so can I scavenge the code you used to get that working - can you share a code snippet?

@driskull
Copy link
Member

Yes, its in the bookmarks view.

@pr3tori4n pr3tori4n added enhancement New feature request for an existing component and removed bug Something isn't working labels Nov 6, 2019
@pr3tori4n pr3tori4n changed the title Bug: ValueList - a11y. Can't tab into drag handle Enhancement: ValueList - Add ability to drag and drop with keyboard Nov 6, 2019
@pr3tori4n
Copy link
Contributor

Modifying this to be an enhancement issue, since its a request for additional functionality that wasn't present on first pass.

@pr3tori4n
Copy link
Contributor

@kat10140 please verify. Please double-check Edge and Safari.

@kat10140
Copy link
Contributor

works in Chrome, Firefox, Safari, Edge. Closing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4 - verified a11y enhancement New feature request for an existing component p - high
Projects
None yet
Development

No branches or pull requests

4 participants