jellyfish-transaction-signature

[ivan-zynesis]

What kind of PR is this?:

/kind refactor

What this PR does / why we need it:

To remove crypto dependencies from jellyfish-transaction
to become pure transaction object-buffer (de)composer

Which issue(s) does this PR fixes?:

Fixes #132
Meant to close 132 once merged

Additional comments?:

[qlty-cloud-legacy]

Code Climate has analyzed commit d2d4ee3 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

View more on Code Climate.

[netlify]

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 54e6c58

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60c03c5add206d0007149405

😎 Browse the preview: https://deploy-preview-359--jellyfish-defi.netlify.app

[fuxingloh]

Wait for #320

[ivan-zynesis]

Considered part of TransactionSegWit definition, moved to jellyfish-transaction/tx_segwit

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
packages/jellyfish/dist/index.umd.js	20.18 KB (0%)	404 ms (0%)	171 ms (-5.02% 🔽)	575 ms

[codecov]

Codecov Report

Merging #359 (54e6c58) into main (c2963de) will decrease coverage by 0.71%.
The diff coverage is 100.00%.

❗ Current head 54e6c58 differs from pull request most recent head d2d4ee3. Consider uploading reports for the commit d2d4ee3 to get more accurate results

@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
- Coverage   97.15%   96.44%   -0.72%     
==========================================
  Files          91       93       +2     
  Lines        2640     2645       +5     
  Branches      339      340       +1     
==========================================
- Hits         2565     2551      -14     
- Misses         75       94      +19     

Impacted Files	Coverage Δ
packages/jellyfish-transaction/src/index.ts	100.00% <ø> (ø)
...llyfish-transaction-builder/src/txn/txn_builder.ts	96.15% <100.00%> (+0.07%)	⬆️
...kages/jellyfish-transaction-signature/src/index.ts	97.29% <100.00%> (ø)
packages/jellyfish-transaction/src/tx_segwit.ts	41.37% <100.00%> (-58.63%)	⬇️
packages/jellyfish-wallet-mnemonic/src/mnemonic.ts	97.91% <100.00%> (+0.04%)	⬆️
packages/jellyfish-crypto/src/der.ts	92.30% <0.00%> (-3.85%)	⬇️
packages/jellyfish-crypto/src/bs58.ts	94.11% <0.00%> (-2.95%)	⬇️
packages/jellyfish-wallet/src/wallet_account.ts	100.00% <0.00%> (ø)
packages/jellyfish-transaction/src/script/index.ts	100.00% <0.00%> (ø)
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2963de...d2d4ee3. Read the comment docs.

[ivan-zynesis]

Replaced with #369