add condition in DBM MSSQL to check full mode + temp disable#2903
Merged
Conversation
vandonr
changed the title
vandonr
changed the title
robertomonteromiguel
approved these changes
Sep 5, 2024
cbeauchesne
reviewed
Sep 5, 2024
| span = self._get_db_span(request) | ||
|
|
||
| if span.get("meta", {}).get("db.type") == "sql-server": | ||
| # full mode for sql server is supported in dotnet (via the context_info) |
Collaborator
There was a problem hiding this comment.
The test logic is modified -> do not use [dotnet] in title 😉
cbeauchesne
changed the title
Collaborator
|
Rebasing to retrigger the CI |
mtoffl01
pushed a commit
that referenced
this pull request
Sep 11, 2024
* temp disable of test while we change the behavior in dotnet * use missing feature instead to have the test run --------- Co-authored-by: Charles de Beauchesne <charles.debeauchesne@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is the PR that will fix system tests after DataDog/dd-trace-dotnet#5859 is merged
Changes
We're adding support for full injection for MS SQL queries in dotnet. Thus, we need to assert that it's done in the system test.
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present