re-enable test now that change is merged on dotnet side#2984
Merged
Conversation
cbeauchesne
approved these changes
Sep 26, 2024
Collaborator
cbeauchesne
left a comment
cbeauchesne
left a comment
There was a problem hiding this comment.
Is your fix has been released ? I'm surprised to see that the test passes on your released lib? 🤔
Collaborator
DataDog/dd-trace-dotnet#5859 has been merged 3 weeks ago, the last dd-trace-dotnet release was one week ago -> this Pr is shipped inside the last release, so it's normal to have prod green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test was marked disabled in #2903
to make way for DataDog/dd-trace-dotnet#5859