Skip to content

add condition in DBM MSSQL to check full mode + temp disable #2903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vandonr merged 3 commits into from
Sep 5, 2024
Merged

add condition in DBM MSSQL to check full mode + temp disable #2903

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a820ac
temp disable of test while we change the behavior in dotnet
vandonr Sep 4, 2024
6da2070
use missing feature instead to have the test run
vandonr Sep 4, 2024
23b5d44
Merge branch 'main' into vandonr/sys
cbeauchesne Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tests/integrations/test_dbm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import json
import re

from utils import weblog, interfaces, context, scenarios, features, irrelevant, flaky
from utils import weblog, interfaces, context, scenarios, features, irrelevant, flaky, missing_feature
from utils.tools import logger


Expand Down Expand Up @@ -113,12 +113,17 @@ def test_trace_payload_service(self):
setup_trace_payload_full = weblog_trace_payload

@scenarios.integrations
@missing_feature(
context.library == "dotnet",
reason="temporary disable while we add support for DBM full mode for SQL Server in dotnet",
)
def test_trace_payload_full(self):
assert self.requests, "No requests to validate"
for request in self.requests:
span = self._get_db_span(request)

if span.get("meta", {}).get("db.type") == "sql-server":
# full mode for sql server is supported in dotnet (via the context_info)

@cbeauchesne cbeauchesne Sep 5, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test logic is modified -> do not use [dotnet] in title 😉

if self.library_name != "dotnet" and span.get("meta", {}).get("db.type") == "sql-server":
self._assert_span_is_untagged(span)
else:
self._assert_span_is_tagged(span)
Expand Down