v4.7.0 proposal #3382

Qard · 2023-07-11T21:15:05Z

Features

profiling: Adapt to new pprof-nodejs API ([profiling] Adapt to new pprof-nodejs API #3368)
iast: Report IAST metrics via telemetry (Report IAST metrics via telemetry #2805)
ci-visibility: Change test.type in browser tests ([ci-visibility] Change test.type in browser tests #3358)

Bug Fixes

ci-visibility: Intelligent test runner: only report skipped flag if tests were actually skipped ([ci-visibility] Intelligent test runner: only report skipped flag if tests were actually skipped #3369)
tracer: add dc store binding polyfill and migrate http2 (add dc store binding polyfill and migrate http2 #3284)
tracer: grpc: Convert grpc to use tracing channel (Convert grpc to use tracing channel #3366)
ci-visibility: validate CI tags before sending them (validate CI tags before sending them #3310)
tracer: express: recognize regex with flags (express: recognize regex with flags #3301)

github-actions · 2023-07-11T21:16:03Z

Overall package size

Self size: 4.87 MB
Deduped: 57.86 MB
No deduping: 57.95 MB

Dependency sizes

name	version	self size	total size
@datadog/native-iast-taint-tracking	1.5.0	14.86 MB	14.86 MB
@datadog/native-appsec	3.2.0	13.38 MB	13.39 MB
@datadog/pprof	3.0.0	10.54 MB	11.39 MB
protobufjs	7.2.4	2.74 MB	6.52 MB
@datadog/native-iast-rewriter	2.0.1	2.09 MB	2.1 MB
@opentelemetry/core	1.14.0	872.87 kB	1.47 MB
@datadog/native-metrics	2.0.0	898.77 kB	1.3 MB
@opentelemetry/api	1.4.1	780.32 kB	780.32 kB
msgpack-lite	0.1.26	201.16 kB	281.59 kB
opentracing	0.14.7	194.81 kB	194.81 kB
semver	7.5.3	93.39 kB	123.79 kB
@datadog/sketches-js	2.1.0	109.9 kB	109.9 kB
lodash.sortby	4.7.0	75.76 kB	75.76 kB
lru-cache	7.14.0	74.95 kB	74.95 kB
ipaddr.js	2.0.1	59.52 kB	59.52 kB
int64-buffer	0.1.10	49.18 kB	49.18 kB
ignore	5.2.0	48.87 kB	48.87 kB
import-in-the-middle	1.3.5	34.34 kB	38.81 kB
istanbul-lib-coverage	3.2.0	29.34 kB	29.34 kB
retry	0.10.1	27.44 kB	27.44 kB
lodash.uniq	4.5.0	25.01 kB	25.01 kB
limiter	1.1.5	23.17 kB	23.17 kB
lodash.kebabcase	4.1.1	17.75 kB	17.75 kB
lodash.pick	4.4.0	16.33 kB	16.33 kB
node-abort-controller	3.0.1	14.33 kB	14.33 kB
crypto-randomuuid	1.0.0	11.18 kB	11.18 kB
diagnostics_channel	1.1.0	7.07 kB	7.07 kB
path-to-regexp	0.1.7	6.78 kB	6.78 kB
koalas	1.0.2	6.47 kB	6.47 kB
methods	1.1.2	5.29 kB	5.29 kB
module-details-from-path	1.0.3	4.47 kB	4.47 kB

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

codecov · 2023-07-11T21:17:33Z

Codecov Report

❗ No coverage uploaded for pull request base (v4.x@e33a4ef). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2cc3f1b differs from pull request most recent head a8501f1. Consider uploading reports for the commit a8501f1 to get more accurate results

@@           Coverage Diff           @@
##             v4.x    #3382   +/-   ##
=======================================
  Coverage        ?   84.71%           
=======================================
  Files           ?      211           
  Lines           ?     8256           
  Branches        ?       33           
=======================================
  Hits            ?     6994           
  Misses          ?     1262           
  Partials        ?        0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

* add dc store binding polyfill and migrate http2 * fix error handling for synchronous exceptions * OutboundPlugin#tagPeerService() --------- Co-authored-by: Thomas Hunter II <[email protected]>

* ciapp-3571: add url validator * ciapp-3571: add url validator and change tests from ci-spec * fix variables to follow camelcase * Remove valid import Co-authored-by: Juan Antonio Fernández de Alba <[email protected]> * Remove unnecessary check Co-authored-by: Juan Antonio Fernández de Alba <[email protected]> * Remove unnecessary check for CI_PIPELINE_URL Co-authored-by: Juan Antonio Fernández de Alba <[email protected]> * Format typo Co-authored-by: Juan Antonio Fernández de Alba <[email protected]> * Use validateMetadata return directly Co-authored-by: Juan Antonio Fernández de Alba <[email protected]> * use new ci-spec JSONs * fix spacing and sort imports * add test to validateMetadata * Update JSONs and refactor URL checking * Update JSONs and refactor URL checking * Add URL validation tests * Apply suggestions from code review Co-authored-by: Juan Antonio Fernández de Alba <[email protected]> * Add tag to test suite --------- Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* Add framework type checking * Improve code readability Co-authored-by: Juan Antonio Fernández de Alba <[email protected]> * Fix imports * Fix styling Co-authored-by: Juan Antonio Fernández de Alba <[email protected]> * Add cypress and playwright tests * Change browser conditions to detect all playwright instances * Fix include string * Fix some suites still being reported as test type --------- Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs

…tests were actually skipped (#3369)

Co-authored-by: Ugaitz Urien <[email protected]>

* Convert grpc to use tracing channel * Allow addError to accept explicit span rather than delegating to activeSpan

pr-commenter · 2023-07-11T21:46:38Z

Benchmarks

Benchmark execution time: 2023-07-13 21:14:38

Comparing candidate commit 6bfd407 in PR branch v4.7.0-proposal with baseline commit e33a4ef in branch v4.x.

Found 37 performance improvements and 0 performance regressions! Performance is the same for 434 metrics, 21 unstable metrics.

scenario:appsec-iast-no-vulnerability-control-16

🟩 cpu_user_time [-146.691ms; -127.211ms] or [-24.441%; -21.196%]
🟩 execution_time [-181.006ms; -148.959ms] or [-23.848%; -19.625%]
🟩 instructions [+0G instructions; +0G instructions] or [-16.949%; -16.669%]
🟩 max_rss_usage [-7.752KB; -7.269KB] or [-11.002%; -10.316%]

scenario:appsec-iast-no-vulnerability-control-18

🟩 cpu_user_time [-147.853ms; -128.663ms] or [-23.742%; -20.660%]
🟩 execution_time [-163.308ms; -136.352ms] or [-21.611%; -18.043%]
🟩 instructions [+0G instructions; +0G instructions] or [-14.765%; -14.558%]
🟩 max_rss_usage [-8.415KB; -7.850KB] or [-10.375%; -9.679%]

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-16

🟩 instructions [+0G instructions; +0G instructions] or [-23.840%; -23.191%]

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-18

🟩 cpu_user_time [-0.188s; -0.162s] or [-16.303%; -14.037%]
🟩 execution_time [-0.217s; -0.178s] or [-16.749%; -13.733%]
🟩 instructions [+0G instructions; +0G instructions] or [-19.812%; -19.148%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-16

🟩 instructions [+0G instructions; +0G instructions] or [-19.668%; -18.637%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-18

🟩 cpu_user_time [-0.178s; -0.153s] or [-16.256%; -13.933%]
🟩 execution_time [-0.198s; -0.165s] or [-15.899%; -13.257%]
🟩 instructions [+0G instructions; +0G instructions] or [-14.587%; -13.410%]

scenario:appsec-iast-with-vulnerability-control-16

🟩 cpu_user_time [-0.374s; -0.334s] or [-33.376%; -29.828%]
🟩 execution_time [-0.590s; -0.515s] or [-35.932%; -31.343%]
🟩 instructions [+0G instructions; +0G instructions] or [-32.192%; -31.874%]

scenario:appsec-iast-with-vulnerability-control-18

🟩 cpu_user_time [-0.367s; -0.320s] or [-32.266%; -28.129%]
🟩 execution_time [-0.627s; -0.524s] or [-36.993%; -30.941%]
🟩 instructions [+0G instructions; +0G instructions] or [-32.043%; -31.715%]
🟩 max_rss_usage [-5.130KB; -4.493KB] or [-5.984%; -5.240%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-16

🟩 cpu_user_time [-0.519s; -0.358s] or [-12.521%; -8.624%]
🟩 execution_time [-0.923s; -0.685s] or [-18.299%; -13.591%]
🟩 instructions [-1G instructions; -1G instructions] or [-34.958%; -34.314%]
🟩 max_rss_usage [-12.644KB; -8.815KB] or [-10.229%; -7.131%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-18

🟩 cpu_user_time [-0.521s; -0.416s] or [-27.501%; -21.959%]
🟩 execution_time [-0.942s; -0.678s] or [-34.077%; -24.530%]
🟩 instructions [-1G instructions; -1G instructions] or [-35.003%; -34.453%]
🟩 max_rss_usage [-10.801KB; -7.607KB] or [-8.935%; -6.293%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-16

🟩 cpu_user_time [-0.505s; -0.437s] or [-12.546%; -10.868%]
🟩 execution_time [-0.872s; -0.663s] or [-18.107%; -13.764%]
🟩 instructions [-1G instructions; -1G instructions] or [-33.355%; -31.951%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-18

🟩 cpu_user_time [-0.450s; -0.376s] or [-26.369%; -22.054%]
🟩 execution_time [-0.814s; -0.603s] or [-32.778%; -24.292%]
🟩 instructions [-1G instructions; -1G instructions] or [-32.097%; -30.692%]

juan-fernandez

looks good from ci visibility's perspective. Only feedback is to change "civis" to ci-visibility in the release notes

Supplying a `DD_TRACE_PEER_SERVICE_MAPPING` allows users to modify the `peer.service` tag in the same manner that `DD_SERVICE_MAPPING` does for service name. If the `peer.service` value was matched by the mapping, the original value of the tag before remapping is reported in `_dd.peer.service.remapped_from`.

Qard added the semver-minor label Jul 11, 2023

Qard requested review from a team as code owners July 11, 2023 21:15

rochdev and others added 9 commits July 11, 2023 14:37

add dc store binding polyfill and migrate http2 (#3284)

6da7832

* add dc store binding polyfill and migrate http2 * fix error handling for synchronous exceptions * OutboundPlugin#tagPeerService() --------- Co-authored-by: Thomas Hunter II <[email protected]>

express: recognize regex with flags (#3301)

18955a1

dep: bump protobufjs to 7.2.4 (#3374)

f3d16b3

[profiling] Adapt to new pprof-nodejs API (#3368)

cc0312f

* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs

[ci-visibility] Intelligent test runner: only report skipped flag if …

87871d5

…tests were actually skipped (#3369)

Report IAST metrics via telemetry (#2805)

6453ea3

Co-authored-by: Ugaitz Urien <[email protected]>

Convert grpc to use tracing channel (#3366)

4814d1d

* Convert grpc to use tracing channel * Allow addError to accept explicit span rather than delegating to activeSpan

Qard force-pushed the v4.7.0-proposal branch from 1c094cf to 88c8239 Compare July 11, 2023 21:37

juan-fernandez previously approved these changes Jul 12, 2023

View reviewed changes

uurien previously approved these changes Jul 12, 2023

View reviewed changes

Drarig29 previously approved these changes Jul 12, 2023

View reviewed changes

tlhunter previously approved these changes Jul 13, 2023

View reviewed changes

tlhunter and others added 4 commits July 13, 2023 14:05

docs: add link to openai docs (#3381)

6c3a8f6

Reduce times in appsec-iast tests (#3354)

73825f1

benchmarks: add node 12, 14, 20, upgrade node 14, 16 (#3388)

2c88635

Qard dismissed stale reviews from tlhunter, Drarig29, uurien, and juan-fernandez via 6bfd407 July 13, 2023 21:06

Qard force-pushed the v4.7.0-proposal branch from 88c8239 to 6bfd407 Compare July 13, 2023 21:06

test v4.x against node 16, 18, 20 (#3391)

7c1a8ce

v4.7.0

a8501f1

tlhunter approved these changes Jul 14, 2023

View reviewed changes

Qard force-pushed the v4.7.0-proposal branch from 2cc3f1b to a8501f1 Compare July 14, 2023 00:23

tlhunter approved these changes Jul 14, 2023

View reviewed changes

uurien approved these changes Jul 14, 2023

View reviewed changes

Qard merged commit 23f9b8a into v4.x Jul 14, 2023

Qard deleted the v4.7.0-proposal branch July 14, 2023 16:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

v4.7.0 proposal #3382

v4.7.0 proposal #3382

Uh oh!

Qard commented Jul 11, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jul 11, 2023 •

edited

Loading

Uh oh!

codecov bot commented Jul 11, 2023 •

edited

Loading

Uh oh!

pr-commenter bot commented Jul 11, 2023 •

edited

Loading

Uh oh!

juan-fernandez left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

v4.7.0 proposal #3382

v4.7.0 proposal #3382

Uh oh!

Conversation

Qard commented Jul 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Features

Bug Fixes

Uh oh!

github-actions bot commented Jul 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overall package size

Dependency sizes

Uh oh!

codecov bot commented Jul 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pr-commenter bot commented Jul 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

scenario:appsec-iast-no-vulnerability-control-16

scenario:appsec-iast-no-vulnerability-control-18

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-16

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-18

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-16

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-18

scenario:appsec-iast-with-vulnerability-control-16

scenario:appsec-iast-with-vulnerability-control-18

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-16

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-18

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-16

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-18

Uh oh!

juan-fernandez left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Qard commented Jul 11, 2023 •

edited

Loading

github-actions bot commented Jul 11, 2023 •

edited

Loading

codecov bot commented Jul 11, 2023 •

edited

Loading

pr-commenter bot commented Jul 11, 2023 •

edited

Loading