validate CI tags before sending them #3310

ericlaz · 2023-06-29T10:16:48Z

What does this PR do?

Validate that URL tags are valid before sending them in order to prevent undefined errors

Motivation

Multiple undefined instances of CI span tags of Git Repo URL type specifically

github-actions · 2023-06-29T10:17:30Z

Overall package size

Self size: 4.81 MB
Deduped: 61.55 MB
No deduping: 61.64 MB

Dependency sizes

name	version	self size	total size
@datadog/pprof	2.2.3	14.25 MB	15.13 MB
@datadog/native-iast-taint-tracking	1.5.0	14.86 MB	14.86 MB
@datadog/native-appsec	3.2.0	13.38 MB	13.39 MB
protobufjs	7.1.2	2.76 MB	6.55 MB
@datadog/native-iast-rewriter	2.0.1	2.09 MB	2.1 MB
@opentelemetry/core	1.14.0	872.87 kB	1.47 MB
@datadog/native-metrics	2.0.0	898.77 kB	1.3 MB
@opentelemetry/api	1.4.1	780.32 kB	780.32 kB
msgpack-lite	0.1.26	201.16 kB	281.59 kB
opentracing	0.14.7	194.81 kB	194.81 kB
semver	7.5.3	93.39 kB	123.79 kB
@datadog/sketches-js	2.1.0	109.9 kB	109.9 kB
lodash.sortby	4.7.0	75.76 kB	75.76 kB
lru-cache	7.14.0	74.95 kB	74.95 kB
ipaddr.js	2.0.1	59.52 kB	59.52 kB
int64-buffer	0.1.10	49.18 kB	49.18 kB
ignore	5.2.0	48.87 kB	48.87 kB
import-in-the-middle	1.3.5	34.34 kB	38.81 kB
istanbul-lib-coverage	3.2.0	29.34 kB	29.34 kB
retry	0.10.1	27.44 kB	27.44 kB
lodash.uniq	4.5.0	25.01 kB	25.01 kB
limiter	1.1.5	23.17 kB	23.17 kB
lodash.kebabcase	4.1.1	17.75 kB	17.75 kB
lodash.pick	4.4.0	16.33 kB	16.33 kB
node-abort-controller	3.0.1	14.33 kB	14.33 kB
crypto-randomuuid	1.0.0	11.18 kB	11.18 kB
diagnostics_channel	1.1.0	7.07 kB	7.07 kB
path-to-regexp	0.1.7	6.78 kB	6.78 kB
koalas	1.0.2	6.47 kB	6.47 kB
methods	1.1.2	5.29 kB	5.29 kB
module-details-from-path	1.0.3	4.47 kB	4.47 kB

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

codecov · 2023-06-29T10:18:57Z

Codecov Report

Merging #3310 (7d8d26b) into master (a629586) will decrease coverage by 13.17%.
The diff coverage is 95.83%.

@@             Coverage Diff             @@
##           master    #3310       +/-   ##
===========================================
- Coverage   84.18%   71.01%   -13.17%     
===========================================
  Files         205      199        -6     
  Lines        8061     7608      -453     
  Branches       33       33               
===========================================
- Hits         6786     5403     -1383     
- Misses       1275     2205      +930

Impacted Files	Coverage Δ
packages/dd-trace/src/plugins/util/ci.js	`97.52% <0.00%> (ø)`
packages/dd-trace/src/plugins/util/test.js	`73.49% <100.00%> (+3.63%)`	⬆️
...ges/dd-trace/src/plugins/util/user-provided-git.js	`100.00% <100.00%> (+10.81%)`	⬆️

... and 53 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pr-commenter · 2023-06-29T10:52:15Z

Benchmarks

Comparing candidate commit d1c3bc0 in PR branch eric-navarro/remove-invalid-values with baseline commit a629586 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 465 metrics, 27 unstable metrics.

packages/dd-trace/src/plugins/util/test.js

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

packages/dd-trace/src/plugins/util/test.js

packages/dd-trace/src/plugins/util/ci.js

packages/dd-trace/src/plugins/util/test.js

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

…es' into eric-navarro/remove-invalid-values

juan-fernandez

looking good! Left some minor comments

packages/dd-trace/src/plugins/util/ci.js

packages/dd-trace/src/plugins/util/test.js

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

* ciapp-3571: add url validator * ciapp-3571: add url validator and change tests from ci-spec * fix variables to follow camelcase * Remove valid import Co-authored-by: Juan Antonio Fernández de Alba <[email protected]> * Remove unnecessary check Co-authored-by: Juan Antonio Fernández de Alba <[email protected]> * Remove unnecessary check for CI_PIPELINE_URL Co-authored-by: Juan Antonio Fernández de Alba <[email protected]> * Format typo Co-authored-by: Juan Antonio Fernández de Alba <[email protected]> * Use validateMetadata return directly Co-authored-by: Juan Antonio Fernández de Alba <[email protected]> * use new ci-spec JSONs * fix spacing and sort imports * add test to validateMetadata * Update JSONs and refactor URL checking * Update JSONs and refactor URL checking * Add URL validation tests * Apply suggestions from code review Co-authored-by: Juan Antonio Fernández de Alba <[email protected]> * Add tag to test suite --------- Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

ericlaz added 2 commits June 28, 2023 15:33

ciapp-3571: add url validator

7f03732

ciapp-3571: add url validator and change tests from ci-spec

04a41d2

ericlaz requested a review from a team as a code owner June 29, 2023 10:16

ericlaz changed the title ~~prevent CI tags before sending them~~ validate CI tags before sending them Jun 29, 2023

juan-fernandez self-requested a review June 29, 2023 10:31

juan-fernandez marked this pull request as draft June 29, 2023 10:32

fix variables to follow camelcase

b87cc2e

juan-fernandez reviewed Jun 29, 2023

View reviewed changes

packages/dd-trace/src/plugins/util/test.js Outdated Show resolved Hide resolved

packages/dd-trace/src/plugins/util/test.js Outdated Show resolved Hide resolved

Remove valid import

db34e53

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

juan-fernandez reviewed Jun 30, 2023

View reviewed changes

ericlaz added the semver-patch label Jun 30, 2023

ericlaz and others added 12 commits June 30, 2023 17:05

Remove unnecessary check

5215be7

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

Remove unnecessary check for CI_PIPELINE_URL

8e7d110

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

Format typo

2575f68

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

Use validateMetadata return directly

7337606

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

use new ci-spec JSONs

af16742

fix spacing and sort imports

6432d6b

Merge remote-tracking branch 'origin/eric-navarro/remove-invalid-valu…

cb99f24

…es' into eric-navarro/remove-invalid-values

add test to validateMetadata

4bbc0ab

Merge branch 'master' into eric-navarro/remove-invalid-values

ddc1805

Update JSONs and refactor URL checking

9a18950

Update JSONs and refactor URL checking

f879598

Add URL validation tests

e26e882

juan-fernandez added the ci-app label Jul 7, 2023

juan-fernandez reviewed Jul 7, 2023

View reviewed changes

packages/dd-trace/src/plugins/util/ci.js Outdated Show resolved Hide resolved

packages/dd-trace/src/plugins/util/test.js Outdated Show resolved Hide resolved

packages/dd-trace/src/plugins/util/test.js Outdated Show resolved Hide resolved

juan-fernandez and others added 2 commits July 7, 2023 10:29

Merge branch 'master' into eric-navarro/remove-invalid-values

fed7cb4

Apply suggestions from code review

d1c3bc0

Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>

Add tag to test suite

7d8d26b

juan-fernandez approved these changes Jul 7, 2023

View reviewed changes

juan-fernandez marked this pull request as ready for review July 7, 2023 15:20

ericlaz merged commit fc3d0ea into master Jul 10, 2023

ericlaz deleted the eric-navarro/remove-invalid-values branch July 10, 2023 08:45

This was referenced Jul 11, 2023

v4.7.0 proposal #3382

Merged

v3.28.0 proposal #3383

Merged

v2.41.0 proposal #3384

Merged

erikvanbrakel mentioned this pull request Jul 5, 2024

[DEVX-3565] add neo4j plugin for v4.41 mazedesignhq/dd-trace-js#15

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

validate CI tags before sending them #3310

validate CI tags before sending them #3310

Uh oh!

ericlaz commented Jun 29, 2023

Uh oh!

github-actions bot commented Jun 29, 2023 •

edited

Loading

Uh oh!

codecov bot commented Jun 29, 2023 •

edited

Loading

Uh oh!

pr-commenter bot commented Jun 29, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juan-fernandez left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

validate CI tags before sending them #3310

validate CI tags before sending them #3310

Uh oh!

Conversation

ericlaz commented Jun 29, 2023

What does this PR do?

Motivation

Uh oh!

github-actions bot commented Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overall package size

Dependency sizes

Uh oh!

codecov bot commented Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pr-commenter bot commented Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juan-fernandez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Jun 29, 2023 •

edited

Loading

codecov bot commented Jun 29, 2023 •

edited

Loading

pr-commenter bot commented Jun 29, 2023 •

edited

Loading