-
Notifications
You must be signed in to change notification settings - Fork 349
Report IAST metrics via telemetry #2805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52c3db6 to
682a706
Compare
Overall package sizeSelf size: 4.87 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #2805 +/- ##
==========================================
+ Coverage 84.09% 84.60% +0.51%
==========================================
Files 204 211 +7
Lines 8017 8252 +235
Branches 33 33
==========================================
+ Hits 6742 6982 +240
+ Misses 1275 1270 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
372327a to
7eae478
Compare
Qard
previously approved these changes
Mar 26, 2023
CarlesDD
reviewed
Mar 27, 2023
7eae478 to
f0f569f
Compare
CarlesDD
previously requested changes
Apr 3, 2023
b9db65a to
7999ca0
Compare
hoolioh
reviewed
Apr 17, 2023
hoolioh
reviewed
Apr 17, 2023
424d5be to
92d624b
Compare
CarlesDD
requested changes
Jul 5, 2023
packages/dd-trace/src/appsec/iast/taint-tracking/csi-methods.js
Outdated
Show resolved
Hide resolved
35e5e01 to
93aa8c7
Compare
CarlesDD
previously approved these changes
Jul 5, 2023
93aa8c7 to
1d0ce27
Compare
CarlesDD
approved these changes
Jul 11, 2023
Qard
pushed a commit
that referenced
this pull request
Jul 11, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
Qard
pushed a commit
that referenced
this pull request
Jul 11, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
Qard
pushed a commit
that referenced
this pull request
Jul 11, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
This was referenced Jul 11, 2023
Merged
Merged
Merged
Qard
pushed a commit
that referenced
this pull request
Jul 11, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
Qard
pushed a commit
that referenced
this pull request
Jul 11, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
Qard
pushed a commit
that referenced
this pull request
Jul 11, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
Qard
pushed a commit
that referenced
this pull request
Jul 14, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
Qard
pushed a commit
that referenced
this pull request
Jul 14, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
Qard
pushed a commit
that referenced
this pull request
Jul 14, 2023
Co-authored-by: Ugaitz Urien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the
DD_TELEMETRY_METRICS_ENABLEDenvironment variable is true, iast related information is recollected to send it to the backend.Here is information related related with the request, that is sent when the request ends, and other information is send as global metrics periodically.
Plugin Checklist
Additional Notes
Even if this is a large PR, the changes out of the appsec directory are few.
packages/dd-trace/src/config.js: To read newDD_TELEMETRY_METRICS_ENABLEDandDD_IAST_TELEMETRY_VERBOSITYconfigurations.packages/dd-trace/src/telemetry/metrics.js: Prevent sending namespace information when the namespace hasn't anything to send.