Skip to content

Conversation

@tlhunter
Copy link
Member

@tlhunter tlhunter commented Jun 27, 2023

What does this PR do?

  • when determining if an express route is a regex, ensure we work when modifier flags are set
  • so now we're just looking for the start of a regex pattern anywhere in the path (and not looking for an end)

Motivation

@tlhunter tlhunter requested a review from a team as a code owner June 27, 2023 23:00
@github-actions
Copy link

Overall package size

Self size: 4.69 MB
Deduped: 61.15 MB
No deduping: 61.2 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.3 14.25 MB 15.13 MB
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #3301 (c0541d3) into master (27e1530) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3301   +/-   ##
=======================================
  Coverage   85.88%   85.88%           
=======================================
  Files         199      199           
  Lines        7692     7692           
  Branches       33       33           
=======================================
  Hits         6606     6606           
  Misses       1086     1086           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Jun 27, 2023

Benchmarks

Comparing candidate commit c0541d3 in PR branch tlhunter/express-route-regex-flags with baseline commit 27e1530 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 467 metrics, 25 unstable metrics.

@tlhunter tlhunter requested a review from rochdev June 28, 2023 22:55
@tlhunter tlhunter merged commit a629586 into master Jul 6, 2023
@tlhunter tlhunter deleted the tlhunter/express-route-regex-flags branch July 6, 2023 23:23
@tommyksander
Copy link

thank you, @tlhunter!

Qard pushed a commit that referenced this pull request Jul 11, 2023
Qard pushed a commit that referenced this pull request Jul 11, 2023
Qard pushed a commit that referenced this pull request Jul 11, 2023
This was referenced Jul 11, 2023
Qard pushed a commit that referenced this pull request Jul 11, 2023
Qard pushed a commit that referenced this pull request Jul 11, 2023
Qard pushed a commit that referenced this pull request Jul 11, 2023
Qard pushed a commit that referenced this pull request Jul 14, 2023
Qard pushed a commit that referenced this pull request Jul 14, 2023
Qard pushed a commit that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regex matching doesn't account for case insensitivity pattern

3 participants