Add aix build tags and basic stubs by pgimalac · Pull Request #49052 · DataDog/datadog-agent

pgimalac · 2026-04-08T17:13:06Z

What does this PR do?

Add aix build tags and basic stubs.

Motivation

Initial PR for AIX support.

Describe how you validated your changes

Cherry picked from #47041, which has been tested manually.

Additional Notes

Follow-up PRs will add other missing pieces.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b15111561

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

agent-platform-auto-pr · 2026-04-08T17:37:16Z

Files inventory check summary

File checks results against ancestor 7852cc86:

Results for datadog-agent_7.79.0~devel.git.717.93b1ab9.pipeline.107572089-1_amd64.deb:

No change detected

agent-platform-auto-pr · 2026-04-08T17:45:55Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 273c0b6
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	docker_agent_amd64	-10.3 KiB (0.00% reduction)	813.606 → 813.596 → 815.700
✅	docker_agent_arm64	-10.8 KiB (0.00% reduction)	816.790 → 816.780 → 821.970
✅	docker_agent_jmx_amd64	-10.3 KiB (0.00% reduction)	1004.522 → 1004.512 → 1006.580
✅	docker_agent_jmx_arm64	-10.79 KiB (0.00% reduction)	996.484 → 996.474 → 1001.570

27 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	753.334 MiB
✅	agent_deb_amd64_fips	710.238 MiB
✅	agent_heroku_amd64	313.474 MiB
✅	agent_msi	605.253 MiB
✅	agent_rpm_amd64	753.318 MiB
✅	agent_rpm_amd64_fips	710.222 MiB
✅	agent_rpm_arm64	731.700 MiB
✅	agent_rpm_arm64_fips	691.664 MiB
✅	agent_suse_amd64	753.318 MiB
✅	agent_suse_amd64_fips	710.222 MiB
✅	agent_suse_arm64	731.700 MiB
✅	agent_suse_arm64_fips	691.664 MiB
✅	docker_cluster_agent_amd64	204.112 MiB
✅	docker_cluster_agent_arm64	218.547 MiB
✅	docker_cws_instrumentation_amd64	7.142 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	39.270 MiB
✅	docker_dogstatsd_arm64	37.507 MiB
✅	dogstatsd_deb_amd64	29.917 MiB
✅	dogstatsd_deb_arm64	28.066 MiB
✅	dogstatsd_rpm_amd64	29.917 MiB
✅	dogstatsd_suse_amd64	29.917 MiB
✅	iot_agent_deb_amd64	43.304 MiB
✅	iot_agent_deb_arm64	40.351 MiB
✅	iot_agent_deb_armhf	41.099 MiB
✅	iot_agent_rpm_amd64	43.305 MiB
✅	iot_agent_suse_amd64	43.305 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	-5.11 KiB (0.00% reduction)	174.815 → 174.810 → 178.360
✅	agent_deb_amd64_fips	-47.57 KiB (0.03% reduction)	165.453 → 165.407 → 172.790
✅	agent_heroku_amd64	neutral	75.046 MiB → 79.970
✅	agent_msi	+8.0 KiB (0.01% increase)	138.492 → 138.500 → 146.220
✅	agent_rpm_amd64	+5.27 KiB (0.00% increase)	177.624 → 177.629 → 181.830
✅	agent_rpm_amd64_fips	+3.38 KiB (0.00% increase)	167.744 → 167.747 → 173.370
✅	agent_rpm_arm64	-34.82 KiB (0.02% reduction)	159.612 → 159.578 → 163.060
✅	agent_rpm_arm64_fips	-35.11 KiB (0.02% reduction)	151.496 → 151.462 → 156.170
✅	agent_suse_amd64	+5.27 KiB (0.00% increase)	177.624 → 177.629 → 181.830
✅	agent_suse_amd64_fips	+3.38 KiB (0.00% increase)	167.744 → 167.747 → 173.370
✅	agent_suse_arm64	-34.82 KiB (0.02% reduction)	159.612 → 159.578 → 163.060
✅	agent_suse_arm64_fips	-35.11 KiB (0.02% reduction)	151.496 → 151.462 → 156.170
✅	docker_agent_amd64	neutral	268.274 MiB → 272.480
✅	docker_agent_arm64	+5.01 KiB (0.00% increase)	255.456 → 255.461 → 261.060
✅	docker_agent_jmx_amd64	+9.12 KiB (0.00% increase)	336.922 → 336.931 → 341.100
✅	docker_agent_jmx_arm64	-9.3 KiB (0.00% reduction)	320.091 → 320.082 → 325.620
✅	docker_cluster_agent_amd64	+6.53 KiB (0.01% increase)	71.420 → 71.427 → 72.920
✅	docker_cluster_agent_arm64	-6.67 KiB (0.01% reduction)	67.051 → 67.045 → 68.220
✅	docker_cws_instrumentation_amd64	neutral	2.999 MiB → 3.330
✅	docker_cws_instrumentation_arm64	neutral	2.729 MiB → 3.090
✅	docker_dogstatsd_amd64	neutral	15.180 MiB → 15.820
✅	docker_dogstatsd_arm64	neutral	14.506 MiB → 14.830
✅	dogstatsd_deb_amd64	-2.18 KiB (0.03% reduction)	7.901 → 7.899 → 8.790
✅	dogstatsd_deb_arm64	neutral	6.784 MiB → 7.710
✅	dogstatsd_rpm_amd64	neutral	7.912 MiB → 8.800
✅	dogstatsd_suse_amd64	neutral	7.912 MiB → 8.800
✅	iot_agent_deb_amd64	neutral	11.410 MiB → 13.040
✅	iot_agent_deb_arm64	neutral	9.729 MiB → 11.450
✅	iot_agent_deb_armhf	neutral	9.946 MiB → 11.620
✅	iot_agent_rpm_amd64	-3.61 KiB (0.03% reduction)	11.429 → 11.426 → 13.060
✅	iot_agent_suse_amd64	-3.61 KiB (0.03% reduction)	11.429 → 11.426 → 13.060

cit-pr-commenter-54b7da · 2026-04-08T17:58:15Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b58a8852-9ca7-4d51-a85e-0d5220bb8a29

Baseline: 33c6e07
Comparison: 5592cad
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-3.70	[-6.72, -0.69]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_idle	memory utilization	+0.38	[+0.33, +0.43]	1	Logs bounds checks dashboard
➖	ddot_logs	memory utilization	+0.36	[+0.29, +0.43]	1	Logs
➖	ddot_metrics	memory utilization	+0.27	[+0.08, +0.46]	1	Logs
➖	file_tree	memory utilization	+0.25	[+0.20, +0.31]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.17	[-0.05, +0.40]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.08	[-0.02, +0.19]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.07	[-0.43, +0.58]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.04	[-0.40, +0.49]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.02	[-0.11, +0.14]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.20, +0.21]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.11, +0.11]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.01	[-0.21, +0.18]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.03	[-0.20, +0.14]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.04	[-0.44, +0.35]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.09	[-0.24, +0.05]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.11	[-0.27, +0.05]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.22	[-0.38, -0.06]	1	Logs
➖	docker_containers_memory	memory utilization	-0.24	[-0.33, -0.16]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.27	[-0.30, -0.24]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	-0.34	[-0.57, -0.11]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.35	[-0.40, -0.29]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.93	[-2.56, +0.70]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	-3.70	[-6.72, -0.69]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	707 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	277.21MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	699 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.23GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.22GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
❌	quality_gate_idle	intake_connections	0/10	4 > 3	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	177.45MiB ≤ 181MiB	bounds checks dashboard
❌	quality_gate_idle_all_features	intake_connections	1/10	4 > 3	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	497.79MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	210.28MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	368.87 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	420.19MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 1/10 replicas passed. Failed 9 which is > 0. Gate FAILED.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 0/10 replicas passed. Failed 10 which is > 0. Gate FAILED.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

rdesgroppes · 2026-04-08T18:14:24Z

I will therefore close:

Remove inactive AIX-specific implementation from pkg/trace/watchdog #45122.

chouquette

LGTM for the BUILD.bazel change, which I assume was gazelle generated

### What does this PR do? Add AIX support to `pkg/collector/python` and `rtloader`: - Split `#cgo !windows` LDFLAGS into `#cgo !aix,!windows` and `#cgo aix` variants across all Python C binding files, so that AIX does not link `libdatadog-agent-rtloader` via the generic non-Windows path - Add `pkg/collector/python/python_aix.go` to force `libpython3.13.so` into the XCOFF startup-load chain at process startup, making Python API symbols globally visible to C extension modules - Add AIX `#define DATADOG_AGENT_THREE` in `rtloader/rtloader/api.cpp` - Replace C++11 designated initializer for `stack_t` in `rtloader/rtloader/api.cpp` with explicit field assignments (AIX GCC does not support designated initializers in C++ mode) ### Motivation Follow-up to #49052. Cherry-picked from #47041. ### Describe how you validated your changes Cherry-picked from #47041, which has been tested manually on AIX. ### Additional Notes Co-authored-by: pierre.gimalac <pierre.gimalac@datadoghq.com>

### What does this PR do? Add live process monitoring support for AIX: - Add `pkg/process/procutil/process_aix.go`: implements the `Probe` interface by reading `/proc/<pid>/psinfo` directly (world-readable 448-byte binary, no elevated privileges required). The psinfo struct layout is vendored from the DataDog/gopsutil fork — there is no `DataDog/gopsutil` import. - Add `pkg/process/checks/system_info_aix.go`: `CollectSystemInfo` implementation for AIX via gopsutil v4. - Guard `fp.Stats.CtxSwitches` and `fp.CtxSwitches` nil dereferences in `process.go` and `process_rt.go` (AIX does not provide context switch data). - Exclude AIX from the generic `process_fallback.go` and the Linux-specific `system_info.go`. ### Motivation Follow-up to #49052 and #49108. Cherry-picked and adapted from #47041. ### Describe how you validated your changes Cherry-picked from #47041, which has been tested manually on AIX. ### Additional Notes The process collection logic was originally added in the `DataDog/gopsutil` fork. Since that fork is no longer used, the logic has been vendored directly into the agent. I'm working on upstreaming the logic to shirou/gopsutil but it's still WIP shirou/gopsutil#2028 Co-authored-by: pierre.gimalac <pierre.gimalac@datadoghq.com>

feat: add aix build tags and basic stubs

9b15111

pgimalac requested a review from a team as a code owner April 8, 2026 17:13

pgimalac added the changelog/no-changelog No changelog entry needed label Apr 8, 2026

pgimalac requested review from a team as code owners April 8, 2026 17:13

pgimalac added the qa/done QA done before merge and regressions are covered by tests label Apr 8, 2026

pgimalac requested a review from a team as a code owner April 8, 2026 17:13

pgimalac added the team/agent-runtimes label Apr 8, 2026

pgimalac requested review from TCheruy, fabbing and rahulkaukuntla April 8, 2026 17:13

dd-octo-sts Bot added internal Identify a non-fork PR team/agent-configuration team/network-device-monitoring-core team/ebpf-platform labels Apr 8, 2026

github-actions Bot added the long review PR is complex, plan time to review it label Apr 8, 2026

chatgpt-codex-connector Bot reviewed Apr 8, 2026

View reviewed changes

Comment thread comp/metadata/host/hostimpl/payload.go

rdesgroppes mentioned this pull request Apr 8, 2026

Remove inactive AIX-specific implementation from pkg/trace/watchdog #45122

Closed

brycekahle reviewed Apr 8, 2026

View reviewed changes

Comment thread pkg/system-probe/config/config_nix_no_ebpf.go Outdated

brycekahle reviewed Apr 8, 2026

View reviewed changes

Comment thread pkg/system-probe/config/config_nix_no_ebpf.go

TCheruy approved these changes Apr 9, 2026

View reviewed changes

pgimalac mentioned this pull request Apr 9, 2026

AIX: add collector/python CGO flags and rtloader changes #49108

Merged

rahulkaukuntla approved these changes Apr 9, 2026

View reviewed changes

pgimalac mentioned this pull request Apr 10, 2026

AIX: add live process monitoring #49162

Merged

fabbing approved these changes Apr 10, 2026

View reviewed changes

rename config_no_ebpf.go to config_nix_no_ebpf.go

a065389

pgimalac added 2 commits April 13, 2026 17:47

Merge branch 'main' into pgimalac/aix-basics-go

a6b11b9

fix: bazel gazelle

78a562e

pgimalac requested a review from a team as a code owner April 14, 2026 09:05

dd-octo-sts Bot added the team/agent-build label Apr 14, 2026

chouquette approved these changes Apr 14, 2026

View reviewed changes

rdesgroppes approved these changes Apr 14, 2026

View reviewed changes

pgimalac added 2 commits April 14, 2026 09:27

chore: update system-probe config build tags fox aix

213a8d4

Merge branch 'main' into pgimalac/aix-basics-go

854994a

fix: bazel gazelle

93b1ab9

brycekahle approved these changes Apr 14, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d Bot merged commit 5592cad into main Apr 14, 2026
276 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the pgimalac/aix-basics-go branch April 14, 2026 21:26

github-actions Bot added this to the 7.79.0 milestone Apr 14, 2026

Navigation Menu

Uh oh!

Add aix build tags and basic stubs - #49052

Add aix build tags and basic stubs#49052
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits into
mainfrom
pgimalac/aix-basics-go

pgimalac commented Apr 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

agent-platform-auto-pr Bot commented Apr 8, 2026 •

edited by dd-octo-sts Bot

Loading

Uh oh!

agent-platform-auto-pr Bot commented Apr 8, 2026 •

edited

Loading

Info

Uh oh!

cit-pr-commenter-54b7da Bot commented Apr 8, 2026 •

edited

Loading

Experiments ignored for regressions

Fine details of change detection per experiment

Explanation

Uh oh!

rdesgroppes commented Apr 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

chouquette left a comment •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

pgimalac commented Apr 8, 2026

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

agent-platform-auto-pr Bot commented Apr 8, 2026 • edited by dd-octo-sts Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Files inventory check summary

Results for datadog-agent_7.79.0~devel.git.717.93b1ab9.pipeline.107572089-1_amd64.deb:

Uh oh!

agent-platform-auto-pr Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

cit-pr-commenter-54b7da Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

Uh oh!

rdesgroppes commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chouquette left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

agent-platform-auto-pr Bot commented Apr 8, 2026 •

edited by dd-octo-sts Bot

Loading

agent-platform-auto-pr Bot commented Apr 8, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Apr 8, 2026 •

edited

Loading

rdesgroppes commented Apr 8, 2026 •

edited

Loading

chouquette left a comment •

edited

Loading