Skip to content

Remove inactive AIX-specific implementation from pkg/trace/watchdog - #45122

Closed
rdesgroppes wants to merge 1 commit into
mainfrom
regis.desgroppes/remove-limited-aix-support
Closed

Remove inactive AIX-specific implementation from pkg/trace/watchdog#45122
rdesgroppes wants to merge 1 commit into
mainfrom
regis.desgroppes/remove-limited-aix-support

Conversation

@rdesgroppes

@rdesgroppes rdesgroppes commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

This change removes inactive AIX-specific implementation code from the pkg/trace/watchdog module, as well as a few AIX-related TODOs from build scripts.

Motivation

Decrease the number of Go build tags (here: aix) to help transition the agent's build from omnibus (invoke, etc.) to bazel.

Describe how you validated your changes

This removal should be safe because:

Additional Notes

This removal can be quickly found (git log -S aix) and partially reverted if support for AIX were to be officially switched from datadog-unix-agent to the present repository.

@rdesgroppes rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Jan 15, 2026
@github-actions github-actions Bot added team/agent-runtimes medium review PR review might take time labels Jan 15, 2026
@rdesgroppes
rdesgroppes marked this pull request as ready for review January 15, 2026 09:36
@rdesgroppes
rdesgroppes requested review from a team as code owners January 15, 2026 09:36
@chouetz chouetz added the ask-review Ask in slack required teams to review this PR label Jan 15, 2026

@fabbing fabbing left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the detailed description!

@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor aedf76a
📊 Static Quality Gates Dashboard

31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 705.273 MiB
agent_deb_amd64_fips 700.550 MiB
agent_heroku_amd64 326.916 MiB
agent_msi 571.534 MiB
agent_rpm_amd64 705.259 MiB
agent_rpm_amd64_fips 700.537 MiB
agent_rpm_arm64 686.832 MiB
agent_rpm_arm64_fips 682.938 MiB
agent_suse_amd64 705.259 MiB
agent_suse_amd64_fips 700.537 MiB
agent_suse_arm64 686.832 MiB
agent_suse_arm64_fips 682.938 MiB
docker_agent_amd64 767.468 MiB
docker_agent_arm64 773.619 MiB
docker_agent_jmx_amd64 958.347 MiB
docker_agent_jmx_arm64 953.217 MiB
docker_cluster_agent_amd64 180.715 MiB
docker_cluster_agent_arm64 196.557 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.808 MiB
docker_dogstatsd_arm64 37.128 MiB
dogstatsd_deb_amd64 30.027 MiB
dogstatsd_deb_arm64 28.176 MiB
dogstatsd_rpm_amd64 30.027 MiB
dogstatsd_suse_amd64 30.027 MiB
iot_agent_deb_amd64 42.987 MiB
iot_agent_deb_arm64 40.112 MiB
iot_agent_deb_armhf 40.689 MiB
iot_agent_rpm_amd64 42.987 MiB
iot_agent_suse_amd64 42.987 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -10.37 KiB (0.01% reduction) 173.326 → 173.316 → 174.490
agent_deb_amd64_fips +28.54 KiB (0.02% increase) 172.203 → 172.231 → 173.750
agent_heroku_amd64 -4.52 KiB (0.01% reduction) 87.123 → 87.119 → 88.450
agent_msi -4.0 KiB (0.00% reduction) 142.930 → 142.926 → 143.020
agent_rpm_amd64 -75.12 KiB (0.04% reduction) 176.187 → 176.113 → 177.660
agent_rpm_amd64_fips +3.79 KiB (0.00% increase) 174.948 → 174.951 → 176.600
agent_rpm_arm64 +33.64 KiB (0.02% increase) 159.316 → 159.349 → 161.260
agent_rpm_arm64_fips +31.85 KiB (0.02% increase) 158.751 → 158.782 → 160.550
agent_suse_amd64 -75.12 KiB (0.04% reduction) 176.187 → 176.113 → 177.660
agent_suse_amd64_fips +3.79 KiB (0.00% increase) 174.948 → 174.951 → 176.600
agent_suse_arm64 +33.64 KiB (0.02% increase) 159.316 → 159.349 → 161.260
agent_suse_arm64_fips +31.85 KiB (0.02% increase) 158.751 → 158.782 → 160.550
docker_agent_amd64 +4.61 KiB (0.00% increase) 261.029 → 261.033 → 262.450
docker_agent_arm64 -8.83 KiB (0.00% reduction) 250.056 → 250.047 → 252.630
docker_agent_jmx_amd64 +4.28 KiB (0.00% increase) 329.670 → 329.674 → 331.080
docker_agent_jmx_arm64 +6.92 KiB (0.00% increase) 314.671 → 314.678 → 317.270
docker_cluster_agent_amd64 neutral 63.835 MiB
docker_cluster_agent_arm64 neutral 60.121 MiB
docker_cws_instrumentation_amd64 neutral 2.994 MiB
docker_cws_instrumentation_arm64 neutral 2.726 MiB
docker_dogstatsd_amd64 neutral 15.026 MiB
docker_dogstatsd_arm64 neutral 14.354 MiB
dogstatsd_deb_amd64 neutral 7.945 MiB
dogstatsd_deb_arm64 neutral 6.823 MiB
dogstatsd_rpm_amd64 neutral 7.956 MiB
dogstatsd_suse_amd64 neutral 7.956 MiB
iot_agent_deb_amd64 neutral 11.258 MiB
iot_agent_deb_arm64 neutral 9.632 MiB
iot_agent_deb_armhf neutral 9.823 MiB
iot_agent_rpm_amd64 neutral 11.277 MiB
iot_agent_suse_amd64 neutral 11.277 MiB

@cit-pr-commenter

cit-pr-commenter Bot commented Jan 15, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2e2a4257-a13e-49a0-bb63-318c56b81d3e

Baseline: 624d2a6
Comparison: 6bcba6f
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +3.39 [+0.38, +6.39] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +3.39 [+0.38, +6.39] 1 Logs
ddot_metrics memory utilization +1.45 [+1.23, +1.67] 1 Logs
docker_containers_memory memory utilization +1.32 [+1.16, +1.47] 1 Logs
quality_gate_logs % cpu utilization +0.59 [-0.89, +2.07] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.54 [+0.32, +0.77] 1 Logs
otlp_ingest_metrics memory utilization +0.24 [+0.08, +0.40] 1 Logs
otlp_ingest_logs memory utilization +0.18 [+0.07, +0.30] 1 Logs
file_tree memory utilization +0.06 [+0.00, +0.11] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.04 [-0.35, +0.43] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.02 [-0.12, +0.15] 1 Logs
quality_gate_idle_all_features memory utilization +0.01 [-0.03, +0.05] 1 Logs bounds checks dashboard
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.09, +0.10] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.00 [-0.41, +0.41] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.13, +0.13] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.52, +0.51] 1 Logs
quality_gate_idle memory utilization -0.01 [-0.06, +0.03] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -0.05 [-0.26, +0.17] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput -0.06 [-0.10, -0.02] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.20 [-0.25, -0.15] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.34 [-0.50, -0.18] 1 Logs
ddot_logs memory utilization -0.34 [-0.41, -0.28] 1 Logs
ddot_metrics_sum_delta memory utilization -0.62 [-0.83, -0.42] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.70 [-1.79, -1.61] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 9/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (target internal profiling)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 11 (x3) Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 11 (x3) Oom killed Debug Dashboard

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@rdesgroppes
rdesgroppes force-pushed the regis.desgroppes/remove-limited-aix-support branch from a327939 to 5ca310d Compare January 15, 2026 10:47
This change removes AIX-specific implementation code from the
`pkg/trace/watchdog module`.

This removal should be safe because:
- AIX builds were never configured in CI (contrarily to Linux, macOS
  and Windows),
- as per https://docs.datadoghq.com/agent/supported_platforms/aix/,
  AIX is officially supported via the separate `datadog-unix-agent`
  repository (https://github.com/DataDog/datadog-unix-agent, active as
  of December 2025),
- `dd-trace-go` (only external consumer I found) doesn't import
  `pkg/trace/watchdog`
  (https://github.com/search?q=repo%3ADataDog%2Fdd-trace-go+github.com%2FDataDog%2Fdatadog-agent%2Fpkg%2Ftrace%2F&type=code)
  nor supports AIX,
- in August 2025, #40116 documented in AGENTS.md:
  > AIX: No support in this codebase
- In November 2025, #43420 stated:
  > We are not currently building for AIX
@rdesgroppes
rdesgroppes force-pushed the regis.desgroppes/remove-limited-aix-support branch from 5ca310d to 6bcba6f Compare January 15, 2026 15:51
@aiuto

aiuto commented Jan 15, 2026

Copy link
Copy Markdown
Collaborator

I'm not sure we should be removing AIX hints. There are some rumblings about AIX, from one particularly large customer.

@rdesgroppes

Copy link
Copy Markdown
Contributor Author

Closing due to:

@rdesgroppes rdesgroppes closed this Apr 8, 2026
@rdesgroppes
rdesgroppes deleted the regis.desgroppes/remove-limited-aix-support branch April 8, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask in slack required teams to review this PR changelog/no-changelog No changelog entry needed medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-runtimes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants