[WIP][AGENTRUN-1076] Support building for AIX ppc64 - #47041
Conversation
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
On-wire sizes (compressed)
|
…pgimalac/aix-support
Files inventory check summaryFile checks results against ancestor fdf4c61f: Results for datadog-agent_7.78.0~devel.git.541.8118f41.pipeline.103546882-1_amd64.deb:No change detected |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: fdf4c61 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +0.82 | [-2.20, +3.85] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +0.82 | [-2.20, +3.85] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.81 | [+0.57, +1.04] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | +0.55 | [+0.49, +0.60] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.37 | [+0.23, +0.52] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.37 | [+0.27, +0.48] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.32 | [+0.15, +0.49] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.21 | [+0.17, +0.25] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.19 | [+0.13, +0.24] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.15 | [-0.01, +0.31] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.08 | [+0.02, +0.14] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.06 | [-0.17, +0.28] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.05 | [-0.44, +0.54] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.04 | [-0.38, +0.47] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.02 | [-0.03, +0.07] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.17, +0.18] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.00 | [-0.19, +0.18] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.13, +0.10] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.02 | [-0.41, +0.37] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.04 | [-0.12, +0.04] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.16 | [-0.26, -0.05] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.22 | [-0.39, -0.05] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.39 | [-0.46, -0.32] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.75 | [-2.29, +0.78] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 704 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 276.90MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 708 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.22GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 174.46MiB ≤ 175MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 495.24MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 204.96MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 369.95 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 407.58MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
Cherry-picked and adapted from #47041. Process collection logic previously in the DataDog/gopsutil fork has been vendored directly into pkg/process/procutil/process_aix.go, reading /proc/<pid>/psinfo without any dependency on DataDog/gopsutil.
### What does this PR do? Add AIX support to `pkg/collector/python` and `rtloader`: - Split `#cgo !windows` LDFLAGS into `#cgo !aix,!windows` and `#cgo aix` variants across all Python C binding files, so that AIX does not link `libdatadog-agent-rtloader` via the generic non-Windows path - Add `pkg/collector/python/python_aix.go` to force `libpython3.13.so` into the XCOFF startup-load chain at process startup, making Python API symbols globally visible to C extension modules - Add AIX `#define DATADOG_AGENT_THREE` in `rtloader/rtloader/api.cpp` - Replace C++11 designated initializer for `stack_t` in `rtloader/rtloader/api.cpp` with explicit field assignments (AIX GCC does not support designated initializers in C++ mode) ### Motivation Follow-up to #49052. Cherry-picked from #47041. ### Describe how you validated your changes Cherry-picked from #47041, which has been tested manually on AIX. ### Additional Notes Co-authored-by: pierre.gimalac <pierre.gimalac@datadoghq.com>
### What does this PR do? Add AIX support to `pkg/collector/python` and `rtloader`: - Split `#cgo !windows` LDFLAGS into `#cgo !aix,!windows` and `#cgo aix` variants across all Python C binding files, so that AIX does not link `libdatadog-agent-rtloader` via the generic non-Windows path - Add `pkg/collector/python/python_aix.go` to force `libpython3.13.so` into the XCOFF startup-load chain at process startup, making Python API symbols globally visible to C extension modules - Add AIX `#define DATADOG_AGENT_THREE` in `rtloader/rtloader/api.cpp` - Replace C++11 designated initializer for `stack_t` in `rtloader/rtloader/api.cpp` with explicit field assignments (AIX GCC does not support designated initializers in C++ mode) ### Motivation Follow-up to #49052. Cherry-picked from #47041. ### Describe how you validated your changes Cherry-picked from #47041, which has been tested manually on AIX. ### Additional Notes Co-authored-by: pierre.gimalac <pierre.gimalac@datadoghq.com>
### What does this PR do? Add aix build tags and basic stubs. ### Motivation Initial PR for AIX support. ### Describe how you validated your changes Cherry picked from #47041, which has been tested manually. ### Additional Notes Follow-up PRs will add other missing pieces. Co-authored-by: pierre.gimalac <pierre.gimalac@datadoghq.com>
### What does this PR do? Add live process monitoring support for AIX: - Add `pkg/process/procutil/process_aix.go`: implements the `Probe` interface by reading `/proc/<pid>/psinfo` directly (world-readable 448-byte binary, no elevated privileges required). The psinfo struct layout is vendored from the DataDog/gopsutil fork — there is no `DataDog/gopsutil` import. - Add `pkg/process/checks/system_info_aix.go`: `CollectSystemInfo` implementation for AIX via gopsutil v4. - Guard `fp.Stats.CtxSwitches` and `fp.CtxSwitches` nil dereferences in `process.go` and `process_rt.go` (AIX does not provide context switch data). - Exclude AIX from the generic `process_fallback.go` and the Linux-specific `system_info.go`. ### Motivation Follow-up to #49052 and #49108. Cherry-picked and adapted from #47041. ### Describe how you validated your changes Cherry-picked from #47041, which has been tested manually on AIX. ### Additional Notes The process collection logic was originally added in the `DataDog/gopsutil` fork. Since that fork is no longer used, the logic has been vendored directly into the agent. I'm working on upstreaming the logic to shirou/gopsutil but it's still WIP shirou/gopsutil#2028 Co-authored-by: pierre.gimalac <pierre.gimalac@datadoghq.com>
|
Split in many small PRs |
What does this PR do?
Support building the datadog-agent on AIX powerpc64.
Motivation
See how feasible it is.
Describe how you validated your changes
A lot of manual running the builds.
Additional Notes
This is an experiment.
Don't look too much at code changes at this point, the goal is just to ensure it builds and runs properly.