Skip to content

[WIP][AGENTRUN-1076] Support building for AIX ppc64 - #47041

Closed
pgimalac wants to merge 24 commits into
mainfrom
pgimalac/aix-support
Closed

[WIP][AGENTRUN-1076] Support building for AIX ppc64#47041
pgimalac wants to merge 24 commits into
mainfrom
pgimalac/aix-support

Conversation

@pgimalac

Copy link
Copy Markdown
Member

What does this PR do?

Support building the datadog-agent on AIX powerpc64.

Motivation

See how feasible it is.

Describe how you validated your changes

A lot of manual running the builds.

Additional Notes

This is an experiment.
Don't look too much at code changes at this point, the goal is just to ensure it builds and runs properly.

@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor fdf4c61
📊 Static Quality Gates Dashboard
🔗 SQG Job
SOME SIZE DELTAS ARE N/A (ANCESTOR METRICS NOT YET AVAILABLE). RETRY JOB

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 N/A N/A → 746.875 → 750.720
agent_deb_amd64_fips N/A N/A → 705.203 → 711.230
agent_heroku_amd64 N/A N/A → 311.742 → 320.580
agent_msi N/A N/A → 609.816 → 1062.520
agent_rpm_amd64 N/A N/A → 746.859 → 750.690
agent_rpm_amd64_fips N/A N/A → 705.187 → 711.210
agent_rpm_arm64 N/A N/A → 724.732 → 732.890
agent_rpm_arm64_fips N/A N/A → 686.077 → 694.440
agent_suse_amd64 N/A N/A → 746.859 → 750.690
agent_suse_amd64_fips N/A N/A → 705.187 → 711.210
agent_suse_arm64 N/A N/A → 724.732 → 732.890
agent_suse_arm64_fips N/A N/A → 686.077 → 694.440
docker_agent_amd64 N/A N/A → 807.197 → 813.040
docker_agent_arm64 N/A N/A → 809.876 → 819.570
docker_agent_jmx_amd64 N/A N/A → 998.113 → 1003.920
docker_agent_jmx_arm64 N/A N/A → 989.570 → 999.170
docker_cluster_agent_amd64 N/A N/A → 203.668 → 206.270
docker_cluster_agent_arm64 N/A N/A → 218.103 → 220.000
docker_cws_instrumentation_amd64 N/A N/A → 7.138 → 7.180
docker_cws_instrumentation_arm64 N/A N/A → 6.689 → 6.920
docker_dogstatsd_amd64 N/A N/A → 38.631 → 39.380
docker_dogstatsd_arm64 N/A N/A → 36.939 → 37.940
dogstatsd_deb_amd64 N/A N/A → 29.859 → 30.610
dogstatsd_deb_arm64 N/A N/A → 28.008 → 29.110
dogstatsd_rpm_amd64 N/A N/A → 29.859 → 30.610
dogstatsd_suse_amd64 N/A N/A → 29.859 → 30.610
iot_agent_deb_amd64 N/A N/A → 43.068 → 43.290
iot_agent_deb_arm64 N/A N/A → 40.131 → 40.920
iot_agent_deb_armhf N/A N/A → 40.874 → 41.030
iot_agent_rpm_amd64 N/A N/A → 43.069 → 43.290
iot_agent_suse_amd64 N/A N/A → 43.069 → 43.290
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 N/A N/A → 174.442 → 177.700
agent_deb_amd64_fips N/A N/A → 165.384 → 172.230
agent_heroku_amd64 N/A N/A → 75.172 → 79.970
agent_msi N/A N/A → 138.039 → 146.220
agent_rpm_amd64 N/A N/A → 176.446 → 180.780
agent_rpm_amd64_fips N/A N/A → 168.109 → 173.370
agent_rpm_arm64 N/A N/A → 159.283 → 161.610
agent_rpm_arm64_fips N/A N/A → 151.411 → 155.910
agent_suse_amd64 N/A N/A → 176.446 → 180.780
agent_suse_amd64_fips N/A N/A → 168.109 → 173.370
agent_suse_arm64 N/A N/A → 159.283 → 161.610
agent_suse_arm64_fips N/A N/A → 151.411 → 155.910
docker_agent_amd64 N/A N/A → 267.121 → 271.240
docker_agent_arm64 N/A N/A → 254.442 → 259.800
docker_agent_jmx_amd64 N/A N/A → 335.771 → 339.870
docker_agent_jmx_arm64 N/A N/A → 319.072 → 324.390
docker_cluster_agent_amd64 N/A N/A → 71.286 → 72.920
docker_cluster_agent_arm64 N/A N/A → 66.925 → 68.220
docker_cws_instrumentation_amd64 N/A N/A → 2.997 → 3.330
docker_cws_instrumentation_arm64 N/A N/A → 2.728 → 3.090
docker_dogstatsd_amd64 N/A N/A → 14.949 → 15.820
docker_dogstatsd_arm64 N/A N/A → 14.282 → 14.830
dogstatsd_deb_amd64 N/A N/A → 7.890 → 8.790
dogstatsd_deb_arm64 N/A N/A → 6.772 → 7.710
dogstatsd_rpm_amd64 N/A N/A → 7.900 → 8.800
dogstatsd_suse_amd64 N/A N/A → 7.900 → 8.800
iot_agent_deb_amd64 N/A N/A → 11.355 → 12.040
iot_agent_deb_arm64 N/A N/A → 9.667 → 10.450
iot_agent_deb_armhf N/A N/A → 9.899 → 10.620
iot_agent_rpm_amd64 N/A N/A → 11.371 → 12.060
iot_agent_suse_amd64 N/A N/A → 11.371 → 12.060

@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor fdf4c61f:

Results for datadog-agent_7.78.0~devel.git.541.8118f41.pipeline.103546882-1_amd64.deb:

No change detected

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d991dfc4-11ae-4b08-8506-13a7facb6c02

Baseline: fdf4c61
Comparison: ccbb163
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.82 [-2.20, +3.85] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.82 [-2.20, +3.85] 1 Logs
quality_gate_metrics_logs memory utilization +0.81 [+0.57, +1.04] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.55 [+0.49, +0.60] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization +0.37 [+0.23, +0.52] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.37 [+0.27, +0.48] 1 Logs
ddot_metrics_sum_delta memory utilization +0.32 [+0.15, +0.49] 1 Logs
quality_gate_idle_all_features memory utilization +0.21 [+0.17, +0.25] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.19 [+0.13, +0.24] 1 Logs
otlp_ingest_metrics memory utilization +0.15 [-0.01, +0.31] 1 Logs
ddot_logs memory utilization +0.08 [+0.02, +0.14] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.06 [-0.17, +0.28] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.44, +0.54] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.04 [-0.38, +0.47] 1 Logs
file_tree memory utilization +0.02 [-0.03, +0.07] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.17, +0.18] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.19, +0.18] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.13, +0.10] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.41, +0.37] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.04 [-0.12, +0.04] 1 Logs
otlp_ingest_logs memory utilization -0.16 [-0.26, -0.05] 1 Logs
ddot_metrics memory utilization -0.22 [-0.39, -0.05] 1 Logs
docker_containers_memory memory utilization -0.39 [-0.46, -0.32] 1 Logs
quality_gate_logs % cpu utilization -0.75 [-2.29, +0.78] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 704 ≥ 26
docker_containers_memory memory_usage 10/10 276.90MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 708 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.22GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle memory_usage 10/10 174.46MiB ≤ 175MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 495.24MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 204.96MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 369.95 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 407.58MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.

pgimalac added a commit that referenced this pull request Apr 10, 2026
Cherry-picked and adapted from #47041.

Process collection logic previously in the DataDog/gopsutil fork has been
vendored directly into pkg/process/procutil/process_aix.go, reading
/proc/<pid>/psinfo without any dependency on DataDog/gopsutil.
gh-worker-dd-mergequeue-cf854d Bot pushed a commit that referenced this pull request Apr 14, 2026
### What does this PR do?
Add AIX support to `pkg/collector/python` and `rtloader`:
- Split `#cgo !windows` LDFLAGS into `#cgo !aix,!windows` and `#cgo aix` variants across all Python C binding files, so that AIX does not link `libdatadog-agent-rtloader` via the generic non-Windows path
- Add `pkg/collector/python/python_aix.go` to force `libpython3.13.so` into the XCOFF startup-load chain at process startup, making Python API symbols globally visible to C extension modules
- Add AIX `#define DATADOG_AGENT_THREE` in `rtloader/rtloader/api.cpp`
- Replace C++11 designated initializer for `stack_t` in `rtloader/rtloader/api.cpp` with explicit field assignments (AIX GCC does not support designated initializers in C++ mode)

### Motivation
Follow-up to #49052. Cherry-picked from #47041.

### Describe how you validated your changes
Cherry-picked from #47041, which has been tested manually on AIX.

### Additional Notes

Co-authored-by: pierre.gimalac <pierre.gimalac@datadoghq.com>
aiuto pushed a commit that referenced this pull request Apr 14, 2026
### What does this PR do?
Add AIX support to `pkg/collector/python` and `rtloader`:
- Split `#cgo !windows` LDFLAGS into `#cgo !aix,!windows` and `#cgo aix` variants across all Python C binding files, so that AIX does not link `libdatadog-agent-rtloader` via the generic non-Windows path
- Add `pkg/collector/python/python_aix.go` to force `libpython3.13.so` into the XCOFF startup-load chain at process startup, making Python API symbols globally visible to C extension modules
- Add AIX `#define DATADOG_AGENT_THREE` in `rtloader/rtloader/api.cpp`
- Replace C++11 designated initializer for `stack_t` in `rtloader/rtloader/api.cpp` with explicit field assignments (AIX GCC does not support designated initializers in C++ mode)

### Motivation
Follow-up to #49052. Cherry-picked from #47041.

### Describe how you validated your changes
Cherry-picked from #47041, which has been tested manually on AIX.

### Additional Notes

Co-authored-by: pierre.gimalac <pierre.gimalac@datadoghq.com>
gh-worker-dd-mergequeue-cf854d Bot pushed a commit that referenced this pull request Apr 14, 2026
### What does this PR do?
Add aix build tags and basic stubs.

### Motivation
Initial PR for AIX support.

### Describe how you validated your changes
Cherry picked from #47041, which has been tested manually.

### Additional Notes
Follow-up PRs will add other missing pieces.

Co-authored-by: pierre.gimalac <pierre.gimalac@datadoghq.com>
gh-worker-dd-mergequeue-cf854d Bot pushed a commit that referenced this pull request Apr 16, 2026
### What does this PR do?
Add live process monitoring support for AIX:
- Add `pkg/process/procutil/process_aix.go`: implements the `Probe` interface by reading `/proc/<pid>/psinfo` directly (world-readable 448-byte binary, no elevated privileges required). The psinfo struct layout is vendored from the DataDog/gopsutil fork — there is no `DataDog/gopsutil` import.
- Add `pkg/process/checks/system_info_aix.go`: `CollectSystemInfo` implementation for AIX via gopsutil v4.
- Guard `fp.Stats.CtxSwitches` and `fp.CtxSwitches` nil dereferences in `process.go` and `process_rt.go` (AIX does not provide context switch data).
- Exclude AIX from the generic `process_fallback.go` and the Linux-specific `system_info.go`.

### Motivation
Follow-up to #49052 and #49108. Cherry-picked and adapted from #47041.

### Describe how you validated your changes
Cherry-picked from #47041, which has been tested manually on AIX.

### Additional Notes
The process collection logic was originally added in the `DataDog/gopsutil` fork. Since that fork is no longer used, the logic has been vendored directly into the agent.
I'm working on upstreaming the logic to shirou/gopsutil but it's still WIP shirou/gopsutil#2028

Co-authored-by: pierre.gimalac <pierre.gimalac@datadoghq.com>
@pgimalac

Copy link
Copy Markdown
Member Author

Split in many small PRs

@pgimalac pgimalac closed this Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant