AIX: add collector/python CGO flags and rtloader changes by pgimalac · Pull Request #49108 · DataDog/datadog-agent

pgimalac · 2026-04-09T11:22:37Z

What does this PR do?

Add AIX support to pkg/collector/python and rtloader:

Split #cgo !windows LDFLAGS into #cgo !aix,!windows and #cgo aix variants across all Python C binding files, so that AIX does not link libdatadog-agent-rtloader via the generic non-Windows path
Add pkg/collector/python/python_aix.go to force libpython3.13.so into the XCOFF startup-load chain at process startup, making Python API symbols globally visible to C extension modules
Add AIX #define DATADOG_AGENT_THREE in rtloader/rtloader/api.cpp
Replace C++11 designated initializer for stack_t in rtloader/rtloader/api.cpp with explicit field assignments (AIX GCC does not support designated initializers in C++ mode)

Motivation

Follow-up to #49052. Cherry-picked from #47041.

Describe how you validated your changes

Cherry-picked from #47041, which has been tested manually on AIX.

Additional Notes

agent-platform-auto-pr · 2026-04-09T11:45:36Z

Files inventory check summary

File checks results against ancestor f9c77438:

Results for datadog-agent_7.79.0~devel.git.677.ec1b744.pipeline.107421845-1_amd64.deb:

No change detected

agent-platform-auto-pr · 2026-04-09T11:56:24Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor f9c7743
📊 Static Quality Gates Dashboard
🔗 SQG Job

31 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	742.637 MiB
✅	agent_deb_amd64_fips	699.369 MiB
✅	agent_heroku_amd64	310.425 MiB
✅	agent_msi	605.599 MiB
✅	agent_rpm_amd64	742.621 MiB
✅	agent_rpm_amd64_fips	699.353 MiB
✅	agent_rpm_arm64	720.743 MiB
✅	agent_rpm_arm64_fips	680.546 MiB
✅	agent_suse_amd64	742.621 MiB
✅	agent_suse_amd64_fips	699.353 MiB
✅	agent_suse_arm64	720.743 MiB
✅	agent_suse_arm64_fips	680.546 MiB
✅	docker_agent_amd64	802.884 MiB
✅	docker_agent_arm64	805.823 MiB
✅	docker_agent_jmx_amd64	993.799 MiB
✅	docker_agent_jmx_arm64	985.517 MiB
✅	docker_cluster_agent_amd64	205.507 MiB
✅	docker_cluster_agent_arm64	219.789 MiB
✅	docker_cws_instrumentation_amd64	7.142 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	39.488 MiB
✅	docker_dogstatsd_arm64	37.703 MiB
✅	dogstatsd_deb_amd64	30.136 MiB
✅	dogstatsd_deb_arm64	28.277 MiB
✅	dogstatsd_rpm_amd64	30.136 MiB
✅	dogstatsd_suse_amd64	30.136 MiB
✅	iot_agent_deb_amd64	44.074 MiB
✅	iot_agent_deb_arm64	41.082 MiB
✅	iot_agent_deb_armhf	41.810 MiB
✅	iot_agent_rpm_amd64	44.075 MiB
✅	iot_agent_suse_amd64	44.075 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	-34.24 KiB (0.02% reduction)	175.175 → 175.142 → 179.160
✅	agent_deb_amd64_fips	+80.24 KiB (0.05% increase)	166.678 → 166.756 → 174.440
✅	agent_heroku_amd64	-2.13 KiB (0.00% reduction)	74.894 → 74.892 → 80.310
✅	agent_msi	-12.0 KiB (0.01% reduction)	139.258 → 139.246 → 147.550
✅	agent_rpm_amd64	+7.71 KiB (0.00% increase)	177.157 → 177.164 → 182.080
✅	agent_rpm_amd64_fips	-45.57 KiB (0.03% reduction)	168.145 → 168.101 → 174.140
✅	agent_rpm_arm64	+5.48 KiB (0.00% increase)	159.509 → 159.514 → 163.610
✅	agent_rpm_arm64_fips	+29.05 KiB (0.02% increase)	151.443 → 151.472 → 156.850
✅	agent_suse_amd64	+7.71 KiB (0.00% increase)	177.157 → 177.164 → 182.080
✅	agent_suse_amd64_fips	-45.57 KiB (0.03% reduction)	168.145 → 168.101 → 174.140
✅	agent_suse_arm64	+5.48 KiB (0.00% increase)	159.509 → 159.514 → 163.610
✅	agent_suse_arm64_fips	+29.05 KiB (0.02% increase)	151.443 → 151.472 → 156.850
✅	docker_agent_amd64	neutral	267.796 MiB → 272.990
✅	docker_agent_arm64	+5.38 KiB (0.00% increase)	254.847 → 254.852 → 261.470
✅	docker_agent_jmx_amd64	+6.3 KiB (0.00% increase)	336.437 → 336.443 → 341.610
✅	docker_agent_jmx_arm64	+3.65 KiB (0.00% increase)	319.483 → 319.486 → 326.050
✅	docker_cluster_agent_amd64	neutral	71.997 MiB → 73.460
✅	docker_cluster_agent_arm64	neutral	67.523 MiB → 68.680
✅	docker_cws_instrumentation_amd64	neutral	2.999 MiB → 3.330
✅	docker_cws_instrumentation_arm64	neutral	2.729 MiB → 3.090
✅	docker_dogstatsd_amd64	neutral	15.256 MiB → 15.870
✅	docker_dogstatsd_arm64	neutral	14.575 MiB → 14.890
✅	dogstatsd_deb_amd64	neutral	7.951 MiB → 8.830
✅	dogstatsd_deb_arm64	neutral	6.834 MiB → 7.750
✅	dogstatsd_rpm_amd64	neutral	7.963 MiB → 8.840
✅	dogstatsd_suse_amd64	neutral	7.963 MiB → 8.840
✅	iot_agent_deb_amd64	+2.2 KiB (0.02% increase)	11.608 → 11.610 → 13.210
✅	iot_agent_deb_arm64	neutral	9.921 MiB → 11.620
✅	iot_agent_deb_armhf	neutral	10.124 MiB → 11.780
✅	iot_agent_rpm_amd64	neutral	11.624 MiB → 13.230
✅	iot_agent_suse_amd64	neutral	11.624 MiB → 13.230

cit-pr-commenter-54b7da · 2026-04-09T12:07:40Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c9c0647a-381c-4f4b-9b4e-49a07ff983f9

Baseline: 7852cc8
Comparison: 28660ba
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+1.35	[-1.67, +4.38]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+1.35	[-1.67, +4.38]	1	Logs
➖	docker_containers_memory	memory utilization	+0.71	[+0.62, +0.79]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.63	[+0.40, +0.85]	1	Logs
➖	file_tree	memory utilization	+0.50	[+0.45, +0.55]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	+0.45	[+0.21, +0.68]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulative	memory utilization	+0.41	[+0.27, +0.55]	1	Logs
➖	ddot_metrics	memory utilization	+0.10	[-0.08, +0.28]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.04	[-0.07, +0.15]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.02	[-0.37, +0.42]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.12, +0.11]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.21, +0.20]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.01	[-0.22, +0.19]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.02	[-0.46, +0.42]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.02	[-0.53, +0.49]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.02	[-0.20, +0.15]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.02	[-0.18, +0.13]	1	Logs
➖	quality_gate_idle	memory utilization	-0.17	[-0.23, -0.12]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-0.28	[-0.45, -0.11]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.28	[-0.34, -0.22]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.32	[-0.36, -0.29]	1	Logs bounds checks dashboard
➖	ddot_logs	memory utilization	-0.35	[-0.43, -0.28]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.75	[-0.86, -0.64]	1	Logs
➖	quality_gate_logs	% cpu utilization	-2.44	[-4.05, -0.84]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	685 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	280.20MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	694 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.24GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.21GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 = 3	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	175.27MiB ≤ 181MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 = 3	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	496.79MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	205.99MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	351.61 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	405.60MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

pgimalac · 2026-04-09T13:21:20Z

-            stack_t new_stack{ .ss_sp = alt_stack, .ss_flags = 0, .ss_size = alt_stack_size };
+            stack_t new_stack;
+            memset(&new_stack, 0, sizeof(new_stack));
+            new_stack.ss_sp = (decltype(new_stack.ss_sp))alt_stack;
+            new_stack.ss_size = alt_stack_size;
+            new_stack.ss_flags = 0;


The fields are not ordered the same way on AIX and Linux, and some types also change, so this is a simple way to fix that without having to use macros

jose-manuel-almaza · 2026-04-10T07:26:12Z

The root AGENTS.md currently states under Platform Support:

AIX: No support in this codebase

This PR clearly adds AIX support. That line should be updated (either in this PR or as a tracked follow-up).

pgimalac · 2026-04-10T09:27:23Z

For the AIX support this PR only adds some of the changes needed, I'd rather update that once we properly support it

### What does this PR do? Add AIX support to `pkg/collector/python` and `rtloader`: - Split `#cgo !windows` LDFLAGS into `#cgo !aix,!windows` and `#cgo aix` variants across all Python C binding files, so that AIX does not link `libdatadog-agent-rtloader` via the generic non-Windows path - Add `pkg/collector/python/python_aix.go` to force `libpython3.13.so` into the XCOFF startup-load chain at process startup, making Python API symbols globally visible to C extension modules - Add AIX `#define DATADOG_AGENT_THREE` in `rtloader/rtloader/api.cpp` - Replace C++11 designated initializer for `stack_t` in `rtloader/rtloader/api.cpp` with explicit field assignments (AIX GCC does not support designated initializers in C++ mode) ### Motivation Follow-up to #49052. Cherry-picked from #47041. ### Describe how you validated your changes Cherry-picked from #47041, which has been tested manually on AIX. ### Additional Notes Co-authored-by: pierre.gimalac <pierre.gimalac@datadoghq.com>

### What does this PR do? Add live process monitoring support for AIX: - Add `pkg/process/procutil/process_aix.go`: implements the `Probe` interface by reading `/proc/<pid>/psinfo` directly (world-readable 448-byte binary, no elevated privileges required). The psinfo struct layout is vendored from the DataDog/gopsutil fork — there is no `DataDog/gopsutil` import. - Add `pkg/process/checks/system_info_aix.go`: `CollectSystemInfo` implementation for AIX via gopsutil v4. - Guard `fp.Stats.CtxSwitches` and `fp.CtxSwitches` nil dereferences in `process.go` and `process_rt.go` (AIX does not provide context switch data). - Exclude AIX from the generic `process_fallback.go` and the Linux-specific `system_info.go`. ### Motivation Follow-up to #49052 and #49108. Cherry-picked and adapted from #47041. ### Describe how you validated your changes Cherry-picked from #47041, which has been tested manually on AIX. ### Additional Notes The process collection logic was originally added in the `DataDog/gopsutil` fork. Since that fork is no longer used, the logic has been vendored directly into the agent. I'm working on upstreaming the logic to shirou/gopsutil but it's still WIP shirou/gopsutil#2028 Co-authored-by: pierre.gimalac <pierre.gimalac@datadoghq.com>

pgimalac added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-runtimes internal Identify a non-fork PR labels Apr 9, 2026

pgimalac requested a review from a team as a code owner April 9, 2026 11:22

pgimalac added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests labels Apr 9, 2026

pgimalac requested a review from jose-manuel-almaza April 9, 2026 11:22

pgimalac added short review PR is simple enough to be reviewed quickly team/agent-runtimes internal Identify a non-fork PR labels Apr 9, 2026

github-actions Bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Apr 9, 2026

pgimalac commented Apr 9, 2026

View reviewed changes

jose-manuel-almaza reviewed Apr 10, 2026

View reviewed changes

Comment thread pkg/collector/python/python_aix.go Outdated

jose-manuel-almaza reviewed Apr 10, 2026

View reviewed changes

Comment thread pkg/collector/python/init.go

jose-manuel-almaza reviewed Apr 10, 2026

View reviewed changes

Comment thread rtloader/rtloader/api.cpp Outdated

pgimalac mentioned this pull request Apr 10, 2026

AIX: add live process monitoring #49162

Merged

AIX: add collector/python CGO flags and rtloader changes

43e5972

pgimalac force-pushed the pgimalac/aix-collector-python branch from 041ed3d to 43e5972 Compare April 13, 2026 16:28

github-actions Bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Apr 13, 2026

fix: restore changes from other PRs inadvertently reverted

4ccda6a

github-actions Bot removed the long review PR is complex, plan time to review it label Apr 13, 2026

github-actions Bot added the medium review PR review might take time label Apr 13, 2026

pgimalac added 3 commits April 13, 2026 16:38

fix: restore provider_str in three.h

5da3877

fix: remove build script reference from init.go comment

4f55fbb

fix: clean up python_aix.go comment

ec1b744

jose-manuel-almaza approved these changes Apr 14, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d Bot merged commit 28660ba into main Apr 14, 2026
263 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the pgimalac/aix-collector-python branch April 14, 2026 12:29

github-actions Bot added this to the 7.79.0 milestone Apr 14, 2026

Navigation Menu

Uh oh!

AIX: add collector/python CGO flags and rtloader changes - #49108

AIX: add collector/python CGO flags and rtloader changes#49108
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits into
mainfrom
pgimalac/aix-collector-python

pgimalac commented Apr 9, 2026

Uh oh!

agent-platform-auto-pr Bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

agent-platform-auto-pr Bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

cit-pr-commenter-54b7da Bot commented Apr 9, 2026 •

edited

Loading

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

pgimalac Apr 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jose-manuel-almaza commented Apr 10, 2026

Uh oh!

pgimalac commented Apr 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

pgimalac commented Apr 9, 2026

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

Uh oh!

agent-platform-auto-pr Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Files inventory check summary

Results for datadog-agent_7.79.0~devel.git.677.ec1b744.pipeline.107421845-1_amd64.deb:

Uh oh!

agent-platform-auto-pr Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Uh oh!

cit-pr-commenter-54b7da Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

pgimalac Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jose-manuel-almaza commented Apr 10, 2026

Uh oh!

pgimalac commented Apr 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

agent-platform-auto-pr Bot commented Apr 9, 2026 •

edited

Loading

agent-platform-auto-pr Bot commented Apr 9, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Apr 9, 2026 •

edited

Loading