[ABLD-180] Remove omnibus m4. - #43420
Conversation
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 716b81c Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +2.68 | [-0.31, +5.66] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +2.68 | [-0.31, +5.66] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +0.66 | [-0.81, +2.14] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | +0.37 | [+0.32, +0.41] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.35 | [+0.11, +0.59] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.25 | [+0.09, +0.40] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.24 | [+0.19, +0.29] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.18 | [+0.13, +0.23] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | +0.10 | [-0.01, +0.20] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.04 | [-0.00, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.03 | [-0.39, +0.45] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.02 | [-0.35, +0.40] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.02 | [-0.11, +0.14] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.13, +0.14] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.07, +0.07] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.06 | [-0.46, +0.34] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.19 | [-0.27, -0.11] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.24 | [-0.45, -0.04] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.47 | [-0.56, -0.38] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.52 | [-0.57, -0.47] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.59 | [-0.73, -0.45] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.78 | [-1.00, -0.57] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.22 | [-1.33, -1.10] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -1.51 | [-1.72, -1.30] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
alopezz
left a comment
There was a problem hiding this comment.
What's more, there's no dependency "m4" or the like in any omnibus files. So this looks like good cleanup.
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
Gitlab pipeline didn't start... Please retry. you can get help from #ci-infra-support Error: gitlab pipeline not started |
|
/ddci trigger |
|
View all feedbacks in Devflow UI.
✅ Tasks request sent successfully. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Gitlab pipeline didn't start... Please retry. you can get help from #ci-infra-support Error: gitlab pipeline not started |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
Gitlab pipeline didn't start... Please retry. you can get help from #ci-infra-support Error: gitlab pipeline not started |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
Gitlab pipeline didn't start... Please retry. you can get help from #ci-infra-support Error: gitlab pipeline not started |
We don't actually use m4 in the product. For the AIX build of libtool, we expect m4 to be present, but it is fine to remove this now. - We are not currently building for AIX - We are moving away from needing libtool, so this this part of the graph is disappearing.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Gitlab pipeline didn't start... Please retry. you can get help from #ci-infra-support Error: gitlab pipeline not started |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Gitlab pipeline didn't start... Please retry. you can get help from #ci-infra-support Error: gitlab pipeline not started |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
This change removes AIX-specific implementation code from the `pkg/trace/watchdog module`. This removal should be safe because: - AIX builds were never configured in CI (contrarily to Linux, macOS and Windows), - as per https://docs.datadoghq.com/agent/supported_platforms/aix/, AIX is officially supported via the separate `datadog-unix-agent` repository (https://github.com/DataDog/datadog-unix-agent, active as of December 2025), - `dd-trace-go` (only external consumer I found) doesn't import `pkg/trace/watchdog` (https://github.com/search?q=repo%3ADataDog%2Fdd-trace-go+github.com%2FDataDog%2Fdatadog-agent%2Fpkg%2Ftrace%2F&type=code) nor supports AIX, - in August 2025, #40116 documented in AGENTS.md: > AIX: No support in this codebase - In November 2025, #43420 stated: > We are not currently building for AIX
We don't actually use m4 in the product.
For the AIX build of libtool, we expect m4 to be present, but it is fine to remove this now.
Analysis
The first shows no uses of m4. The second shows no references to libtool outside of libtool.
RUN_E2E_TESTS=on