Skip to content

[ABLD-180] Remove omnibus m4. - #43420

Merged
dd-mergequeue[bot] merged 2 commits into
mainfrom
aiuto/m4
Nov 26, 2025
Merged

[ABLD-180] Remove omnibus m4.#43420
dd-mergequeue[bot] merged 2 commits into
mainfrom
aiuto/m4

Conversation

@aiuto

@aiuto aiuto commented Nov 24, 2025

Copy link
Copy Markdown
Collaborator

We don't actually use m4 in the product.

For the AIX build of libtool, we expect m4 to be present, but it is fine to remove this now.

  • We are not currently building for AIX
  • We are moving away from needing libtool, so this this part of the graph is disappearing.

Analysis

  • Take the .deb package, un-tar it and look around
$ find . | grep m4
./embedded/share/libtool/aclocal.m4

$ grep -r libtool . | grep -v libtoolize | grep -v /libtool[/:]
./version-manifest.json:    "libtool": {
./version-manifest.json:        "libtool"
./version-manifest.json:        "libtool",
./version-manifest.txt:libtool                                       2.4.7                                            sha256:04e96c2404ea70c590c546eba4202a4e12722c640016c12b9b2f1ce3d481e9a8
./embedded/bin/xml2-config:    --libtool-libs)
./embedded/include/libltdl/lt_dlloader.h:   GNU Libtool package.  Report bugs to bug-libtool@gnu.org.
./embedded/include/libltdl/lt_system.h:   GNU Libtool package.  Report bugs to bug-libtool@gnu.org.
./embedded/include/libltdl/lt_system.h:/* Keep this code in sync between libtool.m4, ltmain, lt_system.h, and tests.  */
./embedded/include/libltdl/lt_system.h:#    if defined DLL_EXPORT		/* defined by libtool (if required) */
./embedded/include/libltdl/lt_error.h:   GNU Libtool package.  Report bugs to bug-libtool@gnu.org.
./embedded/include/unixodbc_conf.h:/* Define if libtool can extract symbol lists from object files. */
./embedded/include/unixodbc_conf.h:/* Define to the sub-directory where libtool stores uninstalled libraries. */
./embedded/lib/python3.13/ctypes/_aix.py:    # This is common practice by GNU libtool on other platforms
./embedded/lib/python3.13/site-packages/packaging/licenses/_spdx.py:    'libtool-exception': {'id': 'Libtool-exception', 'deprecated': False},
./embedded/lib/python3.13/site-packages/setuptools/_vendor/packaging/licenses/_spdx.py:    'libtool-exception': {'id': 'Libtool-exception', 'deprecated': False},

The first shows no uses of m4. The second shows no references to libtool outside of libtool.

RUN_E2E_TESTS=on

@aiuto aiuto added the changelog/no-changelog No changelog entry needed label Nov 24, 2025
@aiuto
aiuto requested a review from a team as a code owner November 24, 2025 18:39
@aiuto aiuto added the qa/no-code-change No code change in Agent code requiring validation label Nov 24, 2025
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Nov 24, 2025
@cit-pr-commenter

cit-pr-commenter Bot commented Nov 24, 2025

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: caa8372d-93f6-4c44-b013-36c11155d4b2

Baseline: 716b81c
Comparison: 1917580
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.68 [-0.31, +5.66] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.68 [-0.31, +5.66] 1 Logs
quality_gate_logs % cpu utilization +0.66 [-0.81, +2.14] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.37 [+0.32, +0.41] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.35 [+0.11, +0.59] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.25 [+0.09, +0.40] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.24 [+0.19, +0.29] 1 Logs
quality_gate_idle_all_features memory utilization +0.18 [+0.13, +0.23] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization +0.10 [-0.01, +0.20] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.04 [-0.00, +0.09] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.39, +0.45] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.35, +0.40] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.02 [-0.11, +0.14] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.13, +0.14] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.07, +0.07] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.06 [-0.46, +0.34] 1 Logs
ddot_logs memory utilization -0.19 [-0.27, -0.11] 1 Logs
ddot_metrics_sum_delta memory utilization -0.24 [-0.45, -0.04] 1 Logs
docker_containers_memory memory utilization -0.47 [-0.56, -0.38] 1 Logs
file_tree memory utilization -0.52 [-0.57, -0.47] 1 Logs
otlp_ingest_metrics memory utilization -0.59 [-0.73, -0.45] 1 Logs
ddot_metrics memory utilization -0.78 [-1.00, -0.57] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.22 [-1.33, -1.10] 1 Logs
quality_gate_metrics_logs memory utilization -1.51 [-1.72, -1.30] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 716b81c

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${0}$$ $${703.31}$$ < $${717.44}$$ $${-0.02}$$ $${172.42}$$ < $${177.37}$$
agent_deb_amd64_fips $${-0}$$ $${697.36}$$ < $${711.66}$$ $${-0.02}$$ $${170.99}$$ < $${174.84}$$
agent_heroku_amd64 $${-0}$$ $${327.5}$$ < $${337.57}$$ $${+0}$$ $${87.4}$$ < $${90.78}$$
agent_msi $${0}$$ $${1000.27}$$ < $${1015.38}$$ $${+0.01}$$ $${144.46}$$ < $${149.42}$$
agent_rpm_amd64 $${0}$$ $${703.3}$$ < $${717.41}$$ $${-0.01}$$ $${175.55}$$ < $${178.01}$$
agent_rpm_amd64_fips $${-0}$$ $${697.34}$$ < $${711.64}$$ $${-0.05}$$ $${173.23}$$ < $${177.26}$$
agent_rpm_arm64 $${0}$$ $${688.6}$$ < $${702.19}$$ $${-0.03}$$ $${159.22}$$ < $${163.22}$$
agent_rpm_arm64_fips $${0}$$ $${683.77}$$ < $${697.6}$$ $${+0.03}$$ $${158.66}$$ < $${162.68}$$
agent_suse_amd64 $${0}$$ $${703.3}$$ < $${717.41}$$ $${-0.01}$$ $${175.55}$$ < $${178.01}$$
agent_suse_amd64_fips $${-0}$$ $${697.34}$$ < $${711.64}$$ $${-0.05}$$ $${173.23}$$ < $${177.26}$$
agent_suse_arm64 $${0}$$ $${688.6}$$ < $${702.19}$$ $${-0.03}$$ $${159.22}$$ < $${163.22}$$
agent_suse_arm64_fips $${0}$$ $${683.77}$$ < $${697.6}$$ $${+0.03}$$ $${158.66}$$ < $${162.68}$$
docker_agent_amd64 $${+0}$$ $${765.68}$$ < $${769.92}$$ $${+0.01}$$ $${260.08}$$ < $${261.52}$$
docker_agent_arm64 $${+0}$$ $${775.34}$$ < $${779.46}$$ $${+0}$$ $${250.33}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${+0}$$ $${956.56}$$ < $${960.8}$$ $${+0.01}$$ $${328.73}$$ < $${330.15}$$
docker_agent_jmx_arm64 $${0}$$ $${954.94}$$ < $${958.93}$$ $${+0.01}$$ $${314.95}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${-0}$$ $${178.28}$$ < $${207.49}$$ $${-0}$$ $${63.0}$$ < $${70.2}$$
docker_cluster_agent_arm64 $${-0}$$ $${195.77}$$ < $${223.38}$$ $${+0}$$ $${59.73}$$ < $${66.42}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.54}$$ < $${39.3}$$ $${-0}$$ $${14.9}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.24}$$ < $${37.94}$$ $${-0}$$ $${14.34}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.76}$$ < $${30.53}$$ $${+0}$$ $${7.85}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.28}$$ < $${29.11}$$ $${-0}$$ $${6.79}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.76}$$ < $${30.53}$$ $${-0}$$ $${7.87}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.76}$$ < $${30.53}$$ $${-0}$$ $${7.87}$$ < $${8.76}$$
iot_agent_deb_amd64 $${0}$$ $${42.52}$$ < $${43.19}$$ $${-0}$$ $${11.1}$$ < $${11.98}$$
iot_agent_deb_arm64 $${0}$$ $${40.25}$$ < $${40.92}$$ $${+0}$$ $${9.57}$$ < $${10.45}$$
iot_agent_deb_armhf $${0}$$ $${40.17}$$ < $${40.86}$$ $${+0}$$ $${9.68}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${0}$$ $${42.52}$$ < $${43.19}$$ $${-0}$$ $${11.12}$$ < $${12.0}$$
iot_agent_suse_amd64 $${0}$$ $${42.52}$$ < $${43.19}$$ $${-0}$$ $${11.12}$$ < $${12.0}$$

@aiuto
aiuto marked this pull request as draft November 24, 2025 20:15

@alopezz alopezz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's more, there's no dependency "m4" or the like in any omnibus files. So this looks like good cleanup.

@aiuto
aiuto marked this pull request as ready for review November 25, 2025 13:59
@aiuto

aiuto commented Nov 25, 2025

Copy link
Copy Markdown
Collaborator Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 25, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-25 13:59:15 UTC ℹ️ Start processing command /merge


2025-11-25 13:59:21 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-11-25 17:33:03 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 45m (p90).


2025-11-25 17:35:21 UTC 🚨 MergeQueue: This merge request is in error because of GitLab

Gitlab pipeline didn't start... Please retry.

you can get help from #ci-infra-support

Error: gitlab pipeline not started

@aiuto

aiuto commented Nov 25, 2025

Copy link
Copy Markdown
Collaborator Author

/ddci trigger

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 25, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-25 18:20:06 UTC ℹ️ Start processing command /ddci trigger


2025-11-25 18:20:28 UTC ℹ️ Devflow: /ddci trigger

✅ Tasks request sent successfully.
🔑 DDCI Request ID: 8500941784521264461
🔍 Debug this request with Datadog Traces

@aiuto

aiuto commented Nov 25, 2025

Copy link
Copy Markdown
Collaborator Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 25, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-25 18:20:10 UTC ℹ️ Start processing command /merge


2025-11-25 18:20:15 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 45m (p90).


2025-11-25 18:22:42 UTC 🚨 MergeQueue: This merge request is in error because of GitLab

Gitlab pipeline didn't start... Please retry.

you can get help from #ci-infra-support

Error: gitlab pipeline not started

@aiuto

aiuto commented Nov 25, 2025

Copy link
Copy Markdown
Collaborator Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 25, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-25 18:50:15 UTC ℹ️ Start processing command /merge


2025-11-25 18:50:21 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-11-25 20:19:05 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 44m (p90).


2025-11-25 20:21:22 UTC 🚨 MergeQueue: This merge request is in error because of GitLab

Gitlab pipeline didn't start... Please retry.

you can get help from #ci-infra-support

Error: gitlab pipeline not started

@aiuto aiuto removed the qa/no-code-change No code change in Agent code requiring validation label Nov 25, 2025
@aiuto

aiuto commented Nov 25, 2025

Copy link
Copy Markdown
Collaborator Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 25, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-25 20:37:46 UTC ℹ️ Start processing command /merge


2025-11-25 20:37:52 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-11-25 22:02:07 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 44m (p90).


2025-11-25 22:04:31 UTC 🚨 MergeQueue: This merge request is in error because of GitLab

Gitlab pipeline didn't start... Please retry.

you can get help from #ci-infra-support

Error: gitlab pipeline not started

@aiuto aiuto added the qa/no-code-change No code change in Agent code requiring validation label Nov 25, 2025
We don't actually use m4 in the product.

For the AIX build of libtool, we expect m4 to be present, but it is fine to remove this now.
- We are not currently building for AIX
- We are moving away from needing libtool, so this this part of the graph is disappearing.
@aiuto

aiuto commented Nov 26, 2025

Copy link
Copy Markdown
Collaborator Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 26, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-26 02:01:51 UTC ℹ️ Start processing command /merge


2025-11-26 02:01:54 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 45m (p90).


2025-11-26 02:04:10 UTC 🚨 MergeQueue: This merge request is in error because of GitLab

Gitlab pipeline didn't start... Please retry.

you can get help from #ci-infra-support

Error: gitlab pipeline not started

@KevinFairise2

Copy link
Copy Markdown
Member

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 26, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-26 08:33:40 UTC ℹ️ Start processing command /merge


2025-11-26 08:33:43 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 45m (p90).


2025-11-26 08:36:07 UTC 🚨 MergeQueue: This merge request is in error because of GitLab

Gitlab pipeline didn't start... Please retry.

you can get help from #ci-infra-support

Error: gitlab pipeline not started

@aiuto

aiuto commented Nov 26, 2025

Copy link
Copy Markdown
Collaborator Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 26, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-26 17:36:54 UTC ℹ️ Start processing command /merge


2025-11-26 17:37:00 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-11-26 19:32:07 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 41m (p90).


2025-11-26 19:44:38 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit facbf5f into main Nov 26, 2025
424 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the aiuto/m4 branch November 26, 2025 19:44
@github-actions github-actions Bot added this to the 7.74.0 milestone Nov 26, 2025
rdesgroppes added a commit that referenced this pull request Jan 15, 2026
This change removes AIX-specific implementation code from the
`pkg/trace/watchdog module`.

This removal should be safe because:
- AIX builds were never configured in CI (contrarily to Linux, macOS
  and Windows),
- as per https://docs.datadoghq.com/agent/supported_platforms/aix/,
  AIX is officially supported via the separate `datadog-unix-agent`
  repository (https://github.com/DataDog/datadog-unix-agent, active as
  of December 2025),
- `dd-trace-go` (only external consumer I found) doesn't import
  `pkg/trace/watchdog`
  (https://github.com/search?q=repo%3ADataDog%2Fdd-trace-go+github.com%2FDataDog%2Fdatadog-agent%2Fpkg%2Ftrace%2F&type=code)
  nor supports AIX,
- in August 2025, #40116 documented in AGENTS.md:
  > AIX: No support in this codebase
- In November 2025, #43420 stated:
  > We are not currently building for AIX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants