Add rules shared between cursor and claude - #40116
Conversation
e484f38 to
45ed63c
Compare
45ed63c to
0821e37
Compare
chouetz
left a comment
There was a problem hiding this comment.
I know this is not directly related to your change, but I did some suggestions on the main file. Thanks in advance
Co-authored-by: Nicolas Schweitzer <nicolas.schweitzer@datadoghq.com>
Co-authored-by: Nicolas Schweitzer <nicolas.schweitzer@datadoghq.com>
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 6d9476c Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +4.88 | [+1.73, +8.04] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +4.88 | [+1.73, +8.04] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +2.24 | [-0.54, +5.02] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | +2.01 | [+1.66, +2.37] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.27 | [+0.23, +0.31] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.07 | [-0.08, +0.21] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.05 | [-0.05, +0.16] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.04 | [-0.58, +0.66] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.03, +0.03] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.00 | [-0.63, +0.63] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.00 | [-0.60, +0.60] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.11, +0.09] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.05 | [-0.09, -0.02] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.06 | [-0.68, +0.57] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.15 | [-0.18, -0.11] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.22 | [-0.30, -0.14] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.54 | [-0.59, -0.50] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.59 | [-0.74, -0.44] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -1.08 | [-1.27, -0.89] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -2.50 | [-2.69, -2.31] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ❌ | docker_containers_memory | simple_check_run | 7/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
This change removes AIX-specific implementation code from the `pkg/trace/watchdog module`. This removal should be safe because: - AIX builds were never configured in CI (contrarily to Linux, macOS and Windows), - as per https://docs.datadoghq.com/agent/supported_platforms/aix/, AIX is officially supported via the separate `datadog-unix-agent` repository (https://github.com/DataDog/datadog-unix-agent, active as of December 2025), - `dd-trace-go` (only external consumer I found) doesn't import `pkg/trace/watchdog` (https://github.com/search?q=repo%3ADataDog%2Fdd-trace-go+github.com%2FDataDog%2Fdatadog-agent%2Fpkg%2Ftrace%2F&type=code) nor supports AIX, - in August 2025, #40116 documented in AGENTS.md: > AIX: No support in this codebase - In November 2025, #43420 stated: > We are not currently building for AIX
What does this PR do?
Create general guidelines for the AI agent using datadog-agent with a AGENTS.md file that is referenced in CLAUDE.md and cursor rules.
Was tested with Cursor and Claude, with that context the AI agent should be able to build the agent. "Build the agent" should create a core-agent binary, while being able to solve known error like CMake cache issue.
Motivation
Onboard coding Agent to datadog-agent
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes
That one is a first version that allows us to have a simple rule file shared between cursor and Claude. As a follow-up we want to put all the rules inside cursor rules and synchronized them so other agents can benefit from the cursor rules. That one is a first step that allows us to build the agent by asking cursor or claude