Skip to content

Add rules shared between cursor and claude - #40116

Merged
dd-mergequeue[bot] merged 5 commits into
mainfrom
kfairise/agent-md
Aug 28, 2025
Merged

Add rules shared between cursor and claude#40116
dd-mergequeue[bot] merged 5 commits into
mainfrom
kfairise/agent-md

Conversation

@KevinFairise2

@KevinFairise2 KevinFairise2 commented Aug 21, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Create general guidelines for the AI agent using datadog-agent with a AGENTS.md file that is referenced in CLAUDE.md and cursor rules.

Was tested with Cursor and Claude, with that context the AI agent should be able to build the agent. "Build the agent" should create a core-agent binary, while being able to solve known error like CMake cache issue.

Motivation

Onboard coding Agent to datadog-agent

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

That one is a first version that allows us to have a simple rule file shared between cursor and Claude. As a follow-up we want to put all the rules inside cursor rules and synchronized them so other agents can benefit from the cursor rules. That one is a first step that allows us to build the agent by asking cursor or claude

@github-actions github-actions Bot added team/agent-devx medium review PR review might take time labels Aug 21, 2025
@KevinFairise2 KevinFairise2 changed the title Try to symlink agent.md to claude.md Add agent.md and symlink it to claude.md Aug 21, 2025
@KevinFairise2 KevinFairise2 changed the title Add agent.md and symlink it to claude.md Add rules shared between cursor and claude Aug 22, 2025
@KevinFairise2
KevinFairise2 marked this pull request as ready for review August 22, 2025 08:22
@KevinFairise2
KevinFairise2 requested a review from a team as a code owner August 22, 2025 08:22
@KevinFairise2 KevinFairise2 added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Aug 22, 2025

@chouetz chouetz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is not directly related to your change, but I did some suggestions on the main file. Thanks in advance

Comment thread AGENTS.md Outdated
Comment thread AGENTS.md Outdated
KevinFairise2 and others added 2 commits August 27, 2025 09:39
Co-authored-by: Nicolas Schweitzer <nicolas.schweitzer@datadoghq.com>
Co-authored-by: Nicolas Schweitzer <nicolas.schweitzer@datadoghq.com>
@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 6d9476c

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${0}$$ $${700.54}$$ < $${704.84}$$ $${+0.02}$$ $${177.19}$$ < $${178.58}$$
agent_deb_amd64_fips $${0}$$ $${687.82}$$ < $${703.09}$$ $${-0}$$ $${174.1}$$ < $${178.12}$$
agent_heroku_amd64 $${0}$$ $${350.36}$$ < $${355.37}$$ $${+0}$$ $${94.01}$$ < $${95.72}$$
agent_msi $${0}$$ $${975.62}$$ < $${980.61}$$ $${-0}$$ $${150.14}$$ < $${152.67}$$
agent_rpm_amd64 $${0}$$ $${700.53}$$ < $${704.83}$$ $${-0}$$ $${179.19}$$ < $${180.22}$$
agent_rpm_amd64_fips $${0}$$ $${687.81}$$ < $${703.08}$$ $${-0.03}$$ $${175.77}$$ < $${179.85}$$
agent_rpm_arm64 $${0}$$ $${689.55}$$ < $${694.74}$$ $${-0.01}$$ $${161.71}$$ < $${163.96}$$
agent_rpm_arm64_fips $${0}$$ $${677.66}$$ < $${693.05}$$ $${+0.02}$$ $${158.42}$$ < $${163.0}$$
agent_suse_amd64 $${0}$$ $${700.53}$$ < $${704.83}$$ $${-0}$$ $${179.19}$$ < $${180.22}$$
agent_suse_amd64_fips $${0}$$ $${687.81}$$ < $${703.08}$$ $${-0.03}$$ $${175.77}$$ < $${179.85}$$
agent_suse_arm64 $${0}$$ $${689.55}$$ < $${694.74}$$ $${-0.01}$$ $${161.71}$$ < $${163.96}$$
agent_suse_arm64_fips $${0}$$ $${677.66}$$ < $${693.05}$$ $${+0.02}$$ $${158.42}$$ < $${163.0}$$
docker_agent_amd64 $${-0}$$ $${782.95}$$ < $${788.65}$$ $${+0.01}$$ $${269.93}$$ < $${272.01}$$
docker_agent_arm64 $${+0}$$ $${795.3}$$ < $${802.0}$$ $${-0}$$ $${256.7}$$ < $${259.7}$$
docker_agent_jmx_amd64 $${-0}$$ $${973.82}$$ < $${979.84}$$ $${+0.01}$$ $${338.56}$$ < $${340.95}$$
docker_agent_jmx_arm64 $${+0}$$ $${974.77}$$ < $${981.8}$$ $${+0}$$ $${321.31}$$ < $${324.65}$$
docker_cluster_agent_amd64 $${0}$$ $${212.65}$$ < $${214.5}$$ $${+0}$$ $${72.21}$$ < $${73.51}$$
docker_cluster_agent_arm64 $${-0}$$ $${228.61}$$ < $${230.33}$$ $${-0}$$ $${68.48}$$ < $${69.77}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.71}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.32}$$ < $${39.57}$$ $${+0}$$ $${14.81}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${36.99}$$ < $${38.2}$$ $${0}$$ $${14.26}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.55}$$ < $${31.4}$$ $${+0}$$ $${7.8}$$ < $${8.95}$$
dogstatsd_deb_arm64 $${0}$$ $${28.14}$$ < $${29.97}$$ $${+0}$$ $${6.75}$$ < $${7.89}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.55}$$ < $${31.4}$$ $${-0}$$ $${7.81}$$ < $${8.96}$$
dogstatsd_suse_amd64 $${0}$$ $${29.55}$$ < $${31.4}$$ $${-0}$$ $${7.81}$$ < $${8.96}$$
iot_agent_deb_amd64 $${0}$$ $${54.15}$$ < $${54.55}$$ $${-0}$$ $${13.65}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${51.47}$$ < $${51.9}$$ $${-0}$$ $${11.82}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${51.02}$$ < $${51.42}$$ $${+0}$$ $${11.89}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${54.15}$$ < $${54.55}$$ $${-0}$$ $${13.67}$$ < $${14.47}$$
iot_agent_suse_amd64 $${0}$$ $${54.15}$$ < $${54.55}$$ $${-0}$$ $${13.67}$$ < $${14.47}$$

@cit-pr-commenter

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 07ac8bf2-2862-4bc9-8045-811bd75d9a9a

Baseline: 6d9476c
Comparison: 876931c
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +4.88 [+1.73, +8.04] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +4.88 [+1.73, +8.04] 1 Logs
quality_gate_logs % cpu utilization +2.24 [-0.54, +5.02] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +2.01 [+1.66, +2.37] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.27 [+0.23, +0.31] 1 Logs
otlp_ingest_metrics memory utilization +0.07 [-0.08, +0.21] 1 Logs
ddot_logs memory utilization +0.05 [-0.05, +0.16] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.58, +0.66] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.03, +0.03] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.00 [-0.63, +0.63] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.00 [-0.60, +0.60] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.11, +0.09] 1 Logs
quality_gate_idle memory utilization -0.05 [-0.09, -0.02] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput -0.06 [-0.68, +0.57] 1 Logs
quality_gate_idle_all_features memory utilization -0.15 [-0.18, -0.11] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.22 [-0.30, -0.14] 1 Logs
file_tree memory utilization -0.54 [-0.59, -0.50] 1 Logs
otlp_ingest_logs memory utilization -0.59 [-0.74, -0.44] 1 Logs
ddot_metrics memory utilization -1.08 [-1.27, -0.89] 1 Logs
docker_containers_memory memory utilization -2.50 [-2.69, -2.31] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 7/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@KevinFairise2

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 28, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-28 09:49:52 UTC ℹ️ Start processing command /merge


2025-08-28 09:50:01 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 39m (p90).


2025-08-28 10:14:41 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 2986281 into main Aug 28, 2025
238 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the kfairise/agent-md branch August 28, 2025 10:14
@github-actions github-actions Bot added this to the 7.71.0 milestone Aug 28, 2025
rdesgroppes added a commit that referenced this pull request Jan 15, 2026
This change removes AIX-specific implementation code from the
`pkg/trace/watchdog module`.

This removal should be safe because:
- AIX builds were never configured in CI (contrarily to Linux, macOS
  and Windows),
- as per https://docs.datadoghq.com/agent/supported_platforms/aix/,
  AIX is officially supported via the separate `datadog-unix-agent`
  repository (https://github.com/DataDog/datadog-unix-agent, active as
  of December 2025),
- `dd-trace-go` (only external consumer I found) doesn't import
  `pkg/trace/watchdog`
  (https://github.com/search?q=repo%3ADataDog%2Fdd-trace-go+github.com%2FDataDog%2Fdatadog-agent%2Fpkg%2Ftrace%2F&type=code)
  nor supports AIX,
- in August 2025, #40116 documented in AGENTS.md:
  > AIX: No support in this codebase
- In November 2025, #43420 stated:
  > We are not currently building for AIX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants