fix(agent-runtime): brand procedural screening decisions - #591
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough프로시저 후보 결정에 프로세스 로컬 등록과 공개 검증 함수를 추가했습니다. 복제된 결정은 거부합니다. 관련 오류 코드를 추가하고, 검증 동작과 영속화 제한을 테스트와 ADR에 기록했습니다. Changes프로시저 결정 승인
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Current-head review on exact 2faef2c0d8337b00e241d648c0082ea36a68ada9: no valid unresolved source/test/DDD finding. The WeakSet provenance is granted only after the existing lineage/evaluation/safety/score checks complete; copied, deserialized, proxied, or caller-constructed lookalikes fail closed through unadmitted_decision; activationAuthorized remains false. This is process-local provenance only and does not mint evaluator authentication, persistence, approval, activation, provider routing, tool authority, credentials, or foreign-domain truth. Four exact-head workflows are terminal SUCCESS; no review threads are open.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Purpose
Prevent a structurally forged
ProceduralCandidateDecisionfrom crossing the next State / Checkpoint or Policy / Approval authority boundary as if it had been produced byassessProceduralCandidate().Protected
main@dbc94effde5221c4ff03242d1e29c0e4e7b17422has no open PRs and already contains #590 documentation convergence. ADR-0017 remains Proposed. This lane is a narrow prerequisite for durable rejection history / approval CAS: it does not add persistence, activation, provider routing, credentials, tool authority, or foreign-domain truth.RED first
Exact
da068a99e79e465036a927f6ceed21f873e88b7badds a regression that requires locally screened decision provenance and rejects a frozen structural copy. It intentionally references the not-yet-implementedassertProceduralCandidateDecision()and therefore must not be treated as GREEN evidence.Intended causal repair
Brand decisions inside
procedural-evolution.tsonly after all existing lineage/evaluation checks complete, expose a fail-closed assertion for later authority boundaries, and add a closedunadmitted_decisionerror code. A copied/frozen/proxy lookalike must never gain approval or persistence authority.Keep Draft until the successor exact head has terminal application CI, reviewer-ci, central Security Scan, patch-validator-image and current-head review with no valid unresolved finding.
Summary by CodeRabbit
새로운 기능
문서
테스트