docs(agent-runtime): classify current-state ACL as protected - #590
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Current-head review on e00946d03476bd3e41f4177517552988886c89ff: reviewed all six changed paths against protected main@0e899886b039ed27f71bdbc4540ea266b8ef9aed. The post-#589 authority drift is repaired across ARCHITECTURE, PRD, TRD, the procedural adoption record, and the product/technical gap baseline; ADR-0017 remains Proposed and release/deployment/evaluation/Policy-Approval/canary/product-outcome authority is not promoted. The documentation regression covers the stale candidate markers and required protected-source classifications. The intermediate accidental historical-evidence edits are restored in the current patch. No additional valid source/test/DDD finding found. This is a COMMENT review, not self-approval; exact-head hosted gates remain independent merge authority.
seonghobae
left a comment
There was a problem hiding this comment.
Current-head review on 2c2e80b7f3aaf969f88c3a7acbd738f29770cd16: reviewed all seven changed paths against protected main@0e899886b039ed27f71bdbc4540ea266b8ef9aed and the hosted RED from application CI 34459379475 / job 102813327267. The causal test repair updates the pre-existing documentation-current authority contract from protected #585/#586 to protected #585/#586/#589 and asserts the #589 current-state ACL link; it does not relax or delete a gate. The five canonical documentation surfaces now classify #589 as protected source while ADR-0017 stays Proposed and release/deployment/authenticated-evaluation/durable-promotion/Policy-Approval/canary/product-outcome authority remains explicitly absent. Intermediate accidental historical-evidence edits are absent from the current patch. No additional valid source/test/DDD finding found. COMMENT only, not self-approval; the new exact-head hosted generation is required independently.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Purpose
Repair the post-merge procedural documentation authority drift after #589. Protected source already contains the workflow-backed current-state ACL, but moving-current canonical docs still described it as an active/Draft candidate.
RED → repair
020498dae9e19e65c60a6398f9016f7c980598cfadded an executable documentation regression covering ARCHITECTURE, PRD, TRD, the product/technical gap baseline, and the procedural adoption record. Against protectedmain@0e899886b039ed27f71bdbc4540ea266b8ef9aed, those assertions are reality-RED because the documents retainOn this active branch,Draft #589,candidate #589, or equivalent pre-integration wording.Current-head application CI run
34459379475, job102813327267, then produced a hosted reality RED on exacte00946d03476bd3e41f4177517552988886c89ff: typecheck passed, but release tests ended at 1 failed / 4,545 passed because the pre-existingtest/documentation-current-trust-authority.test.tsstill requiredProtected source integration: #585 and #586.... That executable authority contract was stale after #589. The minimal causal repair updates that existing test to require #585/#586/#589 protected integration and the protected #589 current-state link/heading; it does not weaken the documentation gate.The successor commits classify #589 as protected source while preserving its narrow authority boundary. During full-patch review, a manually reconstructed baseline briefly altered historical exact evidence; successor repairs restored the original SHA/text before the current exact head. Current exact is
2c2e80b7f3aaf969f88c3a7acbd738f29770cd16.Authority boundary
#589 source integration does not promote ADR-0017 beyond
Proposedand does not infer immutable release, deployment, authenticated evaluation, durable graph/rejection history, Policy / Approval CAS, canary/rollback, activation, or product-outcome evidence. No second lifecycle store, cross-service SQL, provider routing, quarantine/security truth, or foreign domain truth is introduced.Keep this PR Draft until the unchanged exact head has terminal applicable CI/security evidence and current-head review has no valid unresolved finding.