fix(agent-runtime): bind procedural evaluation receipt identities - #592
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAgent Runtime의 procedural candidate decision에 baseline 및 candidate 평가 영수증의 canonical SHA-256 digest를 추가합니다. 검증된 관측값으로 digest를 생성하고, 결정 객체에 저장하며, identity 불변성과 증거 변경 동작을 테스트합니다. Changes절차적 평가 영수증 identity
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Current-head review found one repairable repository-contract finding on exact b49eb9f1f38cdad9e94707a70d4b25d29da84c4b: CONTRIBUTING.md and CLAUDE.md require every behavior change to update CHANGELOG.md under ## Unreleased, but this head changes the exported ProceduralCandidateDecision contract and currently changes only source + focused test. Keep the valid receipt-identity delta; add the narrow Unreleased entry without rewriting historical evidence, then rerun exact-head gates. Source semantics otherwise remain bounded: receipt digests are computed only after existing validation/canonical holdout ordering, remain local evidence identities rather than authentication/signature/approval, and activationAuthorized:false is unchanged.
seonghobae
left a comment
There was a problem hiding this comment.
Current-head review on exact d9c1f093fa23d255be3e605ad25bec09b8f1eaca: prior CHANGELOG finding is repaired without historical deletion, and the focused edge coverage now binds canonical observation order plus score and safety evidence changes. No valid unresolved source/test/DDD/documentation finding remains. Receipt digests are derived only after existing exact graph/context/case-set/score/safety validation, remain non-authenticating evidence identities, and do not change activationAuthorized:false or create State/Checkpoint, Policy/Approval, provider, tool, credential, or foreign-domain authority. Four exact-head workflows are terminal SUCCESS; no inline review threads are open.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Purpose
Prepare the next State / Checkpoint retention boundary without inventing persistence or approval authority. A locally branded
ProceduralCandidateDecisionnow carries exact identities for the paired evaluation evidence it actually screened; graph/context digests alone are insufficient to bind later authenticated durable evidence to those exact observations.Protected base:
main@2013df113807f3214389b528e25a1a5de9d1b52dafter normal #591 integration. ADR-0017 remains Proposed and every decision remainsactivationAuthorized:false.RED → causal repair
393abf22a02749c16df0aac0a6ee17b64453e43e: focused tests require canonical baseline/candidate receipt digests and prove evidence changes alter the candidate receipt identity; the then-current source had no such fields.b49eb9f1f38cdad9e94707a70d4b25d29da84c4b: computes each receipt digest only after exact graph/context/case-set/score/safety validation, canonicalizes observations in admitted holdout order, and returns both digests inside the existing process-local branded frozen decision.adfe7fd4c943c21afe9f7b0c962520a0e006d545→a839d0f52135e9921f4d3c10aa590a1ed9884e97: current-head review found the repository-wideCHANGELOG.mdrequirement was missing. The Unreleased entries now cover fix(agent-runtime): brand procedural screening decisions #591 process-local decision provenance and fix(agent-runtime): bind procedural evaluation receipt identities #592 receipt identity. Two accidental historical wording normalizations made while editing the large changelog were immediately restored; final diff against the prior source exact is two intended added bullets and zero historical deletions.d9c1f093fa23d255be3e605ad25bec09b8f1eaca: adds explicit safety-evidence identity coverage as well as score-change and observation-order canonicalization coverage.The receipt digests are local evidence identities, not signatures, producer authentication, approval, persistence, activation, tool authority, provider routing, credentials, or foreign-domain truth. Later State / Checkpoint retention must still verify authenticated evaluator authority against these exact identities before durable reconstruction or Policy / Approval CAS.
Keep Draft until the unchanged current exact has application CI, reviewer-ci, central Security Scan, patch-validator-image and a fresh current-head review with no valid unresolved finding.
Summary by CodeRabbit
새로운 기능
버그 수정
safety_violation사유로 처리됩니다.