docs(agent-runtime): classify protected procedural history - #598
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthrough절차적 그래프 문서가 인증된 평가자 핸드오프와 State / Checkpoint 기반 bounded durable evaluation/rejection history를 반영하도록 갱신되었습니다. 관련 추적성, 기준선, 도입 기록과 문서 계약 테스트도 새 보호 범위에 맞게 정렬되었습니다. Changes절차적 그래프 보호 범위
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Current-head review on 268765e2baefd916ec0ca2f82ca2550f76943c12: the three-file delta now repairs the observed application-CI RED without weakening the documentation authority check. The adoption record, the focused protected-documentation regression, and the formerly stale current-trust assertion agree that #597 is protected State / Checkpoint durable-history source while Policy / Approval and activation remain separate. No additional valid finding in this exact PR delta. The PR should remain Draft because protected PRD/TRD/ARCHITECTURE/TRACEABILITY/product technical baseline still contain broader post-#597 classification drift (for example, describing the procedural source as non-durable). Those files must converge before normal merge; predecessor gate results are not transferable.
seonghobae
left a comment
There was a problem hiding this comment.
Current-head review on 2c4821fe00a9691066a86311b141a46fe8ea68e7: reviewed the eight-file documentation/test convergence plus the two-commit authority repair from d540c242.... The added regression correctly rejects an exact central .github/main SHA being presented as evergreen “moving” authority, while the causal baseline change records live .github/main@cb0872c9a20d5584703dffacca65c096fc034c6c only as a dated observation and preserves the independently reviewed immutable Noema consumer pin c9052e607e5f3cc76e73207e7786b21500721b79. The broader #597 convergence continues to keep ADR-0017 Proposed, activationAuthorized:false, bounded State / Checkpoint evidence distinct from Policy / Approval and activation, and foreign owner boundaries intact. No additional valid source/test/DDD finding or unresolved inline thread found on this exact. Do not transfer predecessor GREEN; merge only if this unchanged exact receives terminal-success application CI, reviewer-ci, central Security Scan and patch-validator-image.
Purpose
Repair the post-#597 documentation-authority drift on protected
main@61f2b372d55c87e1763bc11d3e545967fc0a9cf5. Protected #594 authenticates the supplied evaluator handoff and protected #597 now owns bounded durable evaluation/rejection history under the existing State / Checkpoint boundary; canonical documentation must describe those facts without promoting them into Policy / Approval, graph publication, release or activation authority.Reality RED → causal repair
Test-first exact
8bad02eb414e29fc1148e528918ad178e0649ffaextendedtest/procedural-protected-documentation-contract.test.tsto require #597 protected-source classification, bounded durable evaluation/rejection history, explicit separation of Policy / Approval CAS, and removal of stale pre-persistence / no-signed-verifier statements.Causal successor
07e94ac8a4648efcb6cfea1cbc4d0899fd20bea9updateddocs/doctoring/procedural_graph_adoption.md: #597 is protected State / Checkpoint source, its observed coverage RED→repair→four-gate→normal-merge lineage is preserved, live Keyverse trust and Policy / Approval CAS remain separate, and the rollout table advances from persistence to approval/revocation rather than proposing a second state authority.Application CI on
07e94ac8a4648efcb6cfea1cbc4d0899fd20bea9then produced a real repository RED: typecheck and 4,575 tests passed excepttest/documentation-current-trust-authority.test.ts, whose old expectation required the pre-#597 sentence ending after #589. Exact268765e2baefd916ec0ca2f82ca2550f76943c12repaired that stale regression without weakening the authority check.A broader canonical-doc sweep then confirmed that PRD/TRD/ARCHITECTURE/TRACEABILITY/product technical baseline still described procedural evaluation/history as absent or intentionally non-durable. Test-first exact
299546e6da8b45804f2b94a930acd6142e41a885makes that drift executable: it requires protected signed-handoff verification plus bounded durable evaluation/rejection history while forbidding the stale non-durable classifications and retaining ADR-0017Proposed.The causal documentation sequence is ordinary branch history, not predecessor evidence transfer:
5aa3d4e2b5846340547f1a5b8e37a0ed0dce5cf4— PRD classifies signed evaluator handoff and feat(state-checkpoint): persist durable procedural evaluation history #597 history as protected evidence while keeping live trust/Policy/Approval/publication/activation separate.ef8d5ce5de40479c2b28474c463d73e713942585— TRD aligns persistence, verification, planned work and deployed-evidence boundaries.e266c423d18cc7d31a5a821418719d56e6f87e0e— ARCHITECTURE separates process-local graph/session authority, feat(state-checkpoint): persist durable procedural evaluation history #597 State / Checkpoint history, feat(agent-runtime): gate procedural guidance on current durable workflow evidence #589 Workflow / Task current-state evidence, and future Policy / Approval authority.80d7d9bee90d82661b601644d3d8d5d27eac1fe3— TRACEABILITY records authenticated evaluator handoff and bounded durable evaluation/rejection history as protected source with explicit residual owner boundaries.83faa9b5dd67fd3ca42ff9e8c9354e7d96663c50,67468a218da9cfddb7a513e3585ed9205d6dda6a,d540c24260a5035cf4ccfe231a6eb8bdffb49396— product technical gap baseline converges feat(state-checkpoint): persist durable procedural evaluation history #597 source/history classification and distinguishes source-integration lineage from documentation-doctoring lineage.A fresh owner-authority sweep then found that the baseline still labelled exact
.github/main@7fd571dbcdbae6acf29d8f4ee704d7ba6297e4dbas a “moving” central snapshot even though live centralmainhad advanced tocb0872c9a20d5584703dffacca65c096fc034c6c. Test-first exactd5ac9d7617247b2d195fadddeaca1d5bc9e14bf9rejects that stale moving-authority formulation and requires a dated central observation while preserving the reviewed immutable Noema consumer pin. Causal current exact2c4821fe00a9691066a86311b141a46fe8ea68e7records the live central SHA as a dated observation and keeps moving foreign head distinct from the immutableALLOWED_WORKFLOW_SHApin; it does not auto-bump the consumer pin.Boundary
ADR-0017 remains Proposed.
activationAuthorized:falseremains invariant. Retained evaluation/rejection history is State / Checkpoint evidence only. Live signer/trust selection remains Keyverse/owner composition; Policy / Approval CAS, non-workflow lifecycle freshness/revocation, released cross-service contracts, deployed Durable Object compatibility/p95/recovery, graph publication, canary/rollback and product outcome remain separate prerequisites. No second Workflow / Task, lifecycle truth, provider routing, quarantine/security or outbound authority is introduced.This PR remains Draft until unchanged exact
2c4821fe00a9691066a86311b141a46fe8ea68e7has zero valid unresolved findings/threads and application CI, reviewer-ci, central Security Scan and patch-validator-image are all terminal GREEN. Predecessor GREEN is not transferable.Related: #584, #597.
Summary by CodeRabbit
문서
테스트