๐จ Palette: [UX improvement] HTML ๋ฆฌํฌํธ ์ ๊ทผ์ฑ ๋ฐ ์๊ฐ์ ๊ฐ์ - #561
๐จ Palette: [UX improvement] HTML ๋ฆฌํฌํธ ์ ๊ทผ์ฑ ๋ฐ ์๊ฐ์ ๊ฐ์ #561seonghobae wants to merge 1 commit into
Conversation
- ์คํฌ๋ฆฐ ๋ฆฌ๋๊ฐ empty state๋ฅผ ์ฌ๋ฐ๋ฅด๊ฒ ์ธ์ํ๋๋ก `<p>` ํ๊ทธ ๋์ `role="status"`๊ฐ ํฌํจ๋ `<div>` ํ๊ทธ ์ฌ์ฉ - ํ ํ์ hover ์ ๋ค๋ฅธ ํ๋ค์ ๋ถํฌ๋ช ๋๋ฅผ ๋ฎ์ถฐ ์๊ฐ์ ์ง์ค๋๋ฅผ ๋์ด๋ CSS ์ถ๊ฐ - ๋ง์ฐ์ค ํด๋ฆญ ์ `<main>` ์์์ focus outline ์จ๊น ์ฒ๋ฆฌ (ํค๋ณด๋ ๋ค๋น๊ฒ์ด์ ์์๋ ์ ์ง)
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
๐ WalkthroughWalkthroughThe change updates standalone report focus and table-row styling. It changes empty validation identifier output to a status-region ChangesHTML report updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
๐ฅ Pre-merge checks | โ 5โ Passed checks (5 passed)
โจ Finishing Touches๐ Generate docstrings
๐งช Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
๐ค Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@python/fast_mlsirm/scoring/essay/report_html.py`:
- Around line 188-190: Update the table hover CSS rules in the report HTML
styling to remove the row-level opacity applied by tbody:hover tr:not(:hover),
keeping table-row contentโincluding text, borders, and focus indicatorsโat full
opacity while preserving the existing hover background behavior.
๐ช Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
โน๏ธ Review info
โ๏ธ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: c97e0daf-a4ea-4f75-b987-26e3bbc87abd
๐ Files selected for processing (4)
python/fast_mlsirm/scoring/essay/report_html.pypython/fast_mlsirm/scoring/essay/validation_report_html.pytests/test_scoring_essay_report_html.pytests/test_scoring_essay_validation_report_html.py
| tbody tr { transition: background-color 0.15s ease-in-out, opacity 0.15s ease-in-out; } | ||
| tbody tr:hover { background-color: rgba(128, 128, 128, 0.15); } | ||
| tbody:hover tr:not(:hover) { opacity: 0.5; } |
There was a problem hiding this comment.
๐ฏ Functional Correctness | ๐ Major | โก Quick win
Keep table-row content at full opacity.
opacity: 0.5 affects the complete row, including text, borders, and focus indicators. In the light color scheme, this can reduce normal text contrast below the accessible threshold. If a row contains a focusable control, the control can also remain dim while the pointer stays inside tbody. Remove row-level opacity or apply the effect only to non-text decoration.
๐ค Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@python/fast_mlsirm/scoring/essay/report_html.py` around lines 188 - 190,
Update the table hover CSS rules in the report HTML styling to remove the
row-level opacity applied by tbody:hover tr:not(:hover), keeping table-row
contentโincluding text, borders, and focus indicatorsโat full opacity while
preserving the existing hover background behavior.
|
Closing this mixed-scope UX change rather than merging a regression. The |
|
Closing because the proposed bundle is not an accessibility improvement for this static standalone report. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
|
Closing as not mergeable in its current form. The patch reintroduces |
|
Closing this automation branch because it conflicts with the accepted accessibility direction and mixes an unrelated static empty-state change into the report styling repair. It reintroduces |
|
Closing rather than merging this mixed change. The peer-row opacity rule reverses the reviewed contrast-preservation contract in #550 by dimming unrelated table data, and |
|
Closing this automation PR rather than merging the mixed accessibility changes. The new |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
๐ก What:
_identifier_list์ empty state๋ฅผ<p>ํ๊ทธ์์<div role="status">๋ก ๋ณ๊ฒฝํ์ฌ ARIA ๋ผ์ด๋ธ ์์ญ์ผ๋ก ์ง์ ํ์ต๋๋ค.tbody:hover tr:not(:hover) { opacity: 0.5; })์ ์ถ๊ฐํ์ฌ ํ์ ํน์ ํ์ ๋ง์ฐ์ค๋ฅผ ์ฌ๋ ธ์ ๋ ๋ค๋ฅธ ํ๋ค์ ๋ถํฌ๋ช ๋๋ฅผ ๋ฎ์ท์ต๋๋ค.main:focus { outline: none; }์ ์ถ๊ฐํ์ฌ ๋ง์ฐ์ค ํด๋ฆญ ์ ๋ถํ์ํ ํฌ์ปค์ค ์์๋ผ์ธ์ด ๋ํ๋์ง ์๋๋ก ํ์ต๋๋ค (focus-visible์ ์ ์ง๋์ด ํค๋ณด๋ ์ ๊ทผ์ฑ ๋ณด์ฅ).๐ฏ Why:
<main>์์ญ ์ ์ฒด์ ์์๋ผ์ธ์ด ์๊ธฐ๋ ์๊ฐ์ ๋ฒ๊ทธ๋ฅผ ํด๊ฒฐํ์ฌ ๋ ๊น๋ํ UI๋ฅผ ์ ๊ณตํฉ๋๋ค.๐ธ Before/After:
Skip to content๋ฑ์ ๊ธฐ๋ฅ์ผ๋ก<main>์์ญ ํด๋ฆญ ์ ๊ตต์ ์์๋ผ์ธ์ด ํ์๋จ.role="status"๋ก ๋ ๋๋ง๋์ด ์คํฌ๋ฆฐ ๋ฆฌ๋๊ฐ ์ฆ์ ์ฝ์ด์ฃผ๋ฉฐ, ํ์์ ํน์ ํ์ ๋ง์ฐ์ค๋ฅผ ์ฌ๋ฆฌ๋ฉด ๋ค๋ฅธ ํ๋ค์ด ํฌ๋ฏธํด์ ธ ์ ํํ ๋ฐ์ดํฐ์ ์จ์ ํ ์ง์คํ ์ ์์. ๋ํ ๋ง์ฐ์ค ํด๋ฆญ ์ ๋ถํ์ํ ์์๋ผ์ธ์ด ์ ๊ฑฐ๋จ.โฟ Accessibility:
role="status"๋ฅผ ํตํด ๋น ์ํ ๋ฉ์์ง์ ๋ํ ์คํฌ๋ฆฐ ๋ฆฌ๋์ ๋ผ์ด๋ธ ์์ญ ์ง์ ๊ฐ์:focus์:focus-visible์ ๋ถ๋ฆฌํ์ฌ ๋ง์ฐ์ค ์ฌ์ฉ์์ ์๊ฐ์ ๋ฐฉํด ์์๋ ์ ๊ฑฐํ๋ฉด์๋ ํค๋ณด๋ ๋ด๋น๊ฒ์ด์ ์ฌ์ฉ์์ ์ ๊ทผ์ฑ(์ด์ ๊ฐ์์ฑ)์ ๊ทธ๋๋ก ๋ณด์ฅPR created automatically by Jules for task 12954787463374055146 started by @seonghobae
Summary by CodeRabbit
Accessibility
Visual Improvements
Tests