Skip to content

🎨 Palette: ν‚€λ³΄λ“œ μ‚¬μš©μ„± ν–₯상을 μœ„ν•œ ν…Œμ΄λΈ” 및 μ½”λ“œ μ»¨ν…Œμ΄λ„ˆ 포컀슀 μŠ€νƒ€μΌλ§ - #1298

Closed
seonghobae wants to merge 1 commit into
mainfrom
palette-focus-visible-18271883918546270827
Closed

🎨 Palette: ν‚€λ³΄λ“œ μ‚¬μš©μ„± ν–₯상을 μœ„ν•œ ν…Œμ΄λΈ” 및 μ½”λ“œ μ»¨ν…Œμ΄λ„ˆ 포컀슀 μŠ€νƒ€μΌλ§#1298
seonghobae wants to merge 1 commit into
mainfrom
palette-focus-visible-18271883918546270827

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

πŸ’‘ What
fast_mlsirm/scoring/essay/report_html.py의 HTML 리포트 CSS에 .table-scroll 및 pre μš”μ†Œμ˜ 마우슀 클릭(pointer focus) μ‹œ 포컀슀 링을 μˆ¨κΈ°λŠ” κ·œμΉ™(:focus:not(:focus-visible) { outline: none; })을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€. ν‚€λ³΄λ“œ λ„€λΉ„κ²Œμ΄μ…˜ μ‹œμ—λŠ” :focus-visible κ·œμΉ™μ„ 톡해 포컀슀 링이 μ •μƒμ μœΌλ‘œ λ‚˜νƒ€λ‚˜λ„λ‘ μœ μ§€ν–ˆμŠ΅λ‹ˆλ‹€.
이에 따라 κ΄€λ ¨ ν…ŒμŠ€νŠΈ 파일(test_scoring_essay_report_html.py, test_scoring_essay_report_pointer_focus.py)의 assertion도 ν•¨κ»˜ μ—…λ°μ΄νŠΈν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why
ν…Œμ΄λΈ”(table-scroll)κ³Ό μ½”λ“œ 블둝(pre)은 슀크둀이 κ°€λŠ₯ν•˜λ„λ‘ tabindex="0"이 μ„€μ •λ˜μ–΄ μžˆλŠ”λ°, 마우슀 클릭으둜 이 μš”μ†Œλ“€κ³Ό μƒν˜Έμž‘μš©ν•  λ•Œ λΈŒλΌμš°μ € κΈ°λ³Έ 포컀슀 링이 λ‘κ»κ²Œ λ‚˜νƒ€λ‚˜ μ‹œκ°μ μœΌλ‘œ 거슬리고(noise) λ””μžμΈ 완성도λ₯Ό λ–¨μ–΄λœ¨λ¦¬λŠ” λ¬Έμ œκ°€ μžˆμ—ˆμŠ΅λ‹ˆλ‹€.

πŸ“Έ Before/After

  • Before: 마우슀 클릭 μ‹œ λ‘κΊΌμš΄ Highlight μƒ‰μƒμ˜ 포컀슀 링이 λ‚˜νƒ€λ‚¨.
  • After: 마우슀 클릭 μ‹œ 포컀슀 링이 λ‚˜νƒ€λ‚˜μ§€ μ•ŠμœΌλ©°, Tab ν‚€λ₯Ό μ΄μš©ν•œ ν‚€λ³΄λ“œ λ„€λΉ„κ²Œμ΄μ…˜ μ‹œμ—λ§Œ 포컀슀 링이 λ‚˜νƒ€λ‚¨.

β™Ώ Accessibility
마우슀/ν„°μΉ˜ μœ μ €μ˜ μ‹œκ°μ  λΆˆνŽΈν•¨μ„ ν•΄μ†Œν•˜λ©΄μ„œλ„, ν‚€λ³΄λ“œ μ „μš© μ‚¬μš©μžλ₯Ό μœ„ν•œ 포컀슀 인디케이터(Focus Indicator)λŠ” μ˜¨μ „νžˆ λ³΄μ‘΄ν•˜μ—¬ WCAG 포컀슀 κ°€μ‹œμ„± μš”κ±΄μ„ μΆ©μ‘±ν–ˆμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 18271883918546270827 started by @seonghobae


Open in Devin Review

Summary by CodeRabbit

  • Accessibility

    • Improved focus styling in reports by hiding outlines for pointer-focused scrollable tables and preformatted content while preserving visible keyboard-focus indicators.
  • Tests

    • Added regression coverage to verify accessible focus behavior across supported report elements.

This commit updates the CSS in `fast_mlsirm/scoring/essay/report_html.py` to suppress default browser focus outlines on pointer interactions for scrollable elements (`.table-scroll` and `pre`). It preserves focus outlines for keyboard navigation via `:focus-visible`.

Corresponding tests in `test_scoring_essay_report_html.py` and `test_scoring_essay_report_pointer_focus.py` were updated to reflect these changes.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 08d384d0-1da7-41b0-a790-149018cc3692

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 04d0bc2 and 6bbb66e.

πŸ“’ Files selected for processing (3)
  • python/fast_mlsirm/scoring/essay/report_html.py
  • tests/test_scoring_essay_report_html.py
  • tests/test_scoring_essay_report_pointer_focus.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


πŸ“ Walkthrough

Walkthrough

The report CSS now suppresses outlines for pointer-focused .table-scroll and pre elements. Keyboard focus remains visibly styled. Tests verify both behaviors.

Changes

Focus outline accessibility

Layer / File(s) Summary
Conditional focus styling and regression coverage
python/fast_mlsirm/scoring/essay/report_html.py, tests/test_scoring_essay_report_html.py, tests/test_scoring_essay_report_pointer_focus.py
The renderer adds :focus:not(:focus-visible) outline suppression for .table-scroll and pre. Tests verify pointer-focus suppression and visible keyboard-focus outlines.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: βšͺ Minimal Β· up to 6bbb6

This localized styling change hides focus rings for pointer interaction while preserving keyboard-visible focus indicators, with matching test updates; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed The title clearly describes the focus styling changes for tables and code containers, including the keyboard usability objective.
Docstring Coverage βœ… Passed Docstring check was indeterminate for this PR β€” some files could not be analyzed in time. Not blocking.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
πŸ“ Generate docstrings
  • Create stacked PR
  • Commit on current branch
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-focus-visible-18271883918546270827

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@seonghobae seonghobae closed this Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant