π¨ Palette: ν€λ³΄λ μ¬μ©μ± ν₯μμ μν ν μ΄λΈ λ° μ½λ 컨ν μ΄λ ν¬μ»€μ€ μ€νμΌλ§ - #1298
Conversation
This commit updates the CSS in `fast_mlsirm/scoring/essay/report_html.py` to suppress default browser focus outlines on pointer interactions for scrollable elements (`.table-scroll` and `pre`). It preserves focus outlines for keyboard navigation via `:focus-visible`. Corresponding tests in `test_scoring_essay_report_html.py` and `test_scoring_essay_report_pointer_focus.py` were updated to reflect these changes.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. π WalkthroughWalkthroughThe report CSS now suppresses outlines for pointer-focused ChangesFocus outline accessibility
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: βͺ Minimal Β· up to This localized styling change hides focus rings for pointer interaction while preserving keyboard-visible focus indicators, with matching test updates; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
π₯ Pre-merge checks | β 5β Passed checks (5 passed)
β¨ Finishing Touchesπ Generate docstrings
π§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
π‘ What
fast_mlsirm/scoring/essay/report_html.pyμ HTML 리ν¬νΈ CSSμ.table-scrollλ°preμμμ λ§μ°μ€ ν΄λ¦(pointer focus) μ ν¬μ»€μ€ λ§μ μ¨κΈ°λ κ·μΉ(:focus:not(:focus-visible) { outline: none; })μ μΆκ°νμ΅λλ€. ν€λ³΄λ λ€λΉκ²μ΄μ μμλ:focus-visibleκ·μΉμ ν΅ν΄ ν¬μ»€μ€ λ§μ΄ μ μμ μΌλ‘ λνλλλ‘ μ μ§νμ΅λλ€.μ΄μ λ°λΌ κ΄λ ¨ ν μ€νΈ νμΌ(
test_scoring_essay_report_html.py,test_scoring_essay_report_pointer_focus.py)μ assertionλ ν¨κ» μ λ°μ΄νΈνμ΅λλ€.π― Why
ν μ΄λΈ(
table-scroll)κ³Ό μ½λ λΈλ‘(pre)μ μ€ν¬λ‘€μ΄ κ°λ₯νλλ‘tabindex="0"μ΄ μ€μ λμ΄ μλλ°, λ§μ°μ€ ν΄λ¦μΌλ‘ μ΄ μμλ€κ³Ό μνΈμμ©ν λ λΈλΌμ°μ κΈ°λ³Έ ν¬μ»€μ€ λ§μ΄ λκ»κ² λνλ μκ°μ μΌλ‘ κ±°μ¬λ¦¬κ³ (noise) λμμΈ μμ±λλ₯Ό λ¨μ΄λ¨λ¦¬λ λ¬Έμ κ° μμμ΅λλ€.πΈ Before/After
Tabν€λ₯Ό μ΄μ©ν ν€λ³΄λ λ€λΉκ²μ΄μ μμλ§ ν¬μ»€μ€ λ§μ΄ λνλ¨.βΏ Accessibility
λ§μ°μ€/ν°μΉ μ μ μ μκ°μ λΆνΈν¨μ ν΄μνλ©΄μλ, ν€λ³΄λ μ μ© μ¬μ©μλ₯Ό μν ν¬μ»€μ€ μΈλμΌμ΄ν°(Focus Indicator)λ μ¨μ ν 보쑴νμ¬ WCAG ν¬μ»€μ€ κ°μμ± μ건μ μΆ©μ‘±νμ΅λλ€.
PR created automatically by Jules for task 18271883918546270827 started by @seonghobae
Summary by CodeRabbit
Accessibility
Tests