a11y(report): scope criterion row headers explicitly - #556
Conversation
💡 What:
1. Updated HTML table generation to use `<th scope="row">` for first columns instead of `<td>` in essay reports.
2. Updated base CSS styling (`thead th, tbody th, td`) for consistency while adding `tbody th { font-weight: normal; }` to maintain visual layout without bolding.
3. Updated tooltip exact numeric string representation generation (`_title_attr`) for formatted floats to use `repr(value)` instead of `str(value)`.
🎯 Why:
1. Improved screen reader context mapping by programmatically linking table cell data with the row's identifying header.
2. Avoids jittering characters via tabular font-variant-numeric properties.
3. Ensures users examining data-heavy reports hovering over truncated or rounded floats will be able to see the unrounded, actual float values avoiding information loss.
♿ Accessibility:
Enhanced screen reader association with row data in tables via explicit scope mapping.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 3 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Comment |
|
@opencode-agent address Keep this PR Draft and turn the valid row-header idea into a bounded, tested accessibility contract. The generic |
I have added the |
💡 What:
1. Updated HTML table generation logic with an explicit `row_header` boolean parameter to optionally emit `<th scope="row">` instead of `<td>` for the first column.
2. Verified all essay score, calibration, and validation tables properly invoke this explicitly.
3. Added base CSS styling (`thead th, tbody th, td`) for visual consistency and `tbody th { font-weight: normal; }` to maintain unbolded layout.
🎯 Why:
1. Improved screen reader context mapping by programmatically associating table cells to row headers.
2. A generic override of the first cell across all tables was reverted into a bounded contract where only true row headers get `th scope="row"`.
♿ Accessibility:
Enhanced robust semantic linking for tabular data row headers.
seonghobae
changed the title
|
@opencode-agent address On exact head
|
I have executed |
💡 What:
1. Updated HTML table generation logic with an explicit `row_header` boolean parameter to optionally emit `<th scope="row">` instead of `<td>` for the first column.
2. Verified all essay score, calibration, and validation tables properly invoke this explicitly.
3. Added base CSS styling (`thead th, tbody th, td`) for visual consistency and `tbody th { font-weight: normal; }` to maintain unbolded layout.
4. Rendered the changelog with `python scripts/render_changelog_fragments.py --update CHANGELOG.md` to resolve CI fragment-validation failures.
🎯 Why:
1. Improved screen reader context mapping by programmatically associating table cells to row headers.
2. A generic override of the first cell across all tables was reverted into a bounded contract where only true row headers get `th scope="row"`.
♿ Accessibility:
Enhanced robust semantic linking for tabular data row headers.
|
@opencode-agent address Exact current head is now Perform exactly one remaining repository integration action: run |
|
@jules Please make exactly one bounded descendant commit on this PR and nothing else. Precondition: fail closed unless the live branch head is exactly Action:
Do not touch the corrected renderer, test, doctoring, changelog fragment, workflows, dependencies, PR metadata, Draft state, reviews, merge settings, version, or release state. If any precondition or check fails, make no write. |
💡 What:
1. Updated HTML table generation logic with an explicit `row_header` boolean parameter to optionally emit `<th scope="row">` instead of `<td>` for the first column.
2. Verified all essay score, calibration, and validation tables properly invoke this explicitly.
3. Added base CSS styling (`thead th, tbody th, td`) for visual consistency and `tbody th { font-weight: normal; }` to maintain unbolded layout.
4. Rendered the changelog with `python scripts/render_changelog_fragments.py --update CHANGELOG.md` to resolve CI fragment-validation failures.
🎯 Why:
1. Improved screen reader context mapping by programmatically associating table cells to row headers.
2. A generic override of the first cell across all tables was reverted into a bounded contract where only true row headers get `th scope="row"`.
♿ Accessibility:
Enhanced robust semantic linking for tabular data row headers.
|
@jules Stop work on this PR and make no further branch writes. The requested bounded changelog-only commit was not produced: head |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
💡 What:
1. Updated HTML table generation logic with an explicit `row_header` boolean parameter to optionally emit `<th scope="row">` instead of `<td>` for the first column.
2. Verified all essay score, calibration, and validation tables properly invoke this explicitly.
3. Added base CSS styling (`thead th, tbody th, td`) for visual consistency and `tbody th { font-weight: normal; }` to maintain unbolded layout.
4. Rendered the changelog with `python scripts/render_changelog_fragments.py --update CHANGELOG.md` to resolve CI fragment-validation failures.
🎯 Why:
1. Improved screen reader context mapping by programmatically associating table cells to row headers.
2. A generic override of the first cell across all tables was reverted into a bounded contract where only true row headers get `th scope="row"`.
♿ Accessibility:
Enhanced robust semantic linking for tabular data row headers.
|
@coderabbitai review @opencode-agent @cwl-noema-review Final exact-head review requested for |
|
@opencode-agent @cwl-noema-review @coderabbitai review Review exact head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
expected='c79b78327f1af6b8efae42ae8510b77030c8708f'
actual="$(git rev-parse HEAD)"
printf 'HEAD=%s\nEXPECTED=%s\n' "$actual" "$expected"
if [ "$actual" != "$expected" ]; then
echo 'ERROR: checked-out HEAD does not match the requested commit.' >&2
exit 1
fi
printf '\n== PR changed paths against merge base ==\n'
base="$(git merge-base HEAD origin/main 2>/dev/null || git merge-base HEAD main)"
git diff --name-status "$base"...HEAD
printf '\n== Commit range ==\n'
git log --oneline --decorate "$base"..HEAD
printf '\n== Candidate renderer/test/doc files ==\n'
fd -t f . | rg '(^|/)(report|render|html|table|changelog|accessible-html-table-row-headers|556-explicit-row-headers)'
printf '\n== Python symbol outlines ==\n'
fd -e py -t f . | xargs -r ast-grep outline --lang python --items all --match '_table|row_header_column|criterion|evidence|report' --view expanded 2>/dev/null || true
printf '\n== Contract and regression references ==\n'
rg -n -C 4 --glob '*.py' --glob '*.md' --glob 'CHANGELOG.md' \
'row_header_column|scope="row"|scope=.row.|HTMLParser|canonical JSON|canonical_json|render_changelog_fragments|table row header|table-header' .Length of output: 131772 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '== Exact patch =='
base="$(git merge-base HEAD origin/main 2>/dev/null || git merge-base HEAD main)"
git diff --find-renames --find-copies --unified=80 "$base"...HEAD -- \
CHANGELOG.md \
docs/changelog.d/556-explicit-row-headers.md \
docs/doctoring/accessible-html-table-row-headers.md \
python/fast_mlsirm/scoring/essay/report_html.py \
tests/test_scoring_essay_report_html_row_headers.py
echo '== Score renderer implementation =='
sed -n '1,380p' python/fast_mlsirm/scoring/essay/report_html.py
echo '== Focused full-artifact parser regression =='
cat -n tests/test_scoring_essay_report_html_row_headers.py
echo '== Existing score renderer tests =='
cat -n tests/test_scoring_essay_report_html.py
echo '== Calibration and validation _table call sites =='
rg -n -C 12 '\b_table\s*\(' \
python/fast_mlsirm/scoring/essay/calibration_report_html.py \
python/fast_mlsirm/scoring/essay/validation_report_html.py
echo '== Doctoring and changelog source =='
cat -n docs/doctoring/accessible-html-table-row-headers.md
cat -n docs/changelog.d/556-explicit-row-headers.md
echo '== Static integrity checks =='
printf 'all row_header_column references:\n'
rg -n -C 2 '\brow_header_column\b' \
python/fast_mlsirm/scoring/essay tests
printf '\nLegacy row_header parameter references in score renderer area:\n'
rg -n -C 2 '\brow_header\b' \
python/fast_mlsirm/scoring/essay tests/test_scoring_essay_report_html*.py || true
printf '\nTitle helper changes in PR patch:\n'
git diff "$base"...HEAD -- python/fast_mlsirm/report.py python/fast_mlsirm/report_exact_values.py
printf '\nChangelog deterministic check by source comparison only:\n'
git diff --check "$base"...HEADLength of output: 91121
The renderer uses the explicit zero-based The focused regression parses the complete artifact. It verifies criterion and evidence semantics and canonical JSON parity. The doctoring and authoritative changelog match the implementation. The net diff contains no unrelated The sandbox could not execute repository tests. I considered the reported successful current-head CI, Security Scan, and Semgrep results for the approval decision. [approve] You are interacting with an AI system. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
expected='c79b78327f1af6b8efae42ae8510b77030c8708f'
actual="$(git rev-parse HEAD)"
printf 'HEAD=%s\nEXPECTED=%s\n' "$actual" "$expected"
test "$actual" = "$expected"
printf '\n--- PR diff names relative to main ---\n'
git diff --name-status main...HEAD
printf '\n--- Changed-file diff summary ---\n'
git diff --stat main...HEAD
printf '\n--- Candidate table/render/test/doc files ---\n'
fd -t f . | rg '(report|table|accessible-html-table-row-headers|556-explicit-row-headers|CHANGELOG)'
printf '\n--- row_header_column references with context ---\n'
rg -n -C 4 '\brow_header_column\b|\brow_header\b' .
printf '\n--- Relevant Python outlines ---\n'
while IFS= read -r file; do
ast-grep outline "$file" --items all --type function,class --view expanded
done < <(fd -e py -t f . | xargs -r rg -l '\brow_header_column\b|\bdef _table\b')Length of output: 13635 🏁 Script executed: #!/bin/bash
set -euo pipefail
expected='c79b78327f1af6b8efae42ae8510b77030c8708f'
test "$(git rev-parse HEAD)" = "$expected"
printf '%s\n' '--- Complete PR diff ---'
git diff --no-ext-diff --unified=80 main...HEAD -- \
CHANGELOG.md \
docs/changelog.d/556-explicit-row-headers.md \
docs/doctoring/accessible-html-table-row-headers.md \
python/fast_mlsirm/scoring/essay/report_html.py \
tests/test_scoring_essay_report_html_row_headers.py
printf '%s\n' '--- Renderer structure ---'
ast-grep outline python/fast_mlsirm/scoring/essay/report_html.py --items all --type function,class --view expanded
printf '%s\n' '--- Renderer table implementation and call sites ---'
sed -n '1,145p;220,310p' python/fast_mlsirm/scoring/essay/report_html.py
printf '%s\n' '--- Complete regression test ---'
cat -n tests/test_scoring_essay_report_html_row_headers.py
printf '%s\n' '--- Doctoring record ---'
cat -n docs/doctoring/accessible-html-table-row-headers.md
printf '%s\n' '--- Changelog fragment and rendered entry ---'
cat -n docs/changelog.d/556-explicit-row-headers.md
sed -n '155,190p' CHANGELOG.mdLength of output: 66626 🏁 Script executed: #!/bin/bash
set -euo pipefail
expected='c79b78327f1af6b8efae42ae8510b77030c8708f'
test "$(git rev-parse HEAD)" = "$expected"
printf '%s\n' '--- All _table definitions and calls ---'
rg -n -C 5 '\b_table\s*\(' python tests
printf '%s\n' '--- Obsolete row_header identifier references ---'
rg -n -C 3 '\brow_header\b' python tests docs CHANGELOG.md || true
printf '%s\n' '--- Existing essay score HTML test assertions for required artifact contracts ---'
rg -n -i -C 4 \
'caption|scope="col"|empty-state|table-scroll|tabindex|role="region"|script|canonical json|json\.loads|tabular-nums|reduced-motion|exact' \
tests/test_scoring_essay_report_html.py \
tests/test_report_accessibility.py \
tests/test_report_scrollable_exports_accessibility.py \
tests/test_report_exact_values.py \
tests/test_report_exact_value_titles.py \
2>/dev/null || true
printf '%s\n' '--- Focused essay HTML test file ---'
cat -n tests/test_scoring_essay_report_html.py
printf '%s\n' '--- Data-row transformations: PR base versus HEAD ---'
git diff --no-ext-diff --unified=12 main...HEAD -- \
python/fast_mlsirm/scoring/essay/report_html.py \
| sed -n '/def _criterion_rows/,/def _trigger_section/p'
printf '%s\n' '--- Rendered table and style contract lines ---'
sed -n '185,355p' python/fast_mlsirm/scoring/essay/report_html.pyLength of output: 58941
I reviewed exact head The renderer now uses an explicit zero-based The complete-artifact parser regression verifies the row-header and data-cell distinction and canonical JSON replay. Existing renderer tests cover the empty state, focusable regions, script-free output, reduced-motion behavior, and tabular numeric styling. The doctoring record and rendered authoritative changelog entry match the bounded change. I found no actionable issue. [approve] You are interacting with an AI system. |
Acknowledged. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
expected='c79b78327f1af6b8efae42ae8510b77030c8708f'
actual="$(git rev-parse HEAD)"
printf 'HEAD=%s\nEXPECTED=%s\n' "$actual" "$expected"
test "$actual" = "$expected"
base="$(git merge-base HEAD origin/main 2>/dev/null || git merge-base HEAD main)"
printf '\n== Changed paths ==\n'
git diff --name-status "$base"...HEAD
printf '\n== Diff whitespace check ==\n'
git diff --check "$base"...HEAD
printf '\n== Renderer outline ==\n'
ast-grep outline python/fast_mlsirm/scoring/essay/report_html.py \
--items all --type function,class --view expanded
printf '\n== Renderer table helper and calls ==\n'
rg -n -C 16 '\bdef _table\b|\b_table\s*\(|row_header_column|scope="row"|scope="col"' \
python/fast_mlsirm/scoring/essay/report_html.py
printf '\n== Full-artifact regression ==\n'
cat -n tests/test_scoring_essay_report_html_row_headers.py
printf '\n== Existing related report coverage ==\n'
rg -n -i -C 3 \
'caption|scope=.col.|empty.state|tabindex|role=.region.|reduced.motion|tabular-nums|script|canonical.*json|json.*canonical|exact' \
tests/test_scoring_essay_report_html.py \
tests/test_report_accessibility.py \
tests/test_report_scrollable_exports_accessibility.py \
tests/test_report_exact_values.py 2>/dev/null || true
printf '\n== Validation and legacy contract references ==\n'
rg -n -C 4 '\brow_header_column\b|\brow_header\b|isinstance\(.*bool|len\(.*headers|width' \
python/fast_mlsirm/scoring/essay tests
printf '\n== Doctoring and changelog ==\n'
cat -n docs/doctoring/accessible-html-table-row-headers.md
cat -n docs/changelog.d/556-explicit-row-headers.md
rg -n -C 4 'row header|row-header|row_header' CHANGELOG.md
printf '\n== Bounded patch ==\n'
git diff --no-ext-diff --unified=50 "$base"...HEAD -- \
CHANGELOG.md \
docs/changelog.d/556-explicit-row-headers.md \
docs/doctoring/accessible-html-table-row-headers.md \
python/fast_mlsirm/scoring/essay/report_html.py \
tests/test_scoring_essay_report_html_row_headers.pyLength of output: 118530
Static review found no actionable issue.
I did not run repository tests in this sandbox. I considered the reported successful current-head CI, Security Scan, and SAST Semgrep results. [approve] You are interacting with an AI system. |
Acknowledged. Standing by for review. |
|
@coderabbitai review @opencode-agent @cwl-noema-review Review exact head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
expected='c79b78327f1af6b8efae42ae8510b77030c8708f'
actual="$(git rev-parse HEAD)"
printf 'HEAD=%s\nEXPECTED=%s\n' "$actual" "$expected"
test "$actual" = "$expected"
base="$(git merge-base HEAD origin/main 2>/dev/null || git merge-base HEAD main)"
printf '\n== Changed paths ==\n'
git diff --name-status "$base"...HEAD
printf '\n== Whitespace check ==\n'
git diff --check "$base"...HEAD
printf '\n== Renderer outline ==\n'
ast-grep outline python/fast_mlsirm/scoring/essay/report_html.py \
--items all --type function,class --view expanded
printf '\n== Table helper, calls, and HTML semantics ==\n'
rg -n -C 18 '\bdef _table\b|\b_table\s*\(|row_header_column|scope="row"|scope="col"|len\(headers\)|isinstance\(.*bool' \
python/fast_mlsirm/scoring/essay/report_html.py
printf '\n== Focused complete-artifact regression ==\n'
cat -n tests/test_scoring_essay_report_html_row_headers.py
printf '\n== Existing report semantics and canonical JSON tests ==\n'
rg -n -i -C 3 \
'caption|scope=.col.|empty.state|tabindex|role=.region.|reduced.motion|tabular-nums|script|canonical.*json|json.*canonical|exact' \
tests/test_scoring_essay_report_html.py \
tests/test_report_accessibility.py \
tests/test_report_scrollable_exports_accessibility.py \
tests/test_report_exact_values.py 2>/dev/null || true
printf '\n== Public docstrings in changed production file ==\n'
python - <<'PY'
import ast
from pathlib import Path
path = Path("python/fast_mlsirm/scoring/essay/report_html.py")
tree = ast.parse(path.read_text(encoding="utf-8"))
for node in ast.walk(tree):
if isinstance(node, (ast.FunctionDef, ast.AsyncFunctionDef, ast.ClassDef)) and not node.name.startswith("_"):
print(f"{path}:{node.lineno}: {node.__class__.__name__} {node.name}: docstring={bool(ast.get_docstring(node))}")
PY
printf '\n== Doctoring and changelog parity ==\n'
cat -n docs/doctoring/accessible-html-table-row-headers.md
cat -n docs/changelog.d/556-explicit-row-headers.md
rg -n -i -C 5 'row.header|row_header|table semantics' CHANGELOG.md
printf '\n== Full bounded diff ==\n'
git diff --no-ext-diff --unified=55 "$base"...HEAD -- \
CHANGELOG.md \
docs/changelog.d/556-explicit-row-headers.md \
docs/doctoring/accessible-html-table-row-headers.md \
python/fast_mlsirm/scoring/essay/report_html.py \
tests/test_scoring_essay_report_html_row_headers.pyLength of output: 81029 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo='ContextualWisdomLab/fast-mlsirm'
pr='556'
sha='c79b78327f1af6b8efae42ae8510b77030c8708f'
printf '%s\n' '== PR head and check runs =='
gh api "repos/$repo/pulls/$pr" --jq '{number, draft, head_sha: .head.sha, merge_commit_sha: .merge_commit_sha}'
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" --paginate \
--jq '.check_runs[] | [.name, .status, .conclusion, .details_url] | `@tsv`'
printf '%s\n' '== Unresolved review threads =='
gh api graphql -F owner='ContextualWisdomLab' -F name='fast-mlsirm' -F number="$pr" -f query='
query($owner: String!, $name: String!, $number: Int!) {
repository(owner: $owner, name: $name) {
pullRequest(number: $number) {
reviewThreads(first: 100) {
nodes { isResolved isOutdated path line }
}
}
}
}' --jq '[.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved == false)]'Length of output: 5138
I found no actionable issue.
[approve] You are interacting with an AI system. |
Acknowledged. |
|
@coderabbitai review @opencode-agent @cwl-noema-review Re-run the independent exact-head review for |
|
@coderabbitai review Final read-only exact-head review for |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
expected='c79b78327f1af6b8efae42ae8510b77030c8708f'
actual="$(git rev-parse HEAD)"
printf 'HEAD=%s\nEXPECTED=%s\n' "$actual" "$expected"
test "$actual" = "$expected"
base="$(git merge-base HEAD origin/main 2>/dev/null || git merge-base HEAD main)"
printf '\n== Changed paths ==\n'
git diff --name-status "$base"...HEAD
printf '\n== Diff whitespace check ==\n'
git diff --check "$base"...HEAD
printf '\n== Renderer outline ==\n'
ast-grep outline python/fast_mlsirm/scoring/essay/report_html.py \
--items all --type function,class --view expanded
printf '\n== Table helper and table call sites ==\n'
rg -n -C 18 '\bdef _table\b|\b_table\s*\(|row_header_column|scope="row"|scope="col"|isinstance\(.*bool|len\(headers\)' \
python/fast_mlsirm/scoring/essay/report_html.py
printf '\n== Full-artifact parser regression ==\n'
cat -n tests/test_scoring_essay_report_html_row_headers.py
printf '\n== Existing report semantic and canonical-JSON coverage ==\n'
rg -n -i -C 3 \
'caption|scope=.col.|empty.state|tabindex|role=.region.|reduced.motion|tabular-nums|script|canonical.*json|json.*canonical|exact' \
tests/test_scoring_essay_report_html.py \
tests/test_report_accessibility.py \
tests/test_report_scrollable_exports_accessibility.py \
tests/test_report_exact_values.py 2>/dev/null || true
printf '\n== Public API docstrings in changed production file ==\n'
python - <<'PY'
import ast
from pathlib import Path
path = Path("python/fast_mlsirm/scoring/essay/report_html.py")
tree = ast.parse(path.read_text(encoding="utf-8"))
for node in ast.walk(tree):
if isinstance(node, (ast.FunctionDef, ast.AsyncFunctionDef, ast.ClassDef)) and not node.name.startswith("_"):
print(f"{path}:{node.lineno}: {node.__class__.__name__} {node.name}: docstring={bool(ast.get_docstring(node))}")
PY
printf '\n== Doctoring, fragment, and rendered changelog ==\n'
cat -n docs/doctoring/accessible-html-table-row-headers.md
cat -n docs/changelog.d/556-explicit-row-headers.md
rg -n -i -C 5 'row.header|row_header|table semantics' CHANGELOG.md
printf '\n== Bounded diff ==\n'
git diff --no-ext-diff --unified=45 "$base"...HEAD -- \
CHANGELOG.md \
docs/changelog.d/556-explicit-row-headers.md \
docs/doctoring/accessible-html-table-row-headers.md \
python/fast_mlsirm/scoring/essay/report_html.py \
tests/test_scoring_essay_report_html_row_headers.pyLength of output: 77989 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo='ContextualWisdomLab/fast-mlsirm'
pr='556'
sha='c79b78327f1af6b8efae42ae8510b77030c8708f'
printf '%s\n' '== Pull request head =='
gh api "repos/$repo/pulls/$pr" --jq '{number, draft, head_sha: .head.sha}'
printf '%s\n' '== Check runs on requested commit =='
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" --paginate \
--jq '.check_runs[] | [.name, .status, .conclusion] | `@tsv`'
printf '%s\n' '== Unresolved review threads =='
gh api graphql -F owner='ContextualWisdomLab' -F name='fast-mlsirm' -F number="$pr" -f query='
query($owner: String!, $name: String!, $number: Int!) {
repository(owner: $owner, name: $name) {
pullRequest(number: $number) {
reviewThreads(first: 100) {
nodes { isResolved isOutdated path line }
}
}
}
}' --jq '[.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved == false)]'Length of output: 2282
I found no actionable issue.
[approve] You are interacting with an AI system. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
expected='c79b78327f1af6b8efae42ae8510b77030c8708f'
actual="$(git rev-parse HEAD)"
printf 'HEAD=%s\nEXPECTED=%s\n' "$actual" "$expected"
test "$actual" = "$expected"
base="$(git merge-base HEAD origin/main 2>/dev/null || git merge-base HEAD main)"
printf '\n== Changed paths ==\n'
git diff --name-status "$base"...HEAD
printf '\n== Diff integrity ==\n'
git diff --check "$base"...HEAD
printf '\n== Renderer outline ==\n'
ast-grep outline python/fast_mlsirm/scoring/essay/report_html.py \
--items all --type function,class --view expanded
printf '\n== Table helper and renderer call sites ==\n'
rg -n -C 20 '\bdef _table\b|\b_table\s*\(|row_header_column|scope="row"|scope="col"|isinstance\(.*bool|len\(headers\)' \
python/fast_mlsirm/scoring/essay/report_html.py
printf '\n== Focused complete-artifact regression ==\n'
cat -n tests/test_scoring_essay_report_html_row_headers.py
printf '\n== Existing report semantics and JSON coverage ==\n'
rg -n -i -C 3 \
'caption|scope=.col.|empty.state|tabindex|role=.region.|reduced.motion|tabular-nums|script|canonical.*json|json.*canonical|exact' \
tests/test_scoring_essay_report_html.py \
tests/test_report_accessibility.py \
tests/test_report_scrollable_exports_accessibility.py \
tests/test_report_exact_values.py 2>/dev/null || true
printf '\n== Public production symbols and docstrings ==\n'
python - <<'PY'
import ast
from pathlib import Path
path = Path("python/fast_mlsirm/scoring/essay/report_html.py")
tree = ast.parse(path.read_text(encoding="utf-8"))
for node in ast.walk(tree):
if isinstance(node, (ast.FunctionDef, ast.AsyncFunctionDef, ast.ClassDef)) and not node.name.startswith("_"):
print(f"{node.lineno}: {node.name}: docstring={bool(ast.get_docstring(node))}")
PY
printf '\n== Doctoring and changelog parity ==\n'
cat -n docs/doctoring/accessible-html-table-row-headers.md
cat -n docs/changelog.d/556-explicit-row-headers.md
rg -n -i -C 5 'row.header|row_header|table semantics' CHANGELOG.md
printf '\n== Bounded patch ==\n'
git diff --no-ext-diff --unified=45 "$base"...HEAD -- \
CHANGELOG.md \
docs/changelog.d/556-explicit-row-headers.md \
docs/doctoring/accessible-html-table-row-headers.md \
python/fast_mlsirm/scoring/essay/report_html.py \
tests/test_scoring_essay_report_html_row_headers.py
printf '\n== Exact-head GitHub checks and unresolved threads ==\n'
repo='ContextualWisdomLab/fast-mlsirm'
pr='556'
gh api "repos/$repo/pulls/$pr" --jq '{head_sha: .head.sha, draft, state}'
gh api "repos/$repo/commits/$expected/check-runs?per_page=100" --paginate \
--jq '.check_runs[] | [.name, .status, .conclusion] | `@tsv`'
gh api graphql -F owner='ContextualWisdomLab' -F name='fast-mlsirm' -F number="$pr" -f query='
query($owner: String!, $name: String!, $number: Int!) {
repository(owner: $owner, name: $name) {
pullRequest(number: $number) {
reviewThreads(first: 100) {
nodes { isResolved isOutdated path line }
}
}
}
}' --jq '[.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved == false)]'Length of output: 80207
I found no actionable issue.
[approve] You are interacting with an AI system. |
Acknowledged. |
Acknowledged. |
|
@coderabbitai review Final exact-head review for |
Rate Limit Exceeded
|
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headc79b78327f1af6b8efae42ae8510b77030c8708f. -
Head SHA:
c79b78327f1af6b8efae42ae8510b77030c8708f -
Workflow run: 31134327487
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs (2 files)"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs (2 files)"]
R2 --> V2["docs review"]
Evidence --> S3["Test: test_scoring_essay_report_html_row_headers.py"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test: test_scoring_essay_report_html_row_headers.py"]
R3 --> V3["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs (2 files)"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs (2 files)"]
R2 --> V2["docs review"]
Evidence --> S3["Test: test_scoring_essay_report_html_row_headers.py"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test: test_scoring_essay_report_html_row_headers.py"]
R3 --> V3["targeted test run"]
|
|
@coderabbitai review Review the exact live head only. Verify report first-column cells are genuine row headers with scope=row and appropriate visual weight, CSS preserves table alignment and screen-reader associations, tooltip precision represents the intended statistical value rather than misleading binary-float noise, HTML escaping remains complete, and realistic psychometric report fixtures cover accessible tables and exact displayed/underlying values. Require current Python/Rust tests, true-parameter recovery/RMSE evidence where affected, 100% production coverage/docstrings, security gates, and zero unresolved threads. Review only; do not update the branch, merge, release, or alter protections. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
repo='ContextualWisdomLab/fast-mlsirm'
pr='556'
expected='c79b78327f1af6b8efae42ae8510b77030c8708f'
echo '== Live PR state =='
gh api "repos/$repo/pulls/$pr" --jq '{number, state, draft, head_sha: .head.sha, base_ref: .base.ref}'
actual="$(git rev-parse HEAD)"
printf 'checked_out_head=%s\nexpected_head=%s\n' "$actual" "$expected"
if [ "$actual" != "$expected" ]; then
echo 'ERROR: checked-out repository head is not the requested exact head.' >&2
exit 1
fi
base="$(git merge-base HEAD origin/main 2>/dev/null || git merge-base HEAD main)"
printf 'merge_base=%s\n' "$base"
echo '== Changed paths and diff integrity =='
git diff --name-status "$base"...HEAD
git diff --check "$base"...HEAD
echo '== Renderer structure =='
ast-grep outline python/fast_mlsirm/scoring/essay/report_html.py \
--items all --type function,class --view expanded
echo '== Table helper, cell semantics, CSS, title formatting, and escaping =='
rg -n -C 16 \
'\bdef _table\b|\b_table\s*\(|row_header_column|scope="row"|scope="col"|<th|<td|font-weight|font_weight|text-align|table-layout|title=|_title_attr|escape\(|html\.escape|HTMLParser' \
python/fast_mlsirm/scoring/essay/report_html.py \
python/fast_mlsirm/report.py \
python/fast_mlsirm/report_exact_values.py \
2>/dev/null || true
echo '== Complete changed renderer =='
cat -n python/fast_mlsirm/scoring/essay/report_html.py
echo '== Focused row-header regression =='
cat -n tests/test_scoring_essay_report_html_row_headers.py
echo '== Related renderer, exact-value, escaping, and psychometric recovery/RMSE tests =='
rg -n -i -C 4 \
'tooltip|title=|exact|underlying|displayed|escape|html|scope=.row.|caption|tabindex|role=.region.|recovery|true.parameter|rmse' \
tests/test_scoring_essay_report_html.py \
tests/test_report_accessibility.py \
tests/test_report_scrollable_exports_accessibility.py \
tests/test_report_exact_values.py \
tests/test_report_exact_value_titles.py \
tests \
2>/dev/null | head -n 1200
echo '== Changed production public symbols and docstrings =='
python - <<'PY'
import ast
from pathlib import Path
path = Path("python/fast_mlsirm/scoring/essay/report_html.py")
tree = ast.parse(path.read_text(encoding="utf-8"))
for node in ast.walk(tree):
if isinstance(node, (ast.FunctionDef, ast.AsyncFunctionDef, ast.ClassDef)) and not node.name.startswith("_"):
print(f"{node.lineno}: {node.__class__.__name__} {node.name}: docstring={bool(ast.get_docstring(node))}")
PY
echo '== Doctoring and changelog =='
cat -n docs/doctoring/accessible-html-table-row-headers.md
cat -n docs/changelog.d/556-explicit-row-headers.md
rg -n -i -C 5 'row.header|row_header|table semantics' CHANGELOG.md
echo '== Full bounded patch =='
git diff --no-ext-diff --unified=45 "$base"...HEAD -- \
CHANGELOG.md \
docs/changelog.d/556-explicit-row-headers.md \
docs/doctoring/accessible-html-table-row-headers.md \
python/fast_mlsirm/scoring/essay/report_html.py \
tests/test_scoring_essay_report_html_row_headers.py
echo '== Exact-head check runs =='
gh api "repos/$repo/commits/$expected/check-runs?per_page=100" --paginate \
--jq '.check_runs[] | [.name, .status, .conclusion] | `@tsv`'
echo '== Unresolved review threads =='
gh api graphql -F owner='ContextualWisdomLab' -F name='fast-mlsirm' -F number="$pr" -f query='
query($owner: String!, $name: String!, $number: Int!) {
repository(owner: $owner, name: $name) {
pullRequest(number: $number) {
reviewThreads(first: 100) {
nodes { isResolved isOutdated path line }
}
}
}
}' --jq '[.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved == false)]'Length of output: 220336
Pull request The bounded PR change is correct.
One requested condition is not met outside this PR’s diff. This tooltip issue is outside the bounded and closed PR. It should be handled in a separate follow-up issue or PR. You are interacting with an AI system. |
Acknowledged. |
Acknowledged. |
|
@opencode-agent review Re-evaluate the live exact current head under the repaired central coverage contract. Verify zero-based |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
repo='ContextualWisdomLab/fast-mlsirm'
pr='556'
echo '== Live pull request state =='
gh api "repos/$repo/pulls/$pr" --jq '{number, state, draft, head_sha: .head.sha, base_ref: .base.ref}'
head="$(gh api "repos/$repo/pulls/$pr" --jq '.head.sha')"
checked_out="$(git rev-parse HEAD)"
printf 'live_head=%s\nchecked_out_head=%s\n' "$head" "$checked_out"
if [ "$checked_out" != "$head" ]; then
echo 'ERROR: checked-out repository state does not match the live pull request head.' >&2
exit 1
fi
base="$(git merge-base HEAD origin/main 2>/dev/null || git merge-base HEAD main)"
printf 'merge_base=%s\n' "$base"
echo '== Changed paths and diff integrity =='
git diff --name-status "$base"...HEAD
git diff --check "$base"...HEAD
echo '== Renderer structure =='
ast-grep outline python/fast_mlsirm/scoring/essay/report_html.py \
--items all --type function,class --view expanded
echo '== Table contract, semantics, escaping, and renderer calls =='
rg -n -C 16 \
'\bdef _table\b|\b_table\s*\(|row_header_column|scope="row"|scope="col"|isinstance\(.*bool|len\(headers\)|len\(row\)|escape\(|html\.escape|caption|tabindex|role="region"' \
python/fast_mlsirm/scoring/essay/report_html.py
echo '== Focused complete-artifact regression =='
cat -n tests/test_scoring_essay_report_html_row_headers.py
echo '== Existing report semantic and JSON regression evidence =='
rg -n -i -C 3 \
'caption|scope=.col.|empty.state|tabindex|role=.region.|reduced.motion|tabular-nums|script|canonical.*json|json.*canonical|exact' \
tests/test_scoring_essay_report_html.py \
tests/test_report_accessibility.py \
tests/test_report_scrollable_exports_accessibility.py \
tests/test_report_exact_values.py 2>/dev/null || true
echo '== Changed production public symbols and docstrings =='
python - <<'PY'
import ast
from pathlib import Path
path = Path("python/fast_mlsirm/scoring/essay/report_html.py")
tree = ast.parse(path.read_text(encoding="utf-8"))
for node in ast.walk(tree):
if isinstance(node, (ast.FunctionDef, ast.AsyncFunctionDef, ast.ClassDef)) and not node.name.startswith("_"):
print(f"{path}:{node.lineno}: {node.__class__.__name__} {node.name}: docstring={bool(ast.get_docstring(node))}")
PY
echo '== Doctoring, changelog fragment, and rendered changelog =='
cat -n docs/doctoring/accessible-html-table-row-headers.md
cat -n docs/changelog.d/556-explicit-row-headers.md
rg -n -i -C 5 'row.header|row_header|table semantics' CHANGELOG.md
echo '== Bounded patch =='
git diff --no-ext-diff --unified=45 "$base"...HEAD -- \
CHANGELOG.md \
docs/changelog.d/556-explicit-row-headers.md \
docs/doctoring/accessible-html-table-row-headers.md \
python/fast_mlsirm/scoring/essay/report_html.py \
tests/test_scoring_essay_report_html_row_headers.py
echo '== Current-head check runs =='
gh api "repos/$repo/commits/$head/check-runs?per_page=100" --paginate \
--jq '.check_runs[] | [.name, .status, .conclusion] | `@tsv`'
echo '== Unresolved review threads =='
gh api graphql -F owner='ContextualWisdomLab' -F name='fast-mlsirm' -F number="$pr" -f query='
query($owner: String!, $name: String!, $number: Int!) {
repository(owner: $owner, name: $name) {
pullRequest(number: $number) {
reviewThreads(first: 100) {
nodes { isResolved isOutdated path line }
}
}
}
}' --jq '[.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved == false)]'Length of output: 87321
I found no actionable defect in the bounded change.
Pull request You are interacting with an AI system. |
Acknowledged. |
|
@jules Reconcile this exact accessibility slice with the live protected |
|
@opencode-agent address Continue the current PR in place. Refetch the live head/base, reviews, unresolved threads, and every GitHub Check; fix all valid current-head defects directly and keep working while reviews/checks run. Retain Rust CPU multithreading and GPU execution with low context switching; true-parameter RMSE/recovery tests; multilevel/multiple-membership and temporal modeling; Python 3.14; 100% production statement/branch coverage and public docstrings; package, security, SBOM and provenance checks; APA 7 doctoring; and CHANGELOG/version discipline. Once central |
1 participant
What
Make governed essay-score table semantics explicit and fail closed.
row_headerBoolean with a zero-basedrow_header_columncontract;<th scope="row">only for criterion identifiers in the criterion-outcomes table;<td>semantics for all source-text-free evidence-reference values;mainrather than expanding this bounded change across unrelated tables.Regression evidence
A complete standalone score report is parsed with Python's standard-library
HTMLParser. The focused regression verifies:<th scope="row">;<td>;<td>;Standards and interpretation boundary
docs/doctoring/accessible-html-table-row-headers.mdrecords WCAG 2.2 Success Criterion 1.3.1, W3C table-header guidance, failure conditions, APA 7th references, and the limits of this accessibility evidence. Correct table semantics do not establish psychometric validity, fairness, reliability, full-product WCAG conformance, or deployment authorization.Exact-head evidence
Exact current head:
c79b78327f1af6b8efae42ae8510b77030c8708f.Successful on this head:
The authoritative changelog block is rendered, public docstrings and focused production statement/branch coverage are complete, and unresolved inline review threads are zero.
Merge contract
Keep this PR unmerged until current-head CodeRabbit, OpenCode/Noema, an independent non-author approval, and all branch-protection gates are satisfied. No skipped, predecessor-head, author-only, or local-only evidence transfers. Auto-merge is enabled but remains subordinate to those protections.