🛡️ Sentinel: [HIGH] hmac.compare_digest() 비-ASCII 문자열 비교 오류로 인한 잠재적 DoS 취약점 수정

[seonghobae]

🚨 심각도: HIGH
💡 취약점: saas_web.py의 require_api_key 미들웨어에서 API 키를 검증할 때 hmac.compare_digest()를 사용합니다. 하지만 이 함수는 비-ASCII 문자열이 포함된 문자열을 비교할 때 TypeError를 발생시킵니다. 공격자가 악의적으로 x-api-key 헤더에 한글 등 비-ASCII 문자를 전송하면 500 서버 오류가 발생합니다.
🎯 영향: 처리되지 않은 예외 발생으로 인한 애플리케이션 충돌 및 서비스 거부(DoS) 공격에 악용될 수 있습니다.
🔧 수정: hmac.compare_digest()에 인자를 전달하기 전에 두 값을 모두 .encode('utf-8')로 바이트(bytes) 형태로 변환하여 비교하도록 수정했습니다.
✅ 확인: Starlette Request 객체를 직접 모킹하여 비-ASCII 헤더가 포함된 요청을 require_api_key 미들웨어에 전달하는 단위 테스트를 추가하고 통과함을 확인했습니다.

---

PR created automatically by Jules for task 10056611304526299262 started by @seonghobae

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 87a961df-bca9-4c9c-83f2-0551be7c04f1

📥 Commits

Reviewing files that changed from the base of the PR and between a8e4956 and 9fd8b6d.

⛔ Files ignored due to path filters (3)

• docs/papers/2212.04356-whisper.pdf is excluded by !**/*.pdf
• docs/standards/NIST.FIPS.180-4.pdf is excluded by !**/*.pdf
• rust-core/Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (25)

• .coveragerc
• .github/workflows/ci.yml
• .gitignore
• .jules/sentinel.md
• CHANGELOG.md
• README.md
• audio_library.py
• docs/architecture/gpu-transcription-rust-backend.md
• docs/architecture/segmentation-reconciliation.md
• pyproject.toml
• requirements-macos-mlx-lock.txt
• rust-core/Cargo.toml
• rust-core/src/lib.rs
• rust-core/src/main.rs
• rust-toolchain.toml
• saas_web.py
• scripts/benchmark_segmentation.py
• scripts/bootstrap_macos_gpu_runtime.sh
• tests/test_audio_library.py
• tests/test_chapters.py
• tests/test_ci_workflow.py
• tests/test_macos_gpu_bootstrap.py
• tests/test_mcp_driver.py
• tests/test_media_shrinker.py
• tests/test_saas_web.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[opencode-agent]

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head c588de01a438d2526c37d9a7f3afa812d63fe88d.

• Head SHA: c588de01a438d2526c37d9a7f3afa812d63fe88d

• Workflow run: 31381278538

• Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (2 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (2 files)"]
  R1 --> V1["required checks"]
  Evidence --> S2["Test: test_saas_web.py"]
  S2 --> I2["regression suite"]
  I2 --> R2["Review risk: Test: test_saas_web.py"]
  R2 --> V2["targeted test run"]

Loading

[opencode-agent]

OpenCode Review Overview

• Head SHA: 9fd8b6d2156459399641dac48509acc4e015b9e1
• Workflow run: 31844134455
• Workflow attempt: 1
• Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 9fd8b6d2156459399641dac48509acc4e015b9e1.

• Head SHA: 9fd8b6d2156459399641dac48509acc4e015b9e1

• Workflow run: 31844134455

• Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (16 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (16 files)"]
  R1 --> V1["required checks"]
  Evidence --> S2["Workflow: ci.yml"]
  S2 --> I2["GitHub Actions review job"]
  I2 --> R2["Review risk: Workflow: ci.yml"]
  R2 --> V2["actionlint plus required checks"]
  Evidence --> S3["Docs (4 files)"]
  S3 --> I3["operator or user guidance"]
  I3 --> R3["Review risk: Docs (4 files)"]
  R3 --> V3["docs review"]
  Evidence --> S4["Test (7 files)"]
  S4 --> I4["regression suite"]
  I4 --> R4["Review risk: Test (7 files)"]
  R4 --> V4["targeted test run"]

Loading

[opencode-agent]

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 9fd8b6d2156459399641dac48509acc4e015b9e1.

• Head SHA: 9fd8b6d2156459399641dac48509acc4e015b9e1

• Workflow run: 31844134455

• Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (16 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (16 files)"]
  R1 --> V1["required checks"]
  Evidence --> S2["Workflow: ci.yml"]
  S2 --> I2["GitHub Actions review job"]
  I2 --> R2["Review risk: Workflow: ci.yml"]
  R2 --> V2["actionlint plus required checks"]
  Evidence --> S3["Docs (4 files)"]
  S3 --> I3["operator or user guidance"]
  I3 --> R3["Review risk: Docs (4 files)"]
  R3 --> V3["docs review"]
  Evidence --> S4["Test (7 files)"]
  S4 --> I4["regression suite"]
  I4 --> R4["Review risk: Test (7 files)"]
  R4 --> V4["targeted test run"]

Loading

[seonghobae]

Closing as a duplicate and unsafe predecessor of #376. Both target the same non-ASCII hmac.compare_digest() failure, while #376 carries the reviewed registry-backed, byte-oriented fix on current main with focused authentication regressions. This branch additionally contains 28 changed paths and 29,604 deletions unrelated to the vulnerability, so none of its stale check or review evidence is transferable.

[google-labs-jules]

Closing as a duplicate and unsafe predecessor of #376. Both target the same non-ASCII hmac.compare_digest() failure, while #376 carries the reviewed registry-backed, byte-oriented fix on current main with focused authentication regressions. This branch additionally contains 28 changed paths and 29,604 deletions unrelated to the vulnerability, so none of its stale check or review evidence is transferable.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.