🛡️ Sentinel: [HIGH] hmac.compare_digest 비-ASCII 문자열 처리 중 발생하는 DoS 취약점 수정

[seonghobae]

🚨 Severity: HIGH
💡 Vulnerability: x-api-key 헤더에 비-ASCII 문자열이 포함될 경우 hmac.compare_digest에서 TypeError가 발생하여 500 서버 에러 및 DoS를 유발할 수 있습니다.
🎯 Impact: 악의적인 사용자가 비-ASCII 문자가 포함된 헤더를 지속적으로 전송하여 서버 가용성을 저하시킬 수 있습니다.
🔧 Fix: hmac.compare_digest를 호출하기 전에 제공된 키와 설정된 키를 명시적으로 utf-8 바이트로 인코딩하도록 수정했습니다.
✅ Verification: 비-ASCII 문자가 포함된 헤더를 처리할 때 예외 없이 401 응답을 반환하는지 확인하는 단위 테스트를 추가했습니다.

---

PR created automatically by Jules for task 12304970727575828600 started by @seonghobae

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 118 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 662f5f89-d81c-4bc6-99af-b64e259189ff

📥 Commits

Reviewing files that changed from the base of the PR and between a8e4956 and 2da4308.

📒 Files selected for processing (3)

• .jules/sentinel.md
• saas_web.py
• tests/test_saas_web.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

Closing as superseded by #390 after exact-diff review. Both branches implement the same UTF-8 byte conversion before hmac.compare_digest and the same non-ASCII-header → 401 regression. The canonical #390 branch is based on the live main tip and now also preserves this family’s one-time encoding of the provided key; this PR has no remaining unique production behavior.

[google-labs-jules]

Closing as superseded by #390 after exact-diff review. Both branches implement the same UTF-8 byte conversion before hmac.compare_digest and the same non-ASCII-header → 401 regression. The canonical #390 branch is based on the live main tip and now also preserves this family’s one-time encoding of the provided key; this PR has no remaining unique production behavior.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.