Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .coveragerc
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
[run]
source =
audio_library
chapters
diarize
job_store
Expand Down
25 changes: 0 additions & 25 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,28 +43,3 @@ jobs:

- name: Verify console entry point
run: codec-carver --help

rust:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest]
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Install Rust 1.88.0 with rustfmt
run: rustup toolchain install 1.88.0 --profile minimal --component rustfmt

- name: Report Rust toolchain
run: |
rustup run 1.88.0 rustc --version --verbose
rustup run 1.88.0 cargo --version --verbose

- name: Check Rust formatting
run: rustup run 1.88.0 cargo fmt --manifest-path rust-core/Cargo.toml -- --check

- name: Test Rust backend
run: rustup run 1.88.0 cargo test --locked --all-targets --manifest-path rust-core/Cargo.toml
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,3 @@ leak-*

# Generated conversion outputs / reports
under_2gb/

# Rust build outputs
rust-core/target/
9 changes: 4 additions & 5 deletions .jules/sentinel.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
## 2026-07-25 - [Cross-platform upload basename normalization]
**Behavior:** Upload metadata now interprets both forward slashes and backslashes as path separators before extracting a basename.
**Learning:** On POSIX systems, `pathlib.Path(filename).name` retains backslashes because they are ordinary characters there. That caused inconsistent manifest and converter filenames for Windows-style client paths. The upload itself is still written inside a trusted temporary workspace, and batch archive entry names are generated outputs; this change does not establish a filesystem traversal or archive-entry escape.
**Prevention:** Normalize client path separators before extracting a basename, retain the existing empty/`.`/`..` fallback, and test the persisted source name and manifest metadata. Treat the normalization as cross-platform consistency and defense in depth, not as evidence of a demonstrated Zip Slip exploit.

## 2026-05-28 - [Sentinel Fixes: Temp Files & Injection]
**Vulnerability:** Predictable Temp Files (CWE-377) and Insecure Default Permissions (CWE-276), plus Command Injection via FFmpeg Filtergraph (CWE-20).
**Learning:** Python's `Path.with_name` plus a suffix string to make a temp file opens a race condition because it's predictable and the permissions default to system `umask` which might expose secret `0600` data. Additionally, interpolating variables directly into FFmpeg filtergraph strings allows arbitrary filter injection.
Expand Down Expand Up @@ -65,3 +60,7 @@
**Vulnerability:** Path traversal in `media_shrinker.py` via unresolved `..` segments or symlink escapes before deriving conversion output paths.
**Learning:** `Path.relative_to()` is only a lexical containment check unless both the source and root have first been resolved into canonical absolute paths. Relative paths and symlinks can otherwise bypass root-boundary assumptions.
**Prevention:** Resolve both source and root once, reject sources outside the resolved root with a sanitized `MediaShrinkerError`, and derive `rel_source` from the resolved paths before planning outputs.
## 2026-08-14 - [Sentinel: Insecure Default Authentication]
**์ทจ์•ฝ์ :** `saas_web.py`์˜ `require_api_key` ๋ฏธ๋“ค์›จ์–ด์—์„œ API ํ‚ค(`CODEC_CARVER_API_KEYS`)๊ฐ€ ๊ตฌ์„ฑ๋˜์ง€ ์•Š์€ ๊ฒฝ์šฐ ์ธ์ฆ์„ ์™„์ „ํžˆ ๊ฑด๋„ˆ๋›ฐ๋Š” ๊ธฐ๋ณธ์ ์œผ๋กœ ํ—ˆ์šฉ(open-by-default)๋˜๋Š” ์ทจ์•ฝ์ ์ด ๋ฐœ๊ฒฌ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ด๋Š” ์ธ์ฆ๋˜์ง€ ์•Š์€ ์‚ฌ์šฉ์ž๊ฐ€ ๋ฆฌ์†Œ์Šค๋ฅผ ์†Œ๋ชจํ•˜๊ฒŒ ๋งŒ๋“ค ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
**ํ•™์Šต:** ๋ณด์•ˆ ๊ธฐ๋Šฅ์€ ์„ ํƒ ์‚ฌํ•ญ(opt-in)์ด์–ด์„œ๋Š” ์•ˆ ๋ฉ๋‹ˆ๋‹ค. ํ™˜๊ฒฝ ๋ณ€์ˆ˜๊ฐ€ ์—†๊ฑฐ๋‚˜ ์ž˜๋ชป ๊ตฌ์„ฑ๋œ ๊ฒฝ์šฐ ๊ธฐ๋ณธ์ ์œผ๋กœ ์• ํ”Œ๋ฆฌ์ผ€์ด์…˜์€ ๊ฐ€์žฅ ์•ˆ์ „ํ•œ ์ƒํƒœ(fail-secure)์ธ ๋ชจ๋“  ์š”์ฒญ ๊ฑฐ๋ถ€๋กœ ๋Œ์•„๊ฐ€์•ผ ํ•ฉ๋‹ˆ๋‹ค.
**์˜ˆ๋ฐฉ:** ๋ฏธ๋“ค์›จ์–ด๋Š” ํ‚ค ๊ตฌ์„ฑ ์—ฌ๋ถ€์— ๊ด€๊ณ„์—†์ด `GET /`๋ฅผ ์ œ์™ธํ•œ ๋ชจ๋“  ์—”๋“œํฌ์ธํŠธ์—์„œ ํ•ญ์ƒ ์ธ์ฆ์„ ์š”๊ตฌํ•˜๋„๋ก ์„ค์ •(secure-by-default)๋˜์–ด์•ผ ํ•˜๋ฉฐ, ํ‚ค๊ฐ€ ์„ค์ •๋˜์ง€ ์•Š์€ ๊ฒฝ์šฐ์—๋„ 401 ์˜ค๋ฅ˜๋ฅผ ๋ฐ˜ํ™˜ํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค.
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,3 @@

### Fixed
- ๋‹จ์ผยท์ผ๊ด„ ๋Œ€์ƒ ํฌ๊ธฐ ์ž…๋ ฅ์„ ๋น„์› ์„ ๋•Œ ์ด์ „ custom validity์™€ `aria-invalid` ์ƒํƒœ๋ฅผ ์ฆ‰์‹œ ์ดˆ๊ธฐํ™”ํ•ด ํ˜„์žฌ ํ•„์ˆ˜ ์ž…๋ ฅ ์ƒํƒœ๋ฅผ ์ •ํ™•ํžˆ ์ „๋‹ฌํ•ฉ๋‹ˆ๋‹ค.
- ์—…๋กœ๋“œ ํŒŒ์ผ๋ช…์˜ ๊ฒฝ๋กœ ๊ตฌ๋ถ„์ž๋ฅผ ์ •๊ทœํ™”ํ•˜์—ฌ POSIX์—์„œ๋„ Windows ํ˜•์‹์˜ ํด๋ผ์ด์–ธํŠธ ๊ฒฝ๋กœ๊ฐ€ ์ผ๊ด€๋œ basename์œผ๋กœ ๊ธฐ๋ก๋˜๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
Loading
Loading