🛡️ Sentinel: [CRITICAL] 500 서버 에러(DoS)를 유발하는 API 키 검증 취약점 수정

[seonghobae]

🚨 Severity: CRITICAL
💡 Vulnerability: 사용자가 제공한 악의적인 헤더에 비-ASCII 문자가 포함되어 있을 때, require_api_key 미들웨어에서 호출하는 hmac.compare_digest 함수에서 TypeError 예외가 발생하는 취약점을 발견했습니다.
🎯 Impact: 공격자가 특수 문자가 포함된 API 키 헤더로 요청을 반복적으로 전송하여 서버 애플리케이션의 정상 동작을 방해하고 DoS(서비스 거부)를 유발할 수 있습니다.
🔧 Fix: hmac.compare_digest에 인자를 전달하기 전에 두 문자열 모두 명시적으로 utf-8 바이트로 인코딩하도록 코드를 수정했습니다.
✅ Verification: 해당 문제를 재현하고 방지할 수 있는 명시적인 바이트 인코딩 기반의 단위 테스트(test_non_ascii_key_rejected_safely)를 추가하였으며, 전체 테스트 스위트를 성공적으로 통과했습니다.

---

PR created automatically by Jules for task 5304637183808450453 started by @seonghobae

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 116 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5425873d-e221-4859-91e1-ef4c2dcb39f6

📥 Commits

Reviewing files that changed from the base of the PR and between a8e4956 and 12abebe.

📒 Files selected for processing (3)

• .jules/sentinel.md
• saas_web.py
• tests/test_saas_web.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[opencode-agent]

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 12abebe796fc07740267f08c1d36bfd266898fac.

• Head SHA: 12abebe796fc07740267f08c1d36bfd266898fac

• Workflow run: 31748644165

• Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (2 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (2 files)"]
  R1 --> V1["required checks"]
  Evidence --> S2["Test: test_saas_web.py"]
  S2 --> I2["regression suite"]
  I2 --> R2["Review risk: Test: test_saas_web.py"]
  R2 --> V2["targeted test run"]

Loading

[opencode-agent]

OpenCode Review Overview

• Head SHA: 12abebe796fc07740267f08c1d36bfd266898fac
• Workflow run: 31748644165
• Workflow attempt: 1
• Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 12abebe796fc07740267f08c1d36bfd266898fac.

• Head SHA: 12abebe796fc07740267f08c1d36bfd266898fac

• Workflow run: 31748644165

• Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (2 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (2 files)"]
  R1 --> V1["required checks"]
  Evidence --> S2["Test: test_saas_web.py"]
  S2 --> I2["regression suite"]
  I2 --> R2["Review risk: Test: test_saas_web.py"]
  R2 --> V2["targeted test run"]

Loading

[seonghobae]

Closing as superseded by #390 after exact-diff review. Both branches implement the same UTF-8 byte conversion before hmac.compare_digest and the same non-ASCII-header → 401 regression. The canonical #390 branch is based on the live main tip and now also preserves this family’s one-time encoding of the provided key; this PR has no remaining unique production behavior.

[google-labs-jules]

Closing as superseded by #390 after exact-diff review. Both branches implement the same UTF-8 byte conversion before hmac.compare_digest and the same non-ASCII-header → 401 regression. The canonical #390 branch is based on the live main tip and now also preserves this family’s one-time encoding of the provided key; this PR has no remaining unique production behavior.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.