fix(ci): defer repository-local jobs while PRs are Draft - #931
Conversation
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Validated finding against protected main: repository-local Tests, PROV-O and Ontology Pages admitted expensive jobs for Draft pull-request events even though the repository currently had a 106-run queued backlog and no in-progress run. The RED contract precedes the workflow repairs. Scope remains CI admission only: central required workflows and the organization plan ceiling are not reimplemented or weakened here. Before any merge, retain exact-head identity and ordinary merge semantics; no self-approval or predecessor GREEN transfer.
Adopt the protected #931 Draft-admission workflow delta on the Event Lineage branch while preserving the branch's product/UI changes. The protected delta and PR delta touch disjoint files, so this merge commit keeps both histories without destructive rebase.
Adopt protected #931 workflow/contract blobs on the CalDAV-boundary cleanup branch while preserving the branch's DDD deletion delta. No provider boundary or CalendarWeave authority is introduced.
Merge the protected #931 workflow/contract blobs into the public-surface branch without dropping the branch's structural hosted-runner regression. This intentionally leaves the runner contract RED (`ubuntu-latest` vs required explicit `ubuntu-24.04`) so the follow-up can combine both valid contracts instead of choosing one side of the conflict.
Adopt protected #931 workflow/contract blobs on the Voice export branch while preserving the evidence/export product delta. This non-force two-parent convergence keeps the child stack repairable without transferring predecessor evidence.
Finding
Fresh Actions state showed 106 queued workflow runs and 0 in-progress runs in LineageWeave while the active implementation PRs remained Draft. The protected-main repository-local workflows still admitted expensive Full suite, Frontend, PROV-O and ontology-validation jobs on Draft
opened/synchronizeevents. That spends scarce runner admission on work that cannot be merged yet and compounds the documented organization-level concurrent-job ceiling.This PR does not claim to raise the organization plan limit or change central required-workflow policy.
ContextualWisdomLab/.githubremains the canonical owner of organization-required workflows and queue coalescing. This repair only stops LineageWeave-owned repository-local jobs from consuming runners while a PR is Draft.RED → causal repair
470dca8db680ec56a740f4eee5a618eb1517d6eapins the repository contract: Tests, PROV-O, and Ontology Pages must listen forready_for_review/converted_to_draft, and their expensive PR jobs must requiregithub.event.pull_request.draft == false.2552d92ba5478f4e2a093e2811f7fc1c5c7af5e8applies the admission boundary to Full suite and Frontend.cd23edfee3517829e11f301a581352f2a864d778applies it to the PROV-O contract job.81df80ca040df57a8964056c3bda07cdab90f1b8applies it to ontology validation while leaving protected-main publication behavior unchanged.The event design is deliberate.
converted_to_draftremains in the same PR concurrency group so it can cancel an older queued synchronize run; its expensive jobs then skip.ready_for_reviewreruns the exact head when review readiness returns. The guard is job-level rather than a workflow-level omission, preserving a terminal skipped/success check shape instead of creating a required-check path that may never report.Boundary and safety
main@03dddb69ef7c2910798801803bb222dffcaac5e381df80ca040df57a8964056c3bda07cdab90f1b8behind_by=0, four workflow/contract files only.githubsource is copied or weakenedThe repository-wide queue is currently capacity-starved, so hosted exact-head execution may itself be unable to acquire a runner. The CWL execution contract explicitly permits ordinary bypass merge for a chicken-and-egg workflow-ceiling repair when the repair cannot obtain the capacity it is intended to conserve. If the exact head cannot acquire a runner, merge eligibility must still be limited to this narrowly reviewed workflow repair; this exception must not be generalized to product changes.