refactor(ddd): remove obsolete direct CalDAV boundary - #904
Draft
seonghobae wants to merge 10 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merge protected main@3f61c824 into the Calendar boundary cleanup without rewriting history. The protected-main delta only adds docs/index.md and is disjoint from the retired pseudo-CalDAV adapter/configuration removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Protected
mainalready has the strict Naruon calendar projection consumer/ACL, but retained the supersededlineageweave/caldav_client.py, its dedicated tests,Settings.caldav_base_url, andCALDAV_BASE_URLdeployment wiring. That left a second direct-provider-shaped source/configuration path whose name and custom/eventssemantics contradicted ADR 0203 and the current Calendar composition boundary.TDD / repair
The branch began with RED-only
tests/test_calendar_authority_fitness.py. The regression requires the obsolete pseudo-CalDAV adapter/test/config/deployment surface to be absent while preservingNARUON_CALENDAR_BASE_URLandNARUON_CALENDAR_SERVICE_TOKEN. The protected-main predecessor contained the forbidden adapter and configuration, and the focused regression was independently reproduced as a real failing assertion before production changes.The causal cleanup:
lineageweave/caldav_client.pyand its obsolete unit test;caldav_base_urlfrom runtimeSettingsand stops readingCALDAV_BASE_URL;.env.exampleand Compose deployment wiring for that retired boundary;CALDAV_BASE_URLprocess value cannot activate the Naruon calendar channel, but no longer exposes it as a settings field;This change does not retarget the current Naruon compatibility media type to CalendarWeave; issue #900 remains the later immutable-owner-contract migration boundary. CalendarWeave still has no GitHub release, and its live Draft stack #1 → #3 → #4 → #5 explicitly leaves VTIMEZONE/recurrence/CalDAV/provider/service-auth/consumer migration unavailable, so no CalendarWeave authority is invented here.
Exact live state
Protected
mainadvanced to3f61c8242b9c02dec307a7396e83e28f7cdd9f3dthrough #905, whose only delta isdocs/index.md. That path is disjoint from this cleanup, so the branch was non-destructively restacked by merge commitaa87a9755bed6f55368856da2f1e7d855822d7a5rather than rewritten.main@3f61c8242b9c02dec307a7396e83e28f7cdd9f3daa87a9755bed6f55368856da2f1e7d855822d7a533494973658, Security33494973574, and SAST33494973616were queued at the latest sweep and are non-passingKeep Draft until the unchanged current head passes focused/full repository validation and normal review/security governance. No force push, self-approval, provider credential path, foreign database access, or gate weakening.