perf(benchmarks): bump TargetFramework net8.0 → net10.0 (#220)#227
Merged
Conversation
The src project ships net10.0 as a target; benchmark numbers should reflect what consumers on the modern runtime actually see. Bumps the benchmarks csproj and the benchmarks.yaml SDK install to match. The .github/workflows/benchmarks.yaml change makes this a protected- file PR — needs admin-bypass merge per protected-file-pr-split. Closes #220
2 tasks
Chris-Wolfgang
added a commit
that referenced
this pull request
Jun 30, 2026
Tier-2 cleanup round surfaced by the v0.3.3 AI code-review pass. No public API change in Wolfgang.TryPattern itself; PATCH bump per SemVer. Contents this release: - Docs: README database example converted to Try.RunAsync / ExecuteReaderAsync (#226, closes #221) - Perf: benchmarks project bumped net8.0 -> net10.0 + workflow SDK install bumped to 10.0.x (#227, closes #220) - Fix: PublicApiAnalyzer manifest — Result<T>.Value.get moved into per-TFM split (modern: T?, legacy: T); the previous top-level entry was silently wrong against modern builds (#228, closes #219) - Chore: xunit.runner.visualstudio bumped 3.0.0 -> 3.1.5 (latest 3.x GA; xunit core 2.9.3 stays put — 3.x runner supports xunit 1/2/3) (#229, closes #218) - Chore: test directory + namespace aligned under single Wolfgang.TryPattern.Tests.Unit identity (directory, csproj, assembly, namespace, sln + stryker config) (#231, closes #222) - Fix: scripts/build-pr.ps1 restored -UseBasicParsing on Invoke-WebRequest (#230, merged directly to main)
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Src ships
net10.0; benchmark numbers should reflect the modern runtime consumers actually use. Bumpsbenchmarks/Wolfgang.TryPattern.Benchmarks.csprojfrom<TargetFramework>net8.0</TargetFramework>tonet10.0and updates.github/workflows/benchmarks.yaml'ssetup-dotnetstep from8.0.xto10.0.xso the post-merge benchmark publish keeps working.Stacked on #226. Base auto-promotes to vNext when #226 merges.
Test plan
dotnet build benchmarks/Wolfgang.TryPattern.Benchmarks -c Releaseclean (0 warnings, 0 errors)Protected-file note
This PR touches
.github/workflows/benchmarks.yaml, which trips theDetect .NET Projectsguard. Needs maintainer admin-bypass to merge perprotected-file-pr-split. The csproj + workflow updates are tightly coupled (csproj alone breaks the workflow build; workflow alone has no project to run against), so they must land together.Closes #220